add specs

Author: tycooon

spec/fixtures/coverer.rb

@@ -2,8 +2,5 @@
 
 require "coverage"
 Coverage.start(:all)
-require_relative "uneven_nocovs"
-
-UnevenNocov.call(42)
-
+require_relative "methods"
 p Coverage.result

spec/fixtures/methods.rb

@@ -0,0 +1,18 @@
+class A
+  def method1
+    puts "hello from method1"
+    method2
+  end
+
+private
+
+  def method2
+    puts "hello from method2"
+  end
+
+  def method3
+    puts "hello from method3"
+  end
+end
+
+A.new.method1

spec/source_file/method_spec.rb

@@ -3,5 +3,48 @@
 require "helper"
 
 describe SimpleCov::SourceFile::Method do
-  # TODO[@tycooon]: add specs
+  subject { described_class.new(source_file, info, coverage) }
+
+  let(:source_file) do
+    SimpleCov::SourceFile.new(source_fixture("methods.rb"), lines: {})
+  end
+
+  let(:info) { ["A", :method1, 2, 2, 5, 5] }
+  let(:coverage) { 1 }
+
+  it "is covered" do
+    expect(subject.covered?).to eq(true)
+  end
+
+  it "is not skipped" do
+    expect(subject.skipped?).to eq(false)
+  end
+
+  it "is not missed" do
+    expect(subject.missed?).to eq(false)
+  end
+
+  it "has 4 lines" do
+    expect(subject.lines.size).to eq(4)
+  end
+
+  it "converts to string properly" do
+    expect(subject.to_s).to eq("A#method1")
+  end
+
+  context "uncovered method" do
+    let(:coverage) { 0 }
+
+    it "is not covered" do
+      expect(subject.covered?).to eq(false)
+    end
+
+    it "is not skipped" do
+      expect(subject.skipped?).to eq(false)
+    end
+
+    it "is missed" do
+      expect(subject.missed?).to eq(true)
+    end
+  end
 end

spec/source_file_spec.rb

@@ -69,7 +69,6 @@
       end
     end
 
-    # TODO[@tycooon]: add method cov
     describe "branch coverage" do
       it "has total branches count 0" do
         expect(subject.total_branches.size).to eq(0)
@@ -91,23 +90,43 @@
         expect(subject.branches_report).to eq({})
       end
     end
+
+    describe "method coverage" do
+      it "has total methods count 0" do
+        expect(subject.total_methods.size).to eq(0)
+      end
+
+      it "has covered methods count 0" do
+        expect(subject.covered_methods.size).to eq(0)
+      end
+
+      it "has missed methods count 0" do
+        expect(subject.missed_methods.size).to eq(0)
+      end
+
+      it "is considered 100% methods covered" do
+        expect(subject.methods_coverage_percent).to eq(100.0)
+      end
+    end
   end
 
   context "file with branches" do
-    COVERAGE_FOR_BRANCHES_RB = {
-      lines: [1, 1, 1, nil, 1, nil, 1, 0, nil, 1, nil, nil, nil],
-      branches: {
-        [:if, 0, 3, 4, 3, 21] =>
-          {[:then, 1, 3, 4, 3, 10] => 0, [:else, 2, 3, 4, 3, 21] => 1},
-        [:if, 3, 5, 4, 5, 26] =>
-          {[:then, 4, 5, 16, 5, 20] => 1, [:else, 5, 5, 23, 5, 26] => 0},
-        [:if, 6, 7, 4, 11, 7] =>
-          {[:then, 7, 8, 6, 8, 10] => 0, [:else, 8, 10, 6, 10, 9] => 1}
+    let(:coverage_for_branches_rb) do
+      {
+        lines: [1, 1, 1, nil, 1, nil, 1, 0, nil, 1, nil, nil, nil],
+        branches: {
+          [:if, 0, 3, 4, 3, 21] =>
+            {[:then, 1, 3, 4, 3, 10] => 0, [:else, 2, 3, 4, 3, 21] => 1},
+          [:if, 3, 5, 4, 5, 26] =>
+            {[:then, 4, 5, 16, 5, 20] => 1, [:else, 5, 5, 23, 5, 26] => 0},
+          [:if, 6, 7, 4, 11, 7] =>
+            {[:then, 7, 8, 6, 8, 10] => 0, [:else, 8, 10, 6, 10, 9] => 1}
+        }
       }
-    }.freeze
+    end
 
     subject do
-      SimpleCov::SourceFile.new(source_fixture("branches.rb"), COVERAGE_FOR_BRANCHES_RB)
+      SimpleCov::SourceFile.new(source_fixture("branches.rb"), coverage_for_branches_rb)
     end
 
     describe "branch coverage" do
@@ -164,6 +183,60 @@
     end
   end
 
+  context "file with methods" do
+    let(:coverage_for_methods_rb) do
+      {
+        lines: [1, 1, 1, 1, nil, nil, 1, nil, 1, 1, nil, nil, 1, 0, nil, nil, nil, 1],
+        branches: {},
+        methods: {
+          ["A", :method3, 13, 2, 15, 5] => 0,
+          ["A", :method2, 9, 2, 11, 5] => 1,
+          ["A", :method1, 2, 2, 5, 5] => 1
+        }
+      }
+    end
+
+    subject do
+      SimpleCov::SourceFile.new(source_fixture("methods.rb"), coverage_for_methods_rb)
+    end
+
+    describe "method coverage" do
+      it "has total methods count 0" do
+        expect(subject.total_methods.size).to eq(3)
+      end
+
+      it "has covered methods count 0" do
+        expect(subject.covered_methods.size).to eq(2)
+      end
+
+      it "has missed methods count 0" do
+        expect(subject.missed_methods.size).to eq(1)
+      end
+
+      it "is considered 66.(6)% methods covered" do
+        expect(subject.methods_coverage_percent).to eq(66.66666666666667)
+      end
+    end
+
+    describe "line coverage" do
+      it "has line coverage" do
+        expect(subject.covered_percent).to eq 90.0
+      end
+
+      it "has 9 covered lines" do
+        expect(subject.covered_lines.size).to eq 9
+      end
+
+      it "has 1 missed line" do
+        expect(subject.missed_lines.size).to eq 1
+      end
+
+      it "has 10 relevant lines" do
+        expect(subject.relevant_lines).to eq 10
+      end
+    end
+  end
+
   context "simulating potential Ruby 1.9 defect -- see Issue #56" do
     subject do
       SimpleCov::SourceFile.new(source_fixture("sample.rb"), COVERAGE_FOR_SAMPLE_RB_WITH_MORE_LINES)
@@ -234,6 +307,10 @@
     it "has 100.0 branch coverage" do
       expect(subject.branches_coverage_percent).to eq(100.00)
     end
+
+    it "has 100.0 method coverage" do
+      expect(subject.methods_coverage_percent).to eq(100.00)
+    end
   end
 
   context "a file where nothing is ever executed mixed with skipping #563" do
@@ -327,6 +404,17 @@
         expect(subject.covered_branches.size).to eq 0
       end
     end
+
+    describe "method coverage" do
+      it "has no methods" do
+        expect(subject.total_methods.size).to eq 0
+      end
+
+      it "does has neither covered nor missed methods" do
+        expect(subject.missed_methods.size).to eq 0
+        expect(subject.covered_methods.size).to eq 0
+      end
+    end
   end
 
   context "a file with more complex skipping" do