Skip to content

When using minitest 6, error codes raised by minimum_coverage are not included in the exit status $? #1152

@claudiob

Description

@claudiob

I have a Rails app that uses Simplecov with the SimpleCov.minimum_coverage option.
If the test suite doesn't satisfy that minimum coverage, SimpleCov prints out this message:

SimpleCov failed with exit 2 due to a coverage related error

  • Until minitest 5, this error would also result in the exit status $? correctly set to 2.
  • With minitest 6 (namely 6.0.1), this error is somehow "ingested" and the exit status $? is set to 0 (as though no error had occurred)

Note that I only have this issue if SimpleCov.minimum_coverage is not satisfied.
If the tests fail, then I see the failing test and the exit status $? is set to 1 (as expected).

I looked at other GitHub issues related to minitest/simplecov and I couldn't find one specific to the SimpleCov.minimum_coverage option.

Let me know if I can help triage this issue in any way. Thanks for your library, it's awesome ❤️

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions