Remove diabetesManagementEnabled arg from showDiagnosisError

Author: sagarwal

app/src/main/java/org/simple/clinic/summary/PatientSummaryEffect.kt

@@ -109,9 +109,7 @@ data class ShowScheduleAppointmentSheet(
     val currentFacility: Facility
 ) : PatientSummaryViewEffect()
 
-data class ShowDiagnosisError(
-    val diabetesManagementEnabled: Boolean
-) : PatientSummaryViewEffect()
+data object ShowDiagnosisError: PatientSummaryViewEffect()
 
 data object ShowHypertensionDiagnosisError : PatientSummaryViewEffect()
 

app/src/main/java/org/simple/clinic/summary/PatientSummaryScreen.kt

@@ -577,10 +577,10 @@ class PatientSummaryScreen :
     ))
   }
 
-  override fun showDiagnosisError(diabetesManagementEnabled: Boolean) {
+  override fun showDiagnosisError() {
     // Diagnosis error message could be obscured, scroll until the entire view is visible
     summaryViewsContainer.scrollToChild(medicalHistorySummaryView) {
-      medicalHistorySummaryView.showDiagnosisError(diabetesManagementEnabled)
+      medicalHistorySummaryView.showDiagnosisError()
     }
   }
 

app/src/main/java/org/simple/clinic/summary/PatientSummaryUiActions.kt

@@ -22,7 +22,7 @@ interface PatientSummaryUiActions {
   fun showUpdatePhoneDialog(patientUuid: UUID)
   fun showAddPhoneDialog(patientUuid: UUID)
   fun showLinkIdWithPatientView(patientUuid: UUID, identifier: Identifier)
-  fun showDiagnosisError(diabetesManagementEnabled: Boolean)
+  fun showDiagnosisError()
   fun showHypertensionDiagnosisError()
   fun openPatientContactSheet(patientUuid: UUID)
   fun navigateToTeleconsultRecordScreen(patientUuid: UUID, teleconsultRecordId: UUID)

app/src/main/java/org/simple/clinic/summary/PatientSummaryViewEffectHandler.kt

@@ -20,7 +20,7 @@ class PatientSummaryViewEffectHandler(
           currentFacility = viewEffect.currentFacility
       )
 
-      is ShowDiagnosisError -> uiActions.showDiagnosisError(viewEffect.diabetesManagementEnabled)
+      is ShowDiagnosisError -> uiActions.showDiagnosisError()
       is ShowHypertensionDiagnosisError -> uiActions.showHypertensionDiagnosisError()
       is OpenContactPatientScreen -> uiActions.openPatientContactSheet(viewEffect.patientUuid)
       is NavigateToTeleconsultRecordScreen -> uiActions.navigateToTeleconsultRecordScreen(viewEffect.patientUuid, viewEffect.teleconsultRecordId)

app/src/main/java/org/simple/clinic/summary/medicalhistory/MedicalHistorySummaryView.kt

@@ -186,8 +186,8 @@ class MedicalHistorySummaryView(
     modelUpdateCallback = callback
   }
 
-  fun showDiagnosisError(diabetesManagementEnabled: Boolean) {
-    SelectDiagnosisErrorDialog.show(activity.supportFragmentManager, diabetesManagementEnabled)
+  fun showDiagnosisError() {
+    SelectDiagnosisErrorDialog.show(activity.supportFragmentManager, true)
   }
 
   fun showHypertensionDiagnosisError() {

app/src/test/java/org/simple/clinic/summary/PatientSummaryEffectHandlerTest.kt

@@ -376,10 +376,10 @@ class PatientSummaryEffectHandlerTest {
   @Test
   fun `when show diagnosis error effect is received, then show diagnosis error`() {
     // when
-    testCase.dispatch(ShowDiagnosisError(true))
+    testCase.dispatch(ShowDiagnosisError)
 
     // then
-    verify(uiActions).showDiagnosisError(true)
+    verify(uiActions).showDiagnosisError()
     verifyNoMoreInteractions(uiActions)
     testCase.assertNoOutgoingEvents()
   }

app/src/test/java/org/simple/clinic/summary/PatientSummaryUpdateTest.kt

@@ -232,7 +232,7 @@ class PatientSummaryUpdateTest {
   }
 
   @Test
-  fun `when there are patient summary changes and at least one measurement is present and no diagnosis is recorded and diabetes management is enabled, then clicking on back must show diagnosis error`() {
+  fun `when no diagnosis is recorded and diabetes management is enabled, then clicking on back must show diagnosis error`() {
     val model = defaultModel.currentFacilityLoaded(facilityWithDiabetesManagementEnabled)
 
     updateSpec
@@ -254,12 +254,12 @@ class PatientSummaryUpdateTest {
         ))
         .then(assertThatNext(
             hasNoModel(),
-            hasEffects(ShowDiagnosisError(true) as PatientSummaryEffect)
+            hasEffects(ShowDiagnosisError as PatientSummaryEffect)
         ))
   }
 
   @Test
-  fun `when there are patient summary changes and at least one measurement is present and no diagnosis is recorded and diabetes management is disabled, then show diagnosis error`() {
+  fun `when no diagnosis is recorded and diabetes management is disabled, then show diagnosis error`() {
     val model = defaultModel.currentFacilityLoaded(facilityWithDiabetesManagementDisabled)
 
     updateSpec
@@ -281,7 +281,7 @@ class PatientSummaryUpdateTest {
         ))
         .then(assertThatNext(
             hasNoModel(),
-            hasEffects(ShowDiagnosisError(false) as PatientSummaryEffect)
+            hasEffects(ShowHypertensionDiagnosisError)
         ))
   }
 
@@ -452,7 +452,7 @@ class PatientSummaryUpdateTest {
   }
 
   @Test
-  fun `when at least one measurement is present and diagnosis is not recorded and diabetes management is enabled, clicking on save must show diagnosis error`() {
+  fun `when diagnosis is not recorded and diabetes management is enabled, clicking on save must show diagnosis error`() {
     val model = defaultModel.currentFacilityLoaded(facilityWithDiabetesManagementEnabled)
 
     updateSpec
@@ -474,12 +474,12 @@ class PatientSummaryUpdateTest {
         ))
         .then(assertThatNext(
             hasNoModel(),
-            hasEffects(ShowDiagnosisError(true) as PatientSummaryEffect)
+            hasEffects(ShowDiagnosisError as PatientSummaryEffect)
         ))
   }
 
   @Test
-  fun `when at least one measurement is present and diagnosis is not recorded and diabetes management is disabled, clicking on save must show diagnosis error`() {
+  fun `when diagnosis is not recorded and diabetes management is disabled, clicking on save must show diagnosis error`() {
     val model = defaultModel.currentFacilityLoaded(facilityWithDiabetesManagementDisabled)
 
     updateSpec
@@ -501,7 +501,7 @@ class PatientSummaryUpdateTest {
         ))
         .then(assertThatNext(
             hasNoModel(),
-            hasEffects(ShowDiagnosisError(false) as PatientSummaryEffect)
+            hasEffects(ShowHypertensionDiagnosisError)
         ))
   }