Fix updated_at not updating when a business identifier is updated

Author: sagarwal

app/src/main/java/org/simple/clinic/editpatient/EditPatientEffectHandler.kt

@@ -33,6 +33,7 @@ import org.simple.clinic.util.UtcClock
 import org.simple.clinic.util.filterAndUnwrapJust
 import org.simple.clinic.util.scheduler.SchedulersProvider
 import org.simple.clinic.uuid.UuidGenerator
+import java.time.Instant
 import java.time.LocalDate
 import java.time.format.DateTimeFormatter
 import java.util.UUID
@@ -267,7 +268,12 @@ class EditPatientEffectHandler @AssistedInject constructor(
   private fun updateAlternativeId(savePatientEffects: Observable<SavePatientEffect>): Observable<EditPatientEvent> {
     return savePatientEffects
         .filter(::isAlternativeIdModified)
-        .map { it.saveAlternativeId?.updateIdentifierValue(it.ongoingEntry.alternativeId) }
+        .map {
+          it.saveAlternativeId?.updateIdentifierValue(
+              newValue = it.ongoingEntry.alternativeId,
+              updatedAt = Instant.now(utcClock)
+          )
+        }
         .flatMapCompletable { patientRepository.saveBusinessId(it) }
         .toObservable()
   }

app/src/main/java/org/simple/clinic/patient/businessid/BusinessId.kt

@@ -84,8 +84,11 @@ data class BusinessId(
     )
   }
 
-  fun updateIdentifierValue(newValue: String): BusinessId =
-      copy(identifier = identifier.copy(value = newValue))
+  fun updateIdentifierValue(newValue: String, updatedAt: Instant): BusinessId =
+      copy(
+          identifier = identifier.copy(value = newValue),
+          updatedAt = updatedAt
+      )
 
   sealed class MetaDataVersion : Parcelable {
 

app/src/test/java/org/simple/clinic/editpatient/EditPatientEffectHandlerTest.kt

@@ -186,7 +186,12 @@ class EditPatientEffectHandlerTest {
     // given
     val bangladeshNationalIdText = "1569273"
     val ongoingEntryWithBangladeshId = entry.updateAlternativeId(bangladeshNationalIdText)
-    val updatedBangladeshNationalId = bangladeshNationalId.updateIdentifierValue(bangladeshNationalIdText)
+    val now = Instant.now(utcClock)
+    val updatedBangladeshNationalId =
+        bangladeshNationalId.updateIdentifierValue(
+            newValue = bangladeshNationalIdText,
+            updatedAt = now
+        )
 
     whenever(patientRepository.updatePatient(patient)) doReturn Completable.complete()
     whenever(patientRepository.updateAddressForPatient(patient.uuid, patientAddress)) doReturn Completable.complete()