Update gradle dependencies (#5533)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Siddharth Agarwal <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -2,6 +2,22 @@
 
 ## Next Release
 
+### Internal
+- Bump AGP to v8.12.0
+- Bump Lint to v31.12.0
+- Bump Kotlin to v2.2.0
+- Bump KSP to v2.2.0-2.0.2
+- Bump dagger to v2.57
+- Bump okhttp to v5.1.0
+- Bump retrofit to v3.0.0
+- Bump sqlcipher to v4.10.0
+- Bump AndroidX AppCompat to v1.7.1
+- Bump AndroidX Fragment KTX to v1.8.8
+- Bump asm to v9.8
+- Bump firebase remote config to v23.0.0
+- Bump Firebase Analytics KTX to v22.5.0
+- Bump Jackson Core to v2.19.2
+
 ### Changes
 
 - Update min sdk version to 26 (Android 8.0)
@@ -57,6 +73,7 @@
 - Bump Sentry to v8.11.0
 - Bump Dagger to v2.56.2
 - Bump Coroutines to v1.10.2
+- Bump AGP to v8.9.2
 - Skip Sentry config during app startup in the debug mode
 - Show spanish language option in non-production builds only
 - Increase lab based risk threshold to 20%

app/build.gradle.kts

@@ -184,19 +184,6 @@ android {
     beforeVariants { variant ->
       variant.enable = variant.name !in filteredVariants
     }
-
-    onVariants(selector().all()) { variant ->
-      afterEvaluate {
-        // This is a workaround for https://issuetracker.google.com/301245705 which depends on internal
-        // implementations of the android gradle plugin and the ksp gradle plugin which might change in the future
-        // in an unpredictable way.
-        val variantName = variant.name.replaceFirstChar { it.titlecase() }
-        project.tasks.getByName("ksp" + variantName + "Kotlin") {
-          val dataBindingTask = project.tasks.getByName("dataBindingGenBaseClasses$variantName") as DataBindingGenBaseClassesTask
-          (this as AbstractKotlinCompileTool<*>).setSource(dataBindingTask.sourceOutFolder)
-        }
-      }
-    }
   }
 
   lint {
@@ -216,7 +203,10 @@ android {
 
   kotlinOptions {
     jvmTarget = JavaVersion.VERSION_17.toString()
-    freeCompilerArgs = freeCompilerArgs + listOf("-Xopt-in=kotlinx.coroutines.ExperimentalCoroutinesApi")
+    freeCompilerArgs = freeCompilerArgs + listOf(
+        "-Xopt-in=kotlinx.coroutines.ExperimentalCoroutinesApi",
+        "-Xannotation-default-target=param-property"
+    )
   }
 
   sourceSets {

app/lint.xml

@@ -55,6 +55,7 @@
 
   <issue id="ParcelCreator" severity="informational" />
   <issue id="GradleDependency" severity="informational" />
+  <issue id="NewerVersionAvailable" severity="informational" />
   <issue id="PluralsCandidate" severity="informational" />
   <issue id="CannotEnableHidden" severity="informational" />
 

app/src/main/java/org/simple/clinic/appupdate/criticalupdatedialog/CriticalAppUpdateDialog.kt

@@ -3,13 +3,13 @@ package org.simple.clinic.appupdate.criticalupdatedialog
 import android.content.ActivityNotFoundException
 import android.content.Context
 import android.content.Intent
-import android.net.Uri
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.View.GONE
 import android.view.View.VISIBLE
 import android.view.ViewGroup
+import androidx.core.net.toUri
 import com.jakewharton.rxbinding3.view.clicks
 import com.spotify.mobius.functions.Consumer
 import io.reactivex.Observable
@@ -148,7 +148,7 @@ class CriticalAppUpdateDialog : BaseDialog<
 
   override fun openContactUrl(url: String) {
     val packageManager = requireContext().packageManager
-    val intent = Intent(Intent.ACTION_VIEW, Uri.parse(url))
+    val intent = Intent(Intent.ACTION_VIEW, url.toUri())
 
     if (intent.resolveActivity(packageManager) != null) {
       requireContext().startActivity(intent)
@@ -159,7 +159,7 @@ class CriticalAppUpdateDialog : BaseDialog<
 
   override fun openSimpleInGooglePlay() {
     val packageManager = requireContext().packageManager
-    val intent = Intent(Intent.ACTION_VIEW, Uri.parse(PLAY_STORE_URL_FOR_SIMPLE))
+    val intent = Intent(Intent.ACTION_VIEW, PLAY_STORE_URL_FOR_SIMPLE.toUri())
 
     if (intent.resolveActivity(packageManager) != null) {
       requireContext().startActivity(intent)

app/src/main/java/org/simple/clinic/appupdate/dialog/AppUpdateDialog.kt

@@ -3,12 +3,11 @@ package org.simple.clinic.appupdate.dialog
 import android.app.Dialog
 import android.content.Intent
 import android.content.Intent.ACTION_VIEW
-import android.net.Uri
 import android.os.Bundle
+import androidx.core.net.toUri
 import androidx.fragment.app.DialogFragment
 import androidx.fragment.app.FragmentManager
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
-import org.simple.clinic.BuildConfig
 import org.simple.clinic.PLAY_STORE_URL_FOR_SIMPLE
 import org.simple.clinic.R
 
@@ -40,7 +39,7 @@ class AppUpdateDialog : DialogFragment() {
 
   private fun launchPlayStoreForUpdate() {
     val intent = Intent(ACTION_VIEW).apply {
-      data = Uri.parse(PLAY_STORE_URL_FOR_SIMPLE)
+      data = PLAY_STORE_URL_FOR_SIMPLE.toUri()
     }
     startActivity(intent)
   }

app/src/main/java/org/simple/clinic/facilitypicker/FacilityPickerView.kt

@@ -6,7 +6,7 @@ import android.os.Parcelable
 import android.util.AttributeSet
 import android.view.LayoutInflater
 import android.widget.FrameLayout
-import android.widget.RelativeLayout
+import androidx.core.content.withStyledAttributes
 import androidx.recyclerview.widget.LinearLayoutManager
 import com.jakewharton.rxbinding3.recyclerview.scrollEvents
 import com.jakewharton.rxbinding3.recyclerview.scrollStateChanges
@@ -65,7 +65,7 @@ class FacilityPickerView(
       )
   )
 
-  private val pickFrom: PickFrom
+  private lateinit var pickFrom: PickFrom
 
   private var binding: ViewFacilitypickerBinding? = null
 
@@ -88,9 +88,9 @@ class FacilityPickerView(
     val layoutInflater = LayoutInflater.from(context)
     binding = ViewFacilitypickerBinding.inflate(layoutInflater, this)
 
-    val typedArray = context.obtainStyledAttributes(attributeSet, R.styleable.FacilityPickerView)
-    pickFrom = PickFrom.forAttribute(typedArray)
-    typedArray.recycle()
+    context.withStyledAttributes(attributeSet, R.styleable.FacilityPickerView) {
+      pickFrom = PickFrom.forAttribute(this)
+    }
 
     context.injector<Injector>().inject(this)
 
@@ -151,11 +151,11 @@ class FacilityPickerView(
   }
 
   override fun showProgressIndicator() {
-    progressIndicator.visibility = RelativeLayout.VISIBLE
+    progressIndicator.visibility = VISIBLE
   }
 
   override fun hideProgressIndicator() {
-    progressIndicator.visibility = RelativeLayout.GONE
+    progressIndicator.visibility = GONE
   }
 
   override fun updateFacilities(facilityItems: List<FacilityListItem>) {

app/src/main/java/org/simple/clinic/home/patients/PatientsTabScreen.kt

@@ -3,14 +3,14 @@ package org.simple.clinic.home.patients
 import android.content.ActivityNotFoundException
 import android.content.Context
 import android.content.Intent
-import android.net.Uri
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import android.view.animation.AnimationUtils
 import androidx.annotation.IdRes
 import androidx.appcompat.app.AppCompatActivity
+import androidx.core.net.toUri
 import androidx.interpolator.view.animation.FastOutSlowInInterpolator
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.jakewharton.rxbinding3.view.clicks
@@ -336,7 +336,7 @@ class PatientsTabScreen : BaseScreen<
 
   override fun openSimpleOnPlaystore() {
     val packageManager = requireContext().packageManager
-    val intent = Intent(Intent.ACTION_VIEW, Uri.parse(PLAY_STORE_URL_FOR_SIMPLE))
+    val intent = Intent(Intent.ACTION_VIEW, PLAY_STORE_URL_FOR_SIMPLE.toUri())
 
     if (intent.resolveActivity(packageManager) != null) {
       requireContext().startActivity(intent)

app/src/main/java/org/simple/clinic/introvideoscreen/IntroVideoScreen.kt

@@ -3,11 +3,11 @@ package org.simple.clinic.introvideoscreen
 import android.content.ActivityNotFoundException
 import android.content.Context
 import android.content.Intent
-import android.net.Uri
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import androidx.core.net.toUri
 import com.jakewharton.rxbinding3.view.clicks
 import com.spotify.mobius.functions.Consumer
 import io.reactivex.Observable
@@ -96,7 +96,7 @@ class IntroVideoScreen : BaseScreen<
 
   private fun openYoutubeLinkForSimpleVideo() {
     val packageManager = requireContext().packageManager
-    val intent = Intent(Intent.ACTION_VIEW, Uri.parse(simpleVideo.url))
+    val intent = Intent(Intent.ACTION_VIEW, simpleVideo.url.toUri())
 
     if (intent.resolveActivity(packageManager) != null) {
       requireContext().startActivity(intent)

app/src/main/java/org/simple/clinic/monthlyreports/form/compose/util/ColorUtil.kt

@@ -3,12 +3,13 @@ package org.simple.clinic.monthlyreports.form.compose.util
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.res.colorResource
+import androidx.core.graphics.toColorInt
 import org.simple.clinic.R
 
 @Composable
 fun getColor(colorString: String): Color {
   return try {
-    Color(android.graphics.Color.parseColor(colorString))
+    Color(colorString.toColorInt())
   } catch (_: Throwable) {
     colorResource(id = R.color.simple_dark_grey)
   }

app/src/main/java/org/simple/clinic/newentry/PatientEntryScreen.kt

@@ -13,6 +13,7 @@ import android.widget.EditText
 import android.widget.RadioButton
 import androidx.core.text.buildSpannedString
 import androidx.core.text.inSpans
+import androidx.core.view.isVisible
 import androidx.interpolator.view.animation.FastOutSlowInInterpolator
 import androidx.transition.ChangeBounds
 import androidx.transition.Fade
@@ -243,7 +244,7 @@ class PatientEntryScreen : BaseScreen<
 
   // FIXME This is temporally coupled to `scrollToFirstFieldWithError()`.
   private val allTextInputFields: List<EditText> by unsafeLazy {
-    val ageOrDateOfBirthEditText = if (ageEditTextInputLayout.visibility == View.VISIBLE) {
+    val ageOrDateOfBirthEditText = if (ageEditTextInputLayout.isVisible) {
       ageEditText
     } else {
       dateOfBirthEditText
@@ -697,7 +698,7 @@ class PatientEntryScreen : BaseScreen<
     val firstFieldWithError = views
         .filter {
           when {
-            isGenderErrorView(it) -> it.visibility == View.VISIBLE
+            isGenderErrorView(it) -> it.isVisible
             it is TextInputLayout -> it.error.isNullOrBlank().not()
             else -> throw AssertionError()
           }