Skip to content

Commit 1474341

Browse files
authored
fix(Dr. Rai Report): Fixes for Feedback (#5669)
**Story card:** [sc-16421](https://app.shortcut.com/simpledotorg/story/16421/fixes-to-dr-rai-mvp) ## Because Implementing feedback ## This addresses - **Fix the unit for ContactOverduePatientsIndicator** - **Disable edit buttons for now** ## Test instructions n/a
1 parent bf90751 commit 1474341

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

app/components/dashboard/dr_rai_report.html.erb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<i class="fa-solid fa-ellipsis"></i>
2020
</button>
2121
<div class="dropdown-menu dropdown-menu-right">
22-
<a class="dropdown-item edit" href="#">Edit</a>
23-
<div class="dropdown-divider"></div>
22+
<%# <a class="dropdown-item edit" href="#">Edit</a> %>
23+
<%# <div class="dropdown-divider"></div> %>
2424
<%= link_to "Delete", dr_rai_action_plan_path(action_plan), method: :delete, class: "dropdown-item delete" %>
2525
</div>
2626
</div>
@@ -106,7 +106,7 @@
106106
<%# <button class="link-button edit">Edit</button> %>
107107
<div class="goal-input-block">
108108
<label class="goal-label-block">
109-
<input type="text" placeholder="Q2 goal">
109+
<input type="text" placeholder="<%= abbreviated_quarter(selected_period) %> goal">
110110
<span class="">%</span>
111111
</label>
112112
<p class="missing-input-warning d-none">Enter a goal value</p>
@@ -127,7 +127,7 @@
127127
<%# <button class="link-button edit">Edit</button> %>
128128
<div class="goal-input-block">
129129
<label class="goal-label-block patients">
130-
<input type="text" placeholder="Q2 goal">
130+
<input type="text" placeholder="<%= abbreviated_quarter(selected_period) %> goal">
131131
<span class="">patients</span>
132132
</label>
133133
<p class="missing-input-warning d-none">Enter a goal value</p>

app/components/dashboard/dr_rai_report.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,8 @@ def is_lite_version?
8686
def human_readable_period period
8787
period.value.to_s.tr("-", " ")
8888
end
89+
90+
def abbreviated_quarter period
91+
period.value.to_s.split("-").first
92+
end
8993
end

app/models/dr_rai/contact_overdue_patients_indicator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def denominator_key
2121
end
2222

2323
def unit
24-
"overdue patients"
24+
"overdue patients called"
2525
end
2626

2727
def action_passive

0 commit comments

Comments
 (0)