Skip to content

Commit 1507825

Browse files
authored
Fix deleteing overlay bug on progress tab (#5702)
**Story card:** [sc-16754](https://app.shortcut.com/simpledotorg/story/16754/delete-overlay-persists-in-the-progress-tab) ## Because On the progress tab, the 'deleting action' overlay is showing by default. This overlay should never be shown on the progress tab, it's a dashboard action. <img width="616" height="548" alt="Screenshot 2025-09-25 at 12 25 26" src="https://github.com/user-attachments/assets/7a1908ba-4556-4391-9565-070cf40022ab" /> ## This addresses - Base state 'display: none;' - On delete action, add `d-flex` (display: flex;) to show element. ## Test instructions - Branch `dr-rai-deleting-overlay-progress-tab-fix` - Add any action to the current quarter action plan. - Navigate to the progress tab - The deleteing overlay should not be visible.
1 parent bced482 commit 1507825

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/assets/stylesheets/dr_rai.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,7 @@ $font-condensed: "Roboto Condensed", sans-serif;
583583
}
584584

585585
.deleting-overlay {
586+
display: none; // flex element
586587
position: absolute;
587588
top: 0;
588589
left: 0;
@@ -592,7 +593,6 @@ $font-condensed: "Roboto Condensed", sans-serif;
592593
color: white;
593594
background: rgba(77, 78, 54, 0.65);
594595
border-radius: 4px;
595-
display: flex;
596596
justify-content: center;
597597
align-items: center;
598598
opacity: 1;

app/components/dashboard/dr_rai_report.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
</div>
4747
</div>
4848
</div>
49-
<div class="deleting-overlay d-none">
49+
<div class="deleting-overlay">
5050
<i class=" fa-solid fa-spinner-third fa-spin fa-fast-spin"></i>
5151
<p >Removing action, this page will refresh shortly...</p>
5252
</div>
@@ -420,7 +420,7 @@
420420

421421
// show action delete overlay, takes several seconds to process
422422
$('.dropdown-item.delete').on("click", function(e) {
423-
$(this).closest('.action-card').find('.deleting-overlay').removeClass('d-none'); // show overlay only for this card
423+
$(this).closest('.action-card').find('.deleting-overlay').addClass('d-flex'); // show overlay only for this card, needs flex
424424
});
425425

426426
// show loading on action plan period navigation

0 commit comments

Comments
 (0)