initial commit for replacing Materialized reporting_patient_states wi… (#5703)

Replacing Materialized public.reporting_patient_states with a normal
view

**Story card:**
[sc-16562](https://app.shortcut.com/simpledotorg/story/16562/replace-old-mat-view-to-the-new-partitioned-table-reporting-patient-states)

## Because

We want to discard materialized reporting_patient_states

## This addresses

We create a normal view reporting_patient_states under public schema.
This will ensure that the existing dashboard and metabase reports don't
break.
In order to drop mat view reporting_patient_states, we need to first
drop the views which is dependent on reporting_patient_states, and
recreate them without data.
We will have to refresh those mat views after this is deployed.

## Test instructions
Clear the cache and restart the server. The dashboards should load fine.
Suite tests.

---------

Co-authored-by: Ayushi Agrawal <[email protected]>

Author: aagrawalrtsl

app/models/reports/patient_state.rb

@@ -10,7 +10,7 @@ class PatientState < Reports::View
     }, _prefix: :htn_care_state
 
     def self.materialized?
-      true
+      false
     end
 
     def self.partitioned?

app/services/refresh_reporting_views.rb

@@ -125,7 +125,7 @@ def benchmark_and_statsd(operation, partitioned_refresh = false)
     name = "reporting_views_refresh_duration_seconds"
     result = nil
     options_hash = {view: view}
-    options_hash[:partitioned_refresh] = true if partitioned_refresh
+    options_hash[:partitioned_refresh] = partitioned_refresh ? true : false
     Metrics.benchmark_and_gauge(name, options_hash) do
       result = yield
     end

db/migrate/20250925094123_discard_mat_view_reporting_patient_states.rb

@@ -3594,143 +3594,13 @@ CREATE MATERIALIZED VIEW public.reporting_prescriptions AS
 -- Name: reporting_patient_states; Type: MATERIALIZED VIEW; Schema: public; Owner: -
 --
 
-CREATE MATERIALIZED VIEW public.reporting_patient_states AS
- SELECT DISTINCT ON (p.id, cal.month_date) p.id AS patient_id,
-    timezone('UTC'::text, timezone('UTC'::text, p.recorded_at)) AS recorded_at,
-    p.status,
-    p.gender,
-    p.age,
-    timezone('UTC'::text, timezone('UTC'::text, p.age_updated_at)) AS age_updated_at,
-    p.date_of_birth,
-    date_part('year'::text, COALESCE(age((p.date_of_birth)::timestamp with time zone), (make_interval(years => p.age) + age(p.age_updated_at)))) AS current_age,
-    cal.month_date,
-    cal.month,
-    cal.quarter,
-    cal.year,
-    cal.month_string,
-    cal.quarter_string,
-    mh.hypertension,
-    mh.prior_heart_attack,
-    mh.prior_stroke,
-    mh.chronic_kidney_disease,
-    mh.receiving_treatment_for_hypertension,
-    mh.diabetes,
-    p.assigned_facility_id,
-    assigned_facility.facility_size AS assigned_facility_size,
-    assigned_facility.facility_type AS assigned_facility_type,
-    assigned_facility.facility_region_slug AS assigned_facility_slug,
-    assigned_facility.facility_region_id AS assigned_facility_region_id,
-    assigned_facility.block_slug AS assigned_block_slug,
-    assigned_facility.block_region_id AS assigned_block_region_id,
-    assigned_facility.district_slug AS assigned_district_slug,
-    assigned_facility.district_region_id AS assigned_district_region_id,
-    assigned_facility.state_slug AS assigned_state_slug,
-    assigned_facility.state_region_id AS assigned_state_region_id,
-    assigned_facility.organization_slug AS assigned_organization_slug,
-    assigned_facility.organization_region_id AS assigned_organization_region_id,
-    p.registration_facility_id,
-    registration_facility.facility_size AS registration_facility_size,
-    registration_facility.facility_type AS registration_facility_type,
-    registration_facility.facility_region_slug AS registration_facility_slug,
-    registration_facility.facility_region_id AS registration_facility_region_id,
-    registration_facility.block_slug AS registration_block_slug,
-    registration_facility.block_region_id AS registration_block_region_id,
-    registration_facility.district_slug AS registration_district_slug,
-    registration_facility.district_region_id AS registration_district_region_id,
-    registration_facility.state_slug AS registration_state_slug,
-    registration_facility.state_region_id AS registration_state_region_id,
-    registration_facility.organization_slug AS registration_organization_slug,
-    registration_facility.organization_region_id AS registration_organization_region_id,
-    bps.blood_pressure_id,
-    bps.blood_pressure_facility_id AS bp_facility_id,
-    bps.blood_pressure_recorded_at AS bp_recorded_at,
-    bps.systolic,
-    bps.diastolic,
-    bss.blood_sugar_id,
-    bss.blood_sugar_facility_id AS bs_facility_id,
-    bss.blood_sugar_recorded_at AS bs_recorded_at,
-    bss.blood_sugar_type,
-    bss.blood_sugar_value,
-    bss.blood_sugar_risk_state,
-    visits.encounter_id,
-    visits.encounter_recorded_at,
-    visits.prescription_drug_id,
-    visits.prescription_drug_recorded_at,
-    visits.appointment_id,
-    visits.appointment_recorded_at,
-    visits.visited_facility_ids,
-    (((cal.year - date_part('year'::text, timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at)))) * (12)::double precision) + (cal.month - date_part('month'::text, timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at))))) AS months_since_registration,
-    (((cal.year - date_part('year'::text, timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at)))) * (4)::double precision) + (cal.quarter - date_part('quarter'::text, timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at))))) AS quarters_since_registration,
-    visits.months_since_visit,
-    visits.quarters_since_visit,
-    bps.months_since_bp,
-    bps.quarters_since_bp,
-    bss.months_since_bs,
-    bss.quarters_since_bs,
-        CASE
-            WHEN ((bps.systolic IS NULL) OR (bps.diastolic IS NULL)) THEN 'unknown'::text
-            WHEN ((bps.systolic < 140) AND (bps.diastolic < 90)) THEN 'controlled'::text
-            ELSE 'uncontrolled'::text
-        END AS last_bp_state,
-        CASE
-            WHEN ((p.status)::text = 'dead'::text) THEN 'dead'::text
-            WHEN (((((cal.year - date_part('year'::text, timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at)))) * (12)::double precision) + (cal.month - date_part('month'::text, timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at))))) < (12)::double precision) OR (visits.months_since_visit < (12)::double precision)) THEN 'under_care'::text
-            ELSE 'lost_to_follow_up'::text
-        END AS htn_care_state,
-        CASE
-            WHEN ((visits.months_since_visit >= (3)::double precision) OR (visits.months_since_visit IS NULL)) THEN 'missed_visit'::text
-            WHEN ((bps.months_since_bp >= (3)::double precision) OR (bps.months_since_bp IS NULL)) THEN 'visited_no_bp'::text
-            WHEN ((bps.systolic < 140) AND (bps.diastolic < 90)) THEN 'controlled'::text
-            ELSE 'uncontrolled'::text
-        END AS htn_treatment_outcome_in_last_3_months,
-        CASE
-            WHEN ((visits.months_since_visit >= (2)::double precision) OR (visits.months_since_visit IS NULL)) THEN 'missed_visit'::text
-            WHEN ((bps.months_since_bp >= (2)::double precision) OR (bps.months_since_bp IS NULL)) THEN 'visited_no_bp'::text
-            WHEN ((bps.systolic < 140) AND (bps.diastolic < 90)) THEN 'controlled'::text
-            ELSE 'uncontrolled'::text
-        END AS htn_treatment_outcome_in_last_2_months,
-        CASE
-            WHEN ((visits.quarters_since_visit >= (1)::double precision) OR (visits.quarters_since_visit IS NULL)) THEN 'missed_visit'::text
-            WHEN ((bps.quarters_since_bp >= (1)::double precision) OR (bps.quarters_since_bp IS NULL)) THEN 'visited_no_bp'::text
-            WHEN ((bps.systolic < 140) AND (bps.diastolic < 90)) THEN 'controlled'::text
-            ELSE 'uncontrolled'::text
-        END AS htn_treatment_outcome_in_quarter,
-        CASE
-            WHEN ((visits.months_since_visit >= (3)::double precision) OR (visits.months_since_visit IS NULL)) THEN 'missed_visit'::text
-            WHEN ((bss.months_since_bs >= (3)::double precision) OR (bss.months_since_bs IS NULL)) THEN 'visited_no_bs'::text
-            ELSE bss.blood_sugar_risk_state
-        END AS diabetes_treatment_outcome_in_last_3_months,
-        CASE
-            WHEN ((visits.months_since_visit >= (2)::double precision) OR (visits.months_since_visit IS NULL)) THEN 'missed_visit'::text
-            WHEN ((bss.months_since_bs >= (2)::double precision) OR (bss.months_since_bs IS NULL)) THEN 'visited_no_bs'::text
-            ELSE bss.blood_sugar_risk_state
-        END AS diabetes_treatment_outcome_in_last_2_months,
-        CASE
-            WHEN ((visits.quarters_since_visit >= (1)::double precision) OR (visits.quarters_since_visit IS NULL)) THEN 'missed_visit'::text
-            WHEN ((bss.quarters_since_bs >= (1)::double precision) OR (bss.quarters_since_bs IS NULL)) THEN 'visited_no_bs'::text
-            ELSE bss.blood_sugar_risk_state
-        END AS diabetes_treatment_outcome_in_quarter,
-    ((current_meds.amlodipine > past_meds.amlodipine) OR (current_meds.telmisartan > past_meds.telmisartan) OR (current_meds.losartan > past_meds.losartan) OR (current_meds.atenolol > past_meds.atenolol) OR (current_meds.enalapril > past_meds.enalapril) OR (current_meds.chlorthalidone > past_meds.chlorthalidone) OR (current_meds.hydrochlorothiazide > past_meds.hydrochlorothiazide)) AS titrated
-   FROM (((((((((public.patients p
-     LEFT JOIN public.reporting_months cal ON ((to_char(timezone(( SELECT current_setting('TIMEZONE'::text) AS current_setting), timezone('UTC'::text, p.recorded_at)), 'YYYY-MM'::text) <= to_char((cal.month_date)::timestamp with time zone, 'YYYY-MM'::text))))
-     LEFT JOIN public.reporting_patient_blood_pressures bps ON (((p.id = bps.patient_id) AND (cal.month = bps.month) AND (cal.year = bps.year))))
-     LEFT JOIN public.reporting_patient_blood_sugars bss ON (((p.id = bss.patient_id) AND (cal.month = bss.month) AND (cal.year = bss.year))))
-     LEFT JOIN public.reporting_patient_visits visits ON (((p.id = visits.patient_id) AND (cal.month = visits.month) AND (cal.year = visits.year))))
-     LEFT JOIN public.medical_histories mh ON (((p.id = mh.patient_id) AND (mh.deleted_at IS NULL))))
-     LEFT JOIN public.reporting_prescriptions current_meds ON (((current_meds.patient_id = p.id) AND (cal.month_date = current_meds.month_date))))
-     LEFT JOIN public.reporting_prescriptions past_meds ON (((past_meds.patient_id = p.id) AND (cal.month_date = (past_meds.month_date + '1 mon'::interval)))))
-     JOIN public.reporting_facilities registration_facility ON ((registration_facility.facility_id = p.registration_facility_id)))
-     JOIN public.reporting_facilities assigned_facility ON ((assigned_facility.facility_id = p.assigned_facility_id)))
-  WHERE (p.deleted_at IS NULL)
-  ORDER BY p.id, cal.month_date
-  WITH NO DATA;
-
+CREATE VIEW public.reporting_patient_states AS SELECT * FROM simple_reporting.reporting_patient_states;
 
 --
--- Name: MATERIALIZED VIEW reporting_patient_states; Type: COMMENT; Schema: public; Owner: -
+-- Name: VIEW reporting_patient_states; Type: COMMENT; Schema: public; Owner: -
 --
 
-COMMENT ON MATERIALIZED VIEW public.reporting_patient_states IS 'Monthly summary of a patient''s information and health indicators. This table has one row per patient, per month, from the month of the patient''s registration.';
+COMMENT ON VIEW public.reporting_patient_states IS 'Monthly summary of a patient''s information and health indicators. This table has one row per patient, per month, from the month of the patient''s registration.';
 
 
 --
@@ -7843,28 +7713,6 @@ CREATE UNIQUE INDEX index_reporting_facility_appointment_scheduled_days ON publi
 
 CREATE INDEX index_reporting_patient_follow_ups_on_facility_id ON public.reporting_patient_follow_ups USING btree (facility_id);
 
-
---
--- Name: index_reporting_patient_states_on_age; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX index_reporting_patient_states_on_age ON public.reporting_patient_states USING btree (age);
-
-
---
--- Name: index_reporting_patient_states_on_gender; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX index_reporting_patient_states_on_gender ON public.reporting_patient_states USING btree (gender);
-
-
---
--- Name: index_reporting_patient_states_on_gender_and_age; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX index_reporting_patient_states_on_gender_and_age ON public.reporting_patient_states USING btree (gender, age);
-
-
 --
 -- Name: index_teleconsultations_on_facility_id; Type: INDEX; Schema: public; Owner: -
 --
@@ -8032,77 +7880,6 @@ CREATE UNIQUE INDEX patient_blood_pressures_patient_id_month_date ON public.repo
 
 CREATE UNIQUE INDEX patient_blood_sugars_month_date_patient_id ON public.reporting_patient_blood_sugars USING btree (month_date, patient_id);
 
-
---
--- Name: patient_states_assigned_block; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_assigned_block ON public.reporting_patient_states USING btree (assigned_block_region_id);
-
-
---
--- Name: patient_states_assigned_district; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_assigned_district ON public.reporting_patient_states USING btree (assigned_district_region_id);
-
-
---
--- Name: patient_states_assigned_facility; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_assigned_facility ON public.reporting_patient_states USING btree (assigned_facility_region_id);
-
-
---
--- Name: patient_states_assigned_state; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_assigned_state ON public.reporting_patient_states USING btree (assigned_state_region_id);
-
-
---
--- Name: patient_states_care_state; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_care_state ON public.reporting_patient_states USING btree (hypertension, htn_care_state, htn_treatment_outcome_in_last_3_months);
-
-
---
--- Name: patient_states_month_date_assigned_facility; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_month_date_assigned_facility ON public.reporting_patient_states USING btree (month_date, assigned_facility_id);
-
-
---
--- Name: patient_states_month_date_assigned_facility_region; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_month_date_assigned_facility_region ON public.reporting_patient_states USING btree (month_date, assigned_facility_region_id);
-
-
---
--- Name: patient_states_month_date_patient_id; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE UNIQUE INDEX patient_states_month_date_patient_id ON public.reporting_patient_states USING btree (month_date, patient_id);
-
-
---
--- Name: patient_states_month_date_registration_facility; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_month_date_registration_facility ON public.reporting_patient_states USING btree (month_date, registration_facility_id);
-
-
---
--- Name: patient_states_month_date_registration_facility_region; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX patient_states_month_date_registration_facility_region ON public.reporting_patient_states USING btree (month_date, registration_facility_region_id);
-
-
 --
 -- Name: patient_visits_patient_id_month_date; Type: INDEX; Schema: public; Owner: -
 --
@@ -8123,21 +7900,6 @@ CREATE UNIQUE INDEX raw_to_clean_medicines_unique_name_and_dosage ON public.raw_
 
 CREATE UNIQUE INDEX reporting_patient_follow_ups_unique_index ON public.reporting_patient_follow_ups USING btree (patient_id, user_id, facility_id, month_date);
 
-
---
--- Name: reporting_patient_states_bp_facility_id; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX reporting_patient_states_bp_facility_id ON public.reporting_patient_states USING btree (bp_facility_id);
-
-
---
--- Name: reporting_patient_states_titrated; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE INDEX reporting_patient_states_titrated ON public.reporting_patient_states USING btree (titrated);
-
-
 --
 -- Name: reporting_prescriptions_patient_month_date; Type: INDEX; Schema: public; Owner: -
 --
@@ -8794,5 +8556,6 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20250828111954'),
 ('20250923223358'),
 ('20250924101441'),
-('20250924102156');
+('20250924102156'),
+('20250925094123');
 

db/structure.sql

@@ -34,6 +34,7 @@
         controlled.each { |patient| create(:bp_with_encounter, :under_control, patient: patient, facility: facility, user: supervisor) }
       end
       Timecop.freeze("January 15th 2021") do
+        allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(Date.new(2020, 11, 1), Date.today))
         refresh_views
         get :bp_controlled, params: {}
       end
@@ -85,6 +86,7 @@
       end
 
       Timecop.freeze("January 15th 2021") do
+        allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(Date.new(2020, 11, 1), Date.today))
         refresh_views
         get :bp_not_controlled, params: {}
       end
@@ -151,6 +153,7 @@
         patients.each { |p| create(:bp_with_encounter, :under_control, facility: facility, patient: p) }
       end
       Timecop.freeze("January 15th 2021") do
+        allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(Date.new(2020, 7, 1), Date.today))
         refresh_views
         get :csv_maker, params: {type: "controlled_patients"}
       end

spec/controllers/my_facilities_controller_spec.rb

@@ -252,6 +252,7 @@
       patient = create(:patient, registration_facility: @facility, recorded_at: jan_2020.advance(months: -4))
       create(:bp_with_encounter, :under_control, recorded_at: jan_2020.advance(months: -1), patient: patient, facility: @facility)
       create(:bp_with_encounter, :hypertensive, recorded_at: jan_2020, facility: @facility)
+      allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(jan_2020.advance(months: -4).to_date, Date.new(2020, 6, 1)))
       refresh_views
 
       Timecop.freeze("June 1 2020") do
@@ -269,6 +270,7 @@
       patient = create(:patient, registration_facility: @facility, recorded_at: jan_2020.advance(months: -4))
       create(:bp_with_encounter, :under_control, recorded_at: jan_2020.advance(months: -1), patient: patient, facility: @facility)
       create(:bp_with_encounter, :hypertensive, recorded_at: jan_2020, facility: @facility)
+      allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(jan_2020.advance(months: -4).to_date, Date.new(2020, 6, 1)))
       refresh_views
 
       Timecop.freeze("June 1 2020") do
@@ -288,7 +290,7 @@
       patient_1 = create(:patient, registration_facility: @facility, recorded_at: "September 01 2019 00:00:00 UTC", registration_user: cvho)
       create(:bp_with_encounter, :under_control, recorded_at: "December 10th 2019", patient: patient_1, facility: @facility, user: cvho)
       create(:bp_with_encounter, :hypertensive, recorded_at: jan_2020, facility: @facility, user: cvho)
-
+      allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(Date.new(2019, 6, 1), Date.new(2020, 6, 1)))
       refresh_views
 
       block = @facility.region.block_region
@@ -492,6 +494,7 @@
       patient = create(:patient, registration_facility: @facility, registration_user: cvho, recorded_at: jan_2020.advance(months: -1))
       create(:bp_with_encounter, :under_control, recorded_at: jan_2020.advance(months: -1), patient: patient, facility: @facility)
       create(:bp_with_encounter, :hypertensive, recorded_at: jan_2020, facility: @facility)
+      allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(jan_2020.advance(months: -1).to_date, Date.new(2020, 6, 1)))
       refresh_views
 
       Timecop.freeze("June 1 2020") do
@@ -507,6 +510,7 @@
     it "can retrieve quarterly cohort data" do
       patient = create(:patient, registration_facility: @facility, registration_user: cvho, recorded_at: jan_2020.advance(months: -2))
       create(:bp_with_encounter, :under_control, recorded_at: jan_2020 + 1.day, patient: patient, facility: @facility)
+      allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(jan_2020.advance(months: -2).to_date, Date.new(2020, 6, 1)))
       refresh_views
 
       Timecop.freeze("June 1 2020") do

spec/controllers/reports/regions_controller_spec.rb

@@ -36,7 +36,7 @@
     create(:appointment, facility: @facility1, scheduled_date: Date.today, device_created_at: 63.days.ago, patient: create(:patient, :diabetes, recorded_at: 1.year.ago))
 
     @months = @period.downto(5).reverse.map(&:to_s)
-
+    allow(Reports::PatientState).to receive(:get_refresh_months).and_return(ReportingHelpers.get_refresh_months_between_dates(2.years.ago.to_date, Date.today))
     RefreshReportingViews.refresh_v2
   end