sc-17432 decouple Indicator from Target period; use ActionPlan.target… (#5742)

**Story card:**
[sc-17432](https://app.shortcut.com/simpledotorg/story/17432/fix-targets-association)

### **Because**
Indicators were using indicator.target.period, which caused
numerator/denominator to be calculated using the wrong quarter. The
ticket requires that ActionPlan’s target.period should be the source of
truth.

### **This addresses…**

1. Removed the Indicator → Target link (no more indicator.target).
2. Targets are now created independently and attached only to
ActionPlans.
3. ActionPlan#numerator now passes its own quarter:
`indicator.numerator(region, Period.new(type: :quarter, value:
target.period))
`
4. Updated controller, specs, and factories.
5. Made dr_rai_indicators_id nullable via migration.

### **Test Instructions**
Suite test

Author: Gyan-Gupta-Rtsl

app/controllers/dr_rai/action_plans_controller.rb

@@ -63,7 +63,6 @@ def hydrate_plan
     @target = DrRai::Target.create!(
       type: dr_rai_action_plan_params[:target_type],
       period: period,
-      indicator: @indicator,
       numeric_value: dr_rai_action_plan_params[:target_value]
     )
   end

app/models/dr_rai/action_plan.rb

@@ -16,7 +16,8 @@ def target
   end
 
   def numerator
-    indicator.numerator(region)
+    target_period = Period.new(type: :quarter, value: target.period)
+    indicator.numerator(region, target_period)
   end
 
   def denominator

app/models/dr_rai/indicator.rb

@@ -17,18 +17,11 @@ class DrRai::Indicator < ApplicationRecord
   # There should only ever be one instance of any indicator in the db
   validates :type, uniqueness: true
 
-  has_one :target, class_name: "DrRai::Target", dependent: :destroy, foreign_key: "dr_rai_indicators_id"
-  accepts_nested_attributes_for :target
-
   def quarterlies(region)
     data = Reports::RegionSummary.call(region, range: DEFAULT_RANGE)
     Reports::RegionSummaryAggregator.new(data).quarterly(with: :sum)[region.slug]
   end
 
-  def period
-    Period.new(type: :quarter, value: target.period)
-  end
-
   def has_action_plans?(region, period)
     raise "Must use a quarter period" unless period.type == :quarter
     raise "Must use a Region type" unless region.is_a? Region
@@ -51,26 +44,30 @@ def target_type
     DrRai::Target::TYPES[target_type_frontend]
   end
 
-  def numerator(region, the_period = period, with_non_contactable: nil)
+  def numerator(region, the_period, with_non_contactable: nil)
     return 0 unless is_supported?(region)
     numerators(region, all: with_non_contactable)[the_period]
   end
 
-  def denominator(region, the_period = period, with_non_contactable: nil)
+  def denominator(region, the_period, with_non_contactable: nil)
     return 0 unless is_supported?(region)
     denominators(region, all: with_non_contactable)[the_period]
   end
 
   def numerators(region, all: nil)
-    return [] unless is_supported?(region)
-    datasource(region).map do |t, data|
+    return {} unless is_supported?(region)
+    data_source = datasource(region)
+    return {} if data_source.nil?
+    data_source.map do |t, data|
       [t, data[numerator_key(all: all)]]
     end.to_h
   end
 
   def denominators(region, all: nil)
-    return [] unless is_supported?(region)
-    datasource(region).map do |t, data|
+    return {} unless is_supported?(region)
+    data_source = datasource(region)
+    return {} if data_source.nil?
+    data_source.map do |t, data|
       [t, data[denominator_key(all: all)]]
     end.to_h
   end

app/models/dr_rai/target.rb

@@ -5,7 +5,5 @@ class DrRai::Target < ApplicationRecord
     "boolean" => "DrRai::BooleanTarget"
   }
 
-  belongs_to :indicator, class_name: "DrRai::Indicator", foreign_key: "dr_rai_indicators_id"
-
   validates :period, presence: true, format: {with: /\AQ\d-\d{4}\Z/}
 end

db/migrate/20251211073126_make_dr_rai_indicators_id_nullable_in_dr_rai_targets.rb

@@ -0,0 +1,5 @@
+class MakeDrRaiIndicatorsIdNullableInDrRaiTargets < ActiveRecord::Migration[6.1]
+  def change
+    change_column_null :dr_rai_targets, :dr_rai_indicators_id, true
+  end
+end

db/structure.sql

@@ -1254,7 +1254,7 @@ CREATE TABLE public.dr_rai_targets (
     deleted_at timestamp without time zone,
     created_at timestamp(6) without time zone NOT NULL,
     updated_at timestamp(6) without time zone NOT NULL,
-    dr_rai_indicators_id bigint NOT NULL,
+    dr_rai_indicators_id bigint,
     period character varying
 );
 
@@ -8596,6 +8596,6 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20250924101441'),
 ('20250924102156'),
 ('20250925094123'),
-('20251125090819');
-
+('20251125090819'),
+('20251211073126');
 

spec/factories/dr_rai.rb

@@ -2,7 +2,6 @@
   factory :target, class: "DrRai::Target" do
     completed { false }
     period { "Q1-2021" }
-    indicator { contact_overdue_patients_indicator }
 
     trait :numeric do
       type { "DrRai::NumericTarget" }

spec/models/dr_rai/action_plan_spec.rb

@@ -4,7 +4,7 @@
   describe "#denominator" do
     context "for numeric targets" do
       let(:indicator) { DrRai::ContactOverduePatientsIndicator.create }
-      let(:target) { DrRai::NumericTarget.create(indicator: indicator, numeric_value: 20) }
+      let(:target) { DrRai::NumericTarget.create(numeric_value: 20, period: "Q1-2025") }
       let(:district_with_facilities) { setup_district_with_facilities }
       let(:region) { district_with_facilities[:region] }
 
@@ -20,12 +20,12 @@
 
   describe "#progress" do
     let(:indicator) { DrRai::ContactOverduePatientsIndicator.create }
-    let(:target) { DrRai::NumericTarget.create(indicator: indicator, numeric_value: 20, period: "Q1-2025") }
+    let(:target) { DrRai::NumericTarget.create(numeric_value: 20, period: "Q1-2025") }
     let(:district_with_facilities) { setup_district_with_facilities }
     let(:region) { district_with_facilities[:region] }
 
     before do
-      allow_any_instance_of(DrRai::ContactOverduePatientsIndicator).to receive(:numerator).with(anything).and_return(9)
+      allow_any_instance_of(DrRai::ContactOverduePatientsIndicator).to receive(:numerator).with(anything, anything).and_return(9)
     end
 
     it "calculates pecentage to 2 decimal places" do

spec/models/dr_rai/indicator_spec.rb

@@ -26,7 +26,7 @@
         create(:action_plan,
           region: region,
           dr_rai_indicator: the_indicator,
-          dr_rai_target: create(:target, :percentage, indicator: the_indicator, period: this_period.value.to_s))
+          dr_rai_target: create(:target, :percentage, period: this_period.value.to_s))
       end
 
       context "in that period" do

spec/models/dr_rai/target_spec.rb

@@ -27,8 +27,7 @@
 
     it "Q1-2023 is a valid period format" do
       target = DrRai::Target.new period: "Q1-2025"
-      expect(target).not_to be_valid
-      expect(target.errors.include?(:period)).to be_falsey
+      expect(target).to be_valid
     end
   end
 end