fix(OpenSRP Exporter): Patient Export, Syntax, et al (#5536)

**Story card:**
[sc-14814](https://app.shortcut.com/simpledotorg/story/14814/opensrp-exports-export-a-specific-time-window)

## Because

Running the exporter failed for a few reasons

## This addresses

All the reason the exporter fails per commit

- YAML parses dates directly into datetime
- declare `time_window` in local functions
- change hash to active_record#relation + add exporters
- use `time_window` definition in helper function
- ensure config data fits the `meta` function call
- return original keys; code is dependent on them
- only add the patient encounter if recorded within `time_window`

## Test instructions

- build a new image
- run an export
- ensure all `lastUpdatedBy` for resource types which are not
`Condition` happen within the time window specified

Author: igbanam

app/services/one_off/opensrp/encounter_generator.rb

@@ -19,7 +19,7 @@ def generate
           service_provider = first_child_encounter.serviceProvider
           child_encounters.pluck(:child_encounter).append(
             FHIR::Encounter.new(
-              meta: meta(opensrp_ids),
+              meta: meta(opensrp_ids.symbolize_keys),
               status: "finished",
               id: parent_id,
               identifier: [

config/opensrp-export.sample.yml

@@ -4,13 +4,7 @@ time_boundaries:
 facilities:
   d1dbd3c6-26bb-48e7-aa89-bc8a0b2bf75b:
     name: Health Facility 1
-    opensrp_practitioner_id: 0c375fe8-b38f-484e-aa64-c02750ee183b
-    opensrp_organization_id: d3363aea-66ad-4370-809a-8e4436a4218f
-    opensrp_care_team_id: 1c8100b5-222b-4815-ba4d-3ebde537c6ce
-    opensrp_location_id: ABC01230123
-  b100eb1a-18b3-424f-a2bf-c2e6b1655b1b:
-    name: Health Facility 2
-    opensrp_practitioner_id: 34a9da76-e18c-4fd6-a696-dee7a8454fb4
-    opensrp_organization_id: 5466dfd9-b10b-4bd8-8692-5732340de7f1
-    opensrp_care_team_id: f91c89c9-6790-4a94-b877-5feb578e0af8
-    opensrp_location_id: DEF01230123
+    practitioner_id: 0c375fe8-b38f-484e-aa64-c02750ee183b
+    organization_id: d3363aea-66ad-4370-809a-8e4436a4218f
+    care_team_id: 1c8100b5-222b-4815-ba4d-3ebde537c6ce
+    location_id: ABC01230123

lib/tasks/opensrp.rake

@@ -25,8 +25,9 @@ namespace :opensrp do
     facilities_to_export = config["facilities"]
     time_boundaries = config["time_boundaries"]
     using_time_boundaries = using_time_boundaries? config
-    report_start = DateTime.parse(time_boundaries["report_start"]) if has_report_start?(config)
-    report_end = DateTime.parse(time_boundaries["report_end"]) if has_report_end?(config)
+    report_start = time_boundaries["report_start"] if has_report_start?(config)
+    report_end = time_boundaries["report_end"] if has_report_end?(config)
+    time_window = report_start..report_end
 
     logger.info "Time Boundaries: [#{report_start}..#{report_end}]"
 
@@ -37,23 +38,27 @@ namespace :opensrp do
     logger.info "Preparing data for #{patients.size} patients"
     patients.each do |patient|
       logger.debug "Preparing data for Patient[##{patient.id}]"
-      patient_exporter = OneOff::Opensrp::PatientExporter.new(patient, facilities_to_export)
-      resources << patient_exporter.export
-      resources << patient_exporter.export_registration_questionnaire_response
-      encounters << patient_exporter.export_registration_encounter
+      if time_window.cover?(patient.recorded_at)
+        patient_exporter = OneOff::Opensrp::PatientExporter.new(patient, facilities_to_export)
+        resources << patient_exporter.export
+        resources << patient_exporter.export_registration_questionnaire_response
+        encounters << patient_exporter.export_registration_encounter
+      end
 
       blood_pressures = patient.blood_pressures
-      blood_pressures = blood_pressures.where(recorded_at: time_window).or(updated_at: time_window) if using_time_boundaries
+      blood_pressures = blood_pressures.where(recorded_at: time_window).or(blood_pressures.where(updated_at: time_window)) if using_time_boundaries
       logger.debug "Patient[##{patient.id}] has #{blood_pressures.size} blood pressure readings."
       blood_pressures.each do |bp|
+        bp_exporter = OneOff::Opensrp::BloodPressureExporter.new(bp, facilities_to_export)
         resources << bp_exporter.export
         encounters << bp_exporter.export_encounter
       end
 
       blood_sugars = patient.blood_sugars
-      blood_sugars = blood_sugars.where(recorded_at: time_window).or(updated_at: time_window) if using_time_boundaries
+      blood_sugars = blood_sugars.where(recorded_at: time_window).or(blood_sugars.where(updated_at: time_window)) if using_time_boundaries
       logger.debug "Patient[##{patient.id}] has #{blood_sugars.size} blood sugar readings."
-      blood_sugars.each do |bp|
+      blood_sugars.each do |bs|
+        bs_exporter = OneOff::Opensrp::BloodSugarExporter.new(bs, facilities_to_export)
         if patient.medical_history.diabetes_no?
           resources << bs_exporter.export_no_diabetes_observation
         end
@@ -62,9 +67,10 @@ namespace :opensrp do
       end
 
       prescription_drugs = patient.prescription_drugs
-      prescription_drugs = prescription_drugs.where(created_at: time_window).or(updated_at: time_window) if using_time_boundaries
+      prescription_drugs = prescription_drugs.where(created_at: time_window).or(prescription_drugs.where(updated_at: time_window)) if using_time_boundaries
       logger.debug "Patient[##{patient.id}] has #{prescription_drugs.size} drugs prescribed."
-      prescription_drugs.each do |bp|
+      prescription_drugs.each do |drug|
+        drug_exporter = OneOff::Opensrp::PrescriptionDrugExporter.new(drug, facilities_to_export)
         resources << drug_exporter.export_dosage_flag
         encounters << drug_exporter.export_encounter
       end
@@ -75,9 +81,9 @@ namespace :opensrp do
       end
 
       appointments = patient.appointments
-      appointments = appointments.where(created_at: time_window).or(updated_at: time_window) if using_time_boundaries
+      appointments = appointments.where(created_at: time_window).or(appointments.where(updated_at: time_window)) if using_time_boundaries
       logger.debug "Patient[##{patient.id}] has #{appointments.size} appointments."
-      appointments.each do |bp|
+      appointments.each do |appointment|
         appointment_exporter = OneOff::Opensrp::AppointmentExporter.new(appointment, facilities_to_export)
         resources << appointment_exporter.export
         if appointment.call_results.present?
@@ -109,11 +115,11 @@ namespace :opensrp do
   end
 
   def has_report_start?(config)
-    using_time_boundaries?(config) && time_boundaries.has_key?("report_start")
+    using_time_boundaries?(config) && config["time_boundaries"].has_key?("report_start")
   end
 
   def has_report_end?(config)
-    using_time_boundaries?(config) && time_boundaries.has_key?("report_end")
+    using_time_boundaries?(config) && config["time_boundaries"].has_key?("report_end")
   end
 
   def create_audit_record(facilities, patient)