Skip to content

Commit 3819e04

Browse files
author
Richard Unger
committed
fix AS5600 compile errors
1 parent 8504629 commit 3819e04

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/encoders/as5600/AS5600.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11

2-
#include "AS5600.h"
2+
3+
#include "./AS5600.h"
34

45

56
AS5600::AS5600(uint8_t address) : _address(address) {};
@@ -29,7 +30,7 @@ uint16_t AS5600::angle() {
2930
if (!closeTransactions) {
3031
setAngleRegister();
3132
}
32-
_wire->requestFrom(_address, 2, closeTransactions);
33+
_wire->requestFrom(_address, (uint8_t)2, (uint8_t)closeTransactions);
3334
result = _wire->read()<<8;
3435
result |= _wire->read();
3536
return result;
@@ -92,27 +93,31 @@ uint8_t AS5600::readZMCO() {
9293
};
9394

9495
uint8_t AS5600::readI2CAddr() {
95-
return (readRegister(AS5600_REG_I2C_ADDR, 1)>>1);
96+
return (readRegister(AS5600_REG_I2CADDR, 1)>>1);
9697
};
9798

9899

99100
// set registers
100101
void AS5600::setConf(AS5600Conf value) {
102+
// TODO: read before write
101103
writeRegister(AS5600_REG_CONF, value.reg);
102104
};
103105

104106

105107
void AS5600::setMang(uint16_t value) {
108+
// TODO: read before write
106109
writeRegister(AS5600_REG_MANG, value);
107110
};
108111

109112

110113
void AS5600::setMPos(uint16_t value) {
114+
// TODO: read before write
111115
writeRegister(AS5600_REG_MPOS, value);
112116
};
113117

114118

115119
void AS5600::setZPos(uint16_t value) {
120+
// TODO: read before write
116121
writeRegister(AS5600_REG_ZPOS, value);
117122
};
118123

@@ -131,7 +136,6 @@ void AS5600::setI2CUpdt(uint8_t value) {
131136

132137
void AS5600::burnSettings(){
133138
writeRegister(AS5600_REG_BURN, 0x40, 1);
134-
delay(50);
135139
}
136140

137141

@@ -141,7 +145,7 @@ uint16_t AS5600::readRegister(uint8_t reg, uint8_t len){
141145
_wire->beginTransmission(_address);
142146
_wire->write(reg);
143147
_wire->endTransmission(false);
144-
_wire->requestFrom(_address, len, closeTransactions);
148+
_wire->requestFrom(_address, len, (uint8_t)closeTransactions);
145149
if (!closeTransactions) {
146150
setAngleRegister();
147151
}

src/encoders/as5600/MagneticSensorAS5600.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include "./MagneticSensorAS5600.h"
44
#include "common/foc_utils.h"
55

6-
MagneticSensorAS5600::MagneticSensorAS5600() : AS5600(_address) {};
6+
MagneticSensorAS5600::MagneticSensorAS5600(uint8_t _address) : AS5600(_address) {};
77
MagneticSensorAS5600::~MagneticSensorAS5600() {};
88

99
void MagneticSensorAS5600::init(TwoWire* wire) {

0 commit comments

Comments
 (0)