Ticket ## : Fix UTs

Author: habarthierry-hue

tests/CaseManagement.BPMN.Acceptance.Tests/FakeStartup.cs

@@ -36,7 +36,7 @@ public void ConfigureServices(IServiceCollection services)
             services.AddAuthorization(_ =>
             {
                 _.AddPolicy("Authenticated", p => p.RequireAuthenticatedUser());
-                _.AddPolicy(HumanTaskConstants.ScopeNames.CreateHumanTaskInstance, p => p.RequireAssertion(__ => true));
+                _.AddPolicy(HumanTaskConstants.ScopeNames.ManageHumanTaskInstance, p => p.RequireAssertion(__ => true));
             });
             services
                 .AddMvc(opts => opts.EnableEndpointRouting = false)

tests/CaseManagement.BPMN.Tests/ProcessJobServerBuilderFixture.cs

@@ -50,7 +50,7 @@ public async Task When_Execute_Sequence_Of_Empty_Tasks()
         [Fact]
         public async Task When_Execute_StartEvent_With_MessageEventDefinition()
         {
-            const string messageName = "alert";
+            const string messageName = "message";
             var processInstance = ProcessInstanceBuilder.New("processFile")
                 .AddMessage(messageName, "message", string.Empty)
                 .AddStartEvent("1", "evt", _ =>
@@ -70,9 +70,8 @@ public async Task When_Execute_StartEvent_With_MessageEventDefinition()
             await jobServer.RegisterProcessInstance(processInstance, CancellationToken.None);
             await jobServer.EnqueueProcessInstance(processInstance.AggregateId, true, CancellationToken.None);
             var casePlanInstance = await jobServer.Get(processInstance.AggregateId, CancellationToken.None);
-            await jobServer.EnqueueMessage(processInstance.AggregateId, "message", null, CancellationToken.None);
-            casePlanInstance = await jobServer.Get(processInstance.AggregateId, CancellationToken.None);
-            await jobServer.EnqueueMessage(processInstance.AggregateId, "message", null, CancellationToken.None);
+            await jobServer.EnqueueMessage(processInstance.AggregateId, messageName, null, CancellationToken.None);
+            await jobServer.EnqueueMessage(processInstance.AggregateId, messageName, null, CancellationToken.None);
             casePlanInstance = await jobServer.Get(processInstance.AggregateId, CancellationToken.None);
             var startEventInstance = casePlanInstance.ElementInstances.First(_ => _.FlowNodeId == "1");
             var emptyTaskInstance = casePlanInstance.ElementInstances.First(_ => _.FlowNodeId == "2");
@@ -298,7 +297,7 @@ public async Task When_Execute_UserTask()
                 .Setup(x => x.SendAsync(It.IsAny<HttpRequestMessage>(), It.IsAny<CancellationToken>()))
                 .ReturnsAsync(new HttpResponseMessage
                 {
-                    Content = new StringContent("{ 'id' : '{" + humanTaskInstanceId + "}' }")
+                    Content = new StringContent("{ 'id' : '" + humanTaskInstanceId + "', 'defId': 'defId' }")
                 });
             await jobServer.RegisterProcessInstance(processInstance, CancellationToken.None);
             await jobServer.EnqueueProcessInstance(processInstance.AggregateId, true, CancellationToken.None);
@@ -342,7 +341,7 @@ public async Task When_Execute_BoundaryEvent()
                 .Setup(x => x.SendAsync(It.IsAny<HttpRequestMessage>(), It.IsAny<CancellationToken>()))
                 .ReturnsAsync(new HttpResponseMessage
                 {
-                    Content = new StringContent("{ 'id' : '{" + humanTaskInstanceId + "}' }")
+                    Content = new StringContent("{ 'id' : '" + humanTaskInstanceId + "', 'defId': 'defId' }")
                 });
 
             await jobServer.RegisterProcessInstance(processInstance, CancellationToken.None);
@@ -359,8 +358,8 @@ public async Task When_Execute_BoundaryEvent()
             Assert.Equal(1, executionPath.Pointers.First(p => p.FlowNodeId == "1").Outgoing.Count());
             Assert.Equal(1, executionPath.Pointers.First(p => p.FlowNodeId == "2").Incoming.Count());
             Assert.Equal(1, executionPath.Pointers.First(p => p.FlowNodeId == "2").Outgoing.Count());
-            Assert.Equal(3, executionPath.Pointers.First(p => p.FlowNodeId == "3").Incoming.Count());
-            Assert.Equal(3, executionPath.Pointers.First(p => p.FlowNodeId == "4").Incoming.Count());
+            Assert.Equal(2, executionPath.Pointers.First(p => p.FlowNodeId == "3").Incoming.Count());
+            Assert.Equal(2, executionPath.Pointers.First(p => p.FlowNodeId == "4").Incoming.Count());
         }
 
         [Fact]
@@ -398,7 +397,7 @@ public async Task When_Execute_HumanTaskWithBoundaryEvent()
                 .Setup(x => x.SendAsync(It.IsAny<HttpRequestMessage>(), It.IsAny<CancellationToken>()))
                 .ReturnsAsync(new HttpResponseMessage
                 {
-                    Content = new StringContent("{ 'id' : '{" + humanTaskInstanceId + "}' }")
+                    Content = new StringContent("{ 'id' : '" + humanTaskInstanceId + "', 'defId': 'defId' }")
                 });
             await jobServer.RegisterProcessInstance(processInstance, CancellationToken.None);
             await jobServer.EnqueueProcessInstance(processInstance.AggregateId, true, CancellationToken.None);

tests/CaseManagement.CMMN.Acceptance.Tests/FakeStartup.cs

@@ -58,7 +58,7 @@ public void ConfigureServices(IServiceCollection services)
                 // Case worker task
                 policy.AddPolicy("get_caseworkertasks", p => p.RequireAuthenticatedUser());
                 policy.AddPolicy("Authenticated", p => p.RequireAuthenticatedUser());
-                policy.AddPolicy(HumanTaskConstants.ScopeNames.CreateHumanTaskInstance, p => p.RequireAssertion(__ => true));
+                policy.AddPolicy(HumanTaskConstants.ScopeNames.ManageHumanTaskInstance, p => p.RequireAssertion(__ => true));
             });
             var emptyTask = HumanTaskDefBuilder.New("emptyTask")
                 .SetTaskInitiatorUserIdentifiers(new List<string> { "thabart" })

tests/CaseManagement.HumanTasks.Acceptance.Tests/FakeStartup.cs

@@ -24,7 +24,7 @@ public void ConfigureServices(IServiceCollection services)
             services.AddAuthorization(policy =>
             {
                 policy.AddPolicy("Authenticated", p => p.RequireAuthenticatedUser());
-                policy.AddPolicy("create_humantaskinstance", p => p.RequireAuthenticatedUser());
+                policy.AddPolicy("manage_humantaskinstance", p => p.RequireAuthenticatedUser());
             });
             services
                 .AddMvc(opts => opts.EnableEndpointRouting = false)