Added more descriptive exception message when resolving a cross-wired dependency fails. Fixes #1

Author: dotnetjunkie

src/SimpleInjector.Integration.ServiceCollection/SimpleInjector.Integration.ServiceCollection.csproj

@@ -5,7 +5,7 @@
     </Description>
     <AssemblyTitle>Simple Injector IServiceCollection Integration</AssemblyTitle>
     <NeutralLanguage>en-US</NeutralLanguage>
-    <VersionPrefix>5.0.0</VersionPrefix>
+    <VersionPrefix>5.0.1</VersionPrefix>
     <PackageReleaseNotes>https://github.com/simpleinjector/SimpleInjector.Integration.AspNetCore/releases/tag/5.0.0</PackageReleaseNotes>
     <AssemblyVersion>5.0.0.0</AssemblyVersion>
     <Authors>Simple Injector Contributors</Authors>

src/SimpleInjector.Integration.ServiceCollection/SimpleInjectorServiceCollectionExtensions.cs

@@ -492,10 +492,9 @@ private static Registration CreateCrossWireRegistration(
             return registration;
         }
 
-        private static Func<object> BuildSingletonInstanceCreator(
-            Type serviceType, IServiceProvider rootProvider)
+        private static Func<object> BuildSingletonInstanceCreator(Type serviceType, IServiceProvider rootProvider)
         {
-            return () => rootProvider.GetRequiredService(serviceType);
+            return () => GetRequiredService(rootProvider, serviceType);
         }
 
         private static Func<object> BuildScopedInstanceCreator(
@@ -524,10 +523,28 @@ private static Func<object> BuildScopedInstanceCreator(
                         $"Error resolving the cross-wired {serviceType.ToFriendlyName()}. {ex.Message}", ex);
                 }
 
-                return current.GetRequiredService(serviceType);
+                return GetRequiredService(current, serviceType);
             };
         }
 
+        private static object GetRequiredService(IServiceProvider provider, Type serviceType)
+        {
+            try
+            {
+                return provider.GetRequiredService(serviceType);
+            }
+            catch (Exception ex)
+            {
+                throw new InvalidOperationException(
+                    $"Failed to resolve {serviceType.ToFriendlyName()}. {serviceType.ToFriendlyName()} is a " +
+                    $"cross-wired service, meaning that Simple Injector forwarded the request the framework's " +
+                    $"IServiceProvider in order to get an instance. The used {provider.GetType().FullName}, " +
+                    $"however, failed with the following message: \"{ex.Message}\". This error might indicate a " +
+                    $"misconfiguration of services in the framework's IServiceCollection.",
+                    ex);
+            }
+        }
+
         private static ServiceDescriptor? FindServiceDescriptor(IServiceCollection services, Type serviceType)
         {
             // In case there are multiple descriptors for a given type, .NET Core will use the last