Merge pull request #84 from simplelocalize/write-nested-issue

Write nested issue

Author: jpomykala

README.md

@@ -311,7 +311,7 @@ ignoreKeys:
   - 'ABOUT-US'
 
 # Properties used by 'pull' and 'publish' command    
-pullPath: ./src/hosting/ 
+pullPath: ./src/hosting/
 environment: 'production' # or 'latest' 
 
 ```
@@ -329,9 +329,10 @@ export http_proxy=http://someproxy.com:8080
 export http_proxy=http://user:[email protected]:8080
 ```
 
-## Documentation 
+## Documentation
 
-Visit [simplelocalize.io/docs/cli/get-started/](https://simplelocalize.io/docs/cli/get-started/) to get more information about SimpleLocalize CLI.
+Visit [simplelocalize.io/docs/cli/get-started/](https://simplelocalize.io/docs/cli/get-started/) to get more information
+about SimpleLocalize CLI.
 
 ## License
 

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.simplelocalize</groupId>
     <artifactId>simplelocalize-cli</artifactId>
-    <version>2.4.0</version>
+    <version>2.4.1</version>
     <packaging>jar</packaging>
     <name>simplelocalize-cli</name>
     <description>Official SimpleLocalize Command Line Interface</description>

src/main/java/io/simplelocalize/cli/SimplelocalizeCliCommand.java

@@ -248,7 +248,15 @@ public void download(
       {
         configuration.setCustomerId(customerId);
       }
-      configuration.setDownloadOptions(Objects.requireNonNullElseGet(downloadOptions, ArrayList::new));
+
+      List<String> nonNullConfigurationFileDownloadOptions = Objects.requireNonNullElse(configuration.getDownloadOptions(), List.of());
+      configuration.setDownloadOptions(nonNullConfigurationFileDownloadOptions);
+      boolean hasArgumentDownloadOptions = downloadOptions != null && !downloadOptions.isEmpty();
+      if(hasArgumentDownloadOptions)
+      {
+        configuration.setDownloadOptions(downloadOptions);
+      }
+
       ConfigurationValidator configurationValidator = new ConfigurationValidator();
       configurationValidator.validateDownloadConfiguration(configuration);
       SimpleLocalizeClient client = SimpleLocalizeClient.create(configuration.getBaseUrl(), configuration.getApiKey());

src/main/java/io/simplelocalize/cli/Version.java

@@ -3,7 +3,7 @@
 public class Version
 {
 
-  public static final String NUMBER = "2.4.0";
+  public static final String NUMBER = "2.4.1";
 
   private Version()
   {