Skip to content

Commit 7337584

Browse files
committed
Polishing
1 parent c36ddd5 commit 7337584

File tree

5 files changed

+46
-3
lines changed

5 files changed

+46
-3
lines changed

reflect-config.json

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
{ "name" : "startAutoTranslation", "parameterTypes" : ["java.lang.String", "java.util.List", "java.lang.String"] },
1919
{ "name" : "status", "parameterTypes" : ["java.lang.String", "java.lang.String"] },
2020
{ "name" : "sync", "parameterTypes" : ["java.lang.String", "java.lang.String", "java.lang.String", "java.util.List", "java.lang.String", "java.lang.String", "java.util.List", "java.lang.String", "java.lang.String", "java.lang.String", "java.lang.String"] },
21-
{ "name" : "upload", "parameterTypes" : ["java.lang.String", "java.lang.String", "java.lang.String", "java.lang.Boolean", "java.lang.Boolean", "java.lang.Boolean", "java.util.List", "java.lang.String", "java.lang.String", "java.lang.String"] }
21+
{ "name" : "upload", "parameterTypes" : ["java.lang.String", "java.lang.String", "java.lang.String", "java.lang.Boolean", "java.lang.Boolean", "java.lang.Boolean", "java.util.List", "java.lang.String", "java.lang.String", "java.lang.String"] },
22+
{ "name" : "purge", "parameterTypes" : ["java.lang.String", "java.lang.String", "java.lang.Boolean"] }
2223
]
2324
},
2425
{
@@ -77,6 +78,13 @@
7778
"allDeclaredMethods" : true,
7879
"allPublicMethods" : true
7980
},
81+
{
82+
"name" : "io.simplelocalize.cli.client.dto.proxy.ExceptionRequest",
83+
"allDeclaredConstructors" : true,
84+
"allPublicConstructors" : true,
85+
"allDeclaredMethods" : true,
86+
"allPublicMethods" : true
87+
},
8088
{
8189
"name" : "java.lang.Boolean",
8290
"allDeclaredConstructors" : true,

src/main/java/io/simplelocalize/cli/command/PublishHostingCommand.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.jayway.jsonpath.JsonPath;
55
import io.simplelocalize.cli.client.SimpleLocalizeClient;
66
import io.simplelocalize.cli.client.dto.proxy.Configuration;
7+
import io.simplelocalize.cli.util.EnvironmentUtils;
78
import org.slf4j.Logger;
89
import org.slf4j.LoggerFactory;
910

@@ -34,7 +35,7 @@ public void invoke() throws IOException, InterruptedException
3435
String projectToken = json.read("$.data.projectToken", String.class);
3536
log.info("Project token: {}", projectToken);
3637

37-
String environment = configuration.getEnvironment();
38+
String environment = EnvironmentUtils.convertDefaultEnvironmentKeyFromPreviousCliVersionsToV3IfNeeded(configuration.getEnvironment());
3839
log.info("Environment: {}", environment);
3940

4041
log.info("Publishing translations...");

src/main/java/io/simplelocalize/cli/command/PullHostingCommand.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import io.simplelocalize.cli.client.dto.proxy.Configuration;
77
import io.simplelocalize.cli.client.dto.proxy.HostingResource;
88
import io.simplelocalize.cli.io.JsonReader;
9+
import io.simplelocalize.cli.util.EnvironmentUtils;
910
import org.slf4j.Logger;
1011
import org.slf4j.LoggerFactory;
1112

@@ -42,7 +43,7 @@ public void invoke() throws IOException, InterruptedException
4243
String projectToken = json.read("$.data.projectToken", String.class);
4344
log.info("Project token: {}", projectToken);
4445

45-
String environment = configuration.getEnvironment();
46+
String environment = EnvironmentUtils.convertDefaultEnvironmentKeyFromPreviousCliVersionsToV3IfNeeded(configuration.getEnvironment());
4647
log.info("Environment: {}", environment);
4748

4849
String filterRegex = configuration.getFilterRegex();
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
package io.simplelocalize.cli.util;
2+
3+
import org.slf4j.Logger;
4+
5+
public class EnvironmentUtils
6+
{
7+
private static final Logger log = org.slf4j.LoggerFactory.getLogger(EnvironmentUtils.class);
8+
9+
private EnvironmentUtils()
10+
{
11+
}
12+
13+
public static String convertDefaultEnvironmentKeyFromPreviousCliVersionsToV3IfNeeded(String environment)
14+
{
15+
if ("latest".equals(environment))
16+
{
17+
log.warn("[warning] You passed 'latest' value as environment key, please use '_latest' instead.");
18+
environment = "_" + environment;
19+
}
20+
21+
if ("production".equals(environment))
22+
{
23+
log.warn("[warning] You passed 'production' value as environment key, please use '_production' instead.");
24+
environment = "_" + environment;
25+
}
26+
return environment;
27+
}
28+
}

src/main/java/io/simplelocalize/cli/util/StackTraceUtils.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ private StackTraceUtils()
1111

1212
public static String getStackTrace(Exception exception)
1313
{
14+
if (exception == null)
15+
{
16+
return "";
17+
}
18+
1419
final StringWriter sw = new StringWriter();
1520
final PrintWriter pw = new PrintWriter(sw, true);
1621
exception.printStackTrace(pw);

0 commit comments

Comments
 (0)