Polishing

Author: jpomykala

junit/mock-server/test.json

@@ -6,7 +6,7 @@
 public class ObjectMapperSingleton
 {
 
-  private static ObjectMapper INSTANCE = null;
+  private static ObjectMapper INSTANCE = null; //NOSONAR
 
   private ObjectMapperSingleton()
   {

src/main/java/io/simplelocalize/cli/client/ObjectMapperSingleton.java

@@ -182,12 +182,12 @@ private void throwOnError(HttpResponse<?> httpResponse)
 
   private String safeCastHttpBodyToString(Object responseBody)
   {
-    if (responseBody instanceof byte[])
+    if (responseBody instanceof byte[] responseBodyBytes)
     {
-      return new String((byte[]) responseBody);
-    } else if (responseBody instanceof String)
+      return new String(responseBodyBytes);
+    } else if (responseBody instanceof String responseBodyString)
     {
-      return (String) responseBody;
+      return responseBodyString;
     }
     return "";
   }

src/main/java/io/simplelocalize/cli/client/SimpleLocalizeClient.java

@@ -16,7 +16,7 @@ private DownloadRequestBuilder()
     {
     }
 
-    public static DownloadRequestBuilder Builder()
+    public static DownloadRequestBuilder builder()
     {
       return new DownloadRequestBuilder();
     }

src/main/java/io/simplelocalize/cli/client/dto/DownloadRequest.java

@@ -16,7 +16,7 @@ private FileToUploadBuilder()
     {
     }
 
-    public static FileToUploadBuilder Builder()
+    public static FileToUploadBuilder builder()
     {
       return new FileToUploadBuilder();
     }

src/main/java/io/simplelocalize/cli/client/dto/FileToUpload.java

@@ -26,7 +26,7 @@ private UploadFileRequestBuilder()
     {
     }
 
-    public static UploadFileRequestBuilder Builder()
+    public static UploadFileRequestBuilder builder()
     {
       return new UploadFileRequestBuilder();
     }

src/main/java/io/simplelocalize/cli/client/dto/UploadRequest.java

@@ -16,7 +16,7 @@ private DownloadableFileBuilder()
     {
     }
 
-    public static DownloadableFileBuilder Builder()
+    public static DownloadableFileBuilder builder()
     {
       return new DownloadableFileBuilder();
     }

src/main/java/io/simplelocalize/cli/client/dto/proxy/DownloadableFile.java

@@ -43,7 +43,7 @@ public void invoke() throws IOException, InterruptedException
       downloadOptions.add("SPLIT_BY_LANGUAGES");
     }
 
-    DownloadRequest downloadRequest = DownloadRequest.DownloadRequestBuilder.Builder()
+    DownloadRequest downloadRequest = DownloadRequest.DownloadRequestBuilder.builder()
             .withFormat(downloadFormat)
             .withOptions(downloadOptions)
             .withCustomerId(customerId)

src/main/java/io/simplelocalize/cli/command/DownloadCommand.java

@@ -32,7 +32,7 @@ public void invoke() throws IOException, InterruptedException
     Float translated = Objects.requireNonNullElse(translatedNullable, 0.0f);
     Float translatedPercentage = translated * 100;
     String translatedPercentageFormatted = String.format("%.0f", translatedPercentage);
-    log.info("Translated: {}", translatedPercentageFormatted + "%");
+    log.info("Translated: {}%", translatedPercentageFormatted);
     log.info("Languages: {}", json.read("$.data.languages[*].key").toString());
     log.info("Environments: {}", json.read("$.data.environments[*].key").toString());
     log.info("Namespaces: {}", json.read("$.data.namespaces[*].name").toString());

src/main/java/io/simplelocalize/cli/command/StatusCommand.java

@@ -15,7 +15,7 @@
 import java.util.List;
 import java.util.Optional;
 
-import static io.simplelocalize.cli.client.dto.UploadRequest.UploadFileRequestBuilder.Builder;
+import static io.simplelocalize.cli.client.dto.UploadRequest.UploadFileRequestBuilder.builder;
 
 public class UploadCommand implements CliCommand
 {
@@ -93,7 +93,7 @@ public void invoke() throws IOException, InterruptedException
       String uploadFormat = configuration.getUploadFormat();
       String customerId = configuration.getCustomerId();
       List<String> uploadOptions = configuration.getUploadOptions();
-      UploadRequest uploadRequest = Builder()
+      UploadRequest uploadRequest = builder()
               .withPath(fileToUpload.path())
               .withLanguageKey(requestLanguageKey)
               .withNamespace(fileToUpload.namespace())