Merge pull request #52 from simplelocalize/truncate-file-on-write

Truncate files before writing

Author: jpomykala

junit/truncate/file.json

@@ -0,0 +1 @@
+sample

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.simplelocalize</groupId>
     <artifactId>simplelocalize-cli</artifactId>
-    <version>2.0.1</version>
+    <version>2.0.2</version>
     <packaging>jar</packaging>
     <name>simplelocalize-cli</name>
     <description>Official SimpleLocalize Command Line Interface</description>

src/main/java/io/simplelocalize/cli/Version.java

@@ -3,7 +3,7 @@
 public class Version
 {
 
-  public static final String NUMBER = "2.0.1";
+  public static final String NUMBER = "2.0.2";
 
   private Version()
   {

src/main/java/io/simplelocalize/cli/client/SimpleLocalizeClient.java

@@ -18,6 +18,7 @@
 import java.net.http.HttpResponse;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.nio.file.StandardOpenOption;
 import java.time.Duration;
 import java.util.Collection;
 import java.util.List;
@@ -111,7 +112,7 @@ public void downloadFile(DownloadableFile downloadableFile, String downloadPathT
         Files.createDirectories(parentDirectory);
       }
       log.info(" 🌍 Downloading {}", savePath);
-      httpClient.send(httpRequest, HttpResponse.BodyHandlers.ofFile(savePath));
+      httpClient.send(httpRequest, HttpResponse.BodyHandlers.ofFile(savePath, StandardOpenOption.CREATE, StandardOpenOption.WRITE, StandardOpenOption.TRUNCATE_EXISTING));
     } catch (IOException e)
     {
       log.error(" 😝 Download failed: {}", savePath, e);

src/test/java/io/simplelocalize/cli/client/SimpleLocalizeClientTest.java

@@ -21,6 +21,7 @@
 
 import static io.simplelocalize.cli.client.dto.DownloadRequest.DownloadRequestBuilder.aDownloadRequest;
 import static io.simplelocalize.cli.client.dto.UploadRequest.UploadFileRequestBuilder.anUploadFileRequest;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockserver.integration.ClientAndServer.startClientAndServer;
 import static org.mockserver.model.HttpRequest.request;
 import static org.mockserver.model.HttpResponse.response;
@@ -251,12 +252,42 @@ void shouldDownloadS3File() throws Exception
     DownloadableFile downloadableFile = new DownloadableFile();
     downloadableFile.setUrl(MOCK_SERVER_BASE_URL + "/s3/file");
     downloadableFile.setNamespace("common");
-    String downloadPath = "file.json";
+    String downloadPath = "./junit/download-test/file.json";
 
     //when
     client.downloadFile(downloadableFile, downloadPath);
 
     //then
+    assertThat(Path.of(downloadPath)).isRegularFile();
+  }
+
+  @Test
+  void shouldDownloadAndTruncateBeforeWriting() throws Exception
+  {
+    //given
+    SimpleLocalizeClient client = new SimpleLocalizeClient(MOCK_SERVER_BASE_URL, "96a7b6ca75c79d4af4dfd5db2946fdd4");
+    mockServer.when(request()
+                            .withMethod("GET")
+                            .withPath("/s3/file"),
+                    Times.exactly(1))
+            .respond(
+                    response()
+                            .withStatusCode(200)
+                            .withContentType(MediaType.APPLICATION_JSON_UTF_8)
+                            .withBody("sample".getBytes(StandardCharsets.UTF_8))
+                            .withDelay(TimeUnit.MILLISECONDS, 200)
+            );
+
+    DownloadableFile downloadableFile = new DownloadableFile();
+    downloadableFile.setUrl(MOCK_SERVER_BASE_URL + "/s3/file");
+    downloadableFile.setNamespace("common");
+    String downloadPath = "./junit/truncate/file.json";
+
+    //when
+    client.downloadFile(downloadableFile, downloadPath);
+
+    //then
+    assertThat(Path.of(downloadPath)).hasContent("sample").isRegularFile();
   }
 
   @Test
@@ -280,6 +311,6 @@ void shouldValidateQuality() throws Exception
     int validateGate = client.validateGate();
 
     //then
-    Assertions.assertThat(validateGate).isEqualTo(200);
+    assertThat(validateGate).isEqualTo(200);
   }
 }