Start testing PHP 8.4

Author: tvdijen

.github/workflows/php.yml

@@ -52,7 +52,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           # Should be the higest supported version, so we can use the newest tools
-          php-version: '8.3'
+          php-version: '8.4'
           tools: composer, composer-require-checker, composer-unused, phpcs
           extensions: ctype, date, dom, filter, hash, mbstring, openssl, pcre, soap, spl, xml
           coverage: none
@@ -145,7 +145,7 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['8.1', '8.2', '8.3']
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
 
     steps:
       - name: Setup PHP, with composer and extensions
@@ -185,15 +185,15 @@ jobs:
         run: composer install --no-progress --prefer-dist --optimize-autoloader
 
       - name: Run unit tests with coverage
-        if: ${{ matrix.php-versions == '8.3' }}
+        if: ${{ matrix.php-versions == '8.4' }}
         run: vendor/bin/phpunit
 
       - name: Run unit tests (no coverage)
-        if: ${{ matrix.php-versions != '8.3' }}
+        if: ${{ matrix.php-versions != '8.4' }}
         run: vendor/bin/phpunit --no-coverage
 
       - name: Save coverage data
-        if: ${{ matrix.php-versions == '8.3' }}
+        if: ${{ matrix.php-versions == '8.4' }}
         uses: actions/upload-artifact@v4
         with:
           name: coverage-data
@@ -207,7 +207,7 @@ jobs:
       fail-fast: true
       matrix:
         operating-system: [windows-latest]
-        php-versions: ['8.1', '8.2', '8.3']
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
 
     steps:
       - name: Setup PHP, with composer and extensions

src/Binding.php

@@ -161,7 +161,7 @@ public function getDestination(): ?string
      *
      * @param string|null $relayState The RelayState.
      */
-    public function setRelayState(string $relayState = null): void
+    public function setRelayState(?string $relayState = null): void
     {
         $this->relayState = $relayState;
     }
@@ -185,7 +185,7 @@ public function getRelayState(): ?string
      *
      * @param string|null $destination The destination the message should be delivered to.
      */
-    public function setDestination(string $destination = null): void
+    public function setDestination(?string $destination = null): void
     {
         $this->destination = $destination;
     }

src/Certificate/KeyLoader.php

@@ -46,7 +46,7 @@ public function __construct()
      */
     public static function extractPublicKeys(
         CertificateProvider $config,
-        string $usage = null,
+        ?string $usage = null,
         bool $required = false,
     ): KeyCollection {
         $keyLoader = new self();
@@ -63,7 +63,7 @@ public static function extractPublicKeys(
      */
     public function loadKeysFromConfiguration(
         CertificateProvider $config,
-        string $usage = null,
+        ?string $usage = null,
         bool $required = false,
     ): KeyCollection {
         $keys = $config->getKeys();
@@ -96,7 +96,7 @@ public function loadKeysFromConfiguration(
      * @param array|\Traversable $configuredKeys
      * @param string|null $usage
      */
-    public function loadKeys($configuredKeys, string $usage = null): void
+    public function loadKeys($configuredKeys, ?string $usage = null): void
     {
         foreach ($configuredKeys as $keyData) {
             if (isset($keyData['X509Certificate'])) {

src/Certificate/PrivateKey.php

@@ -12,7 +12,7 @@ class PrivateKey extends Key
      * @throws \SimpleSAML\SAML2\Exception\InvalidArgumentException
      * @return \SimpleSAML\SAML2\Certificate\PrivateKey
      */
-    public static function create(string $keyContents, string $passphrase = null): PrivateKey
+    public static function create(string $keyContents, ?string $passphrase = null): PrivateKey
     {
         $keyData = ['PEM' => $keyContents, self::USAGE_ENCRYPTION => true];
         if ($passphrase) {

src/Compat/AbstractContainer.php

@@ -177,7 +177,7 @@ abstract public function getTempDir(): string;
      * @param string $data The data we should write to the file.
      * @param int|null $mode The permissions to apply to the file. Defaults to 0600.
      */
-    abstract public function writeFile(string $filename, string $data, int $mode = null): void;
+    abstract public function writeFile(string $filename, string $data, ?int $mode = null): void;
 
 
     /**

src/Compat/MockContainer.php

@@ -61,7 +61,7 @@ public function debugMessage($message, string $type): void
      * @return string
      */
     public function getPOSTRedirectURL(
-        /** @scrutinizer ignore-unused */string $url = null,
+        /** @scrutinizer ignore-unused */?string $url = null,
         /** @scrutinizer ignore-unused */array $data = [],
     ): string {
         return strval($url);
@@ -82,7 +82,7 @@ public function getTempDir(): string
      * @param string $data
      * @param int|null $mode
      */
-    public function writeFile(string $filename, string $data, int $mode = null): void
+    public function writeFile(string $filename, string $data, ?int $mode = null): void
     {
         if ($mode === null) {
             $mode = 0600;

src/Configuration/DecryptionProvider.php

@@ -24,7 +24,7 @@ public function getSharedKey(): ?string;
      *
      * @return mixed
      */
-    public function getPrivateKey(string $name, bool $required = null);
+    public function getPrivateKey(string $name, ?bool $required = null);
 
 
 

src/Configuration/IdentityProvider.php

@@ -74,7 +74,7 @@ public function getSharedKey(): ?string
      * @param bool $required
      * @return mixed|null
      */
-    public function getPrivateKey(string $name, bool $required = null)
+    public function getPrivateKey(string $name, ?bool $required = null)
     {
         if ($required === null) {
             $required = false;

src/Configuration/ServiceProvider.php

@@ -85,7 +85,7 @@ public function getSharedKey(): ?string
      * @param bool $required
      * @return mixed|null
      */
-    public function getPrivateKey(string $name, bool $required = null)
+    public function getPrivateKey(string $name, ?bool $required = null)
     {
         if ($required === null) {
             $required = false;

src/Exception/ProtocolViolationException.php

@@ -12,9 +12,9 @@
 class ProtocolViolationException extends RuntimeException
 {
     /**
-     * @param string $message
+     * @param string|null $message
      */
-    public function __construct(string $message = null)
+    public function __construct(?string $message = null)
     {
         if ($message === null) {
             if (defined('static::DEFAULT_MESSAGE')) {