Fix Psalm-issues

tvdijen · tvdijen · commit 2eea81f4b1f9 · 2024-06-03T17:38:59.000+02:00
diff --git a/src/Auth/Source/Negotiate.php b/src/Auth/Source/Negotiate.php
@@ -139,7 +139,7 @@ public function authenticate(array &$state): void
         }
 
         Logger::debug('Negotiate - authenticate(): looking for authentication header');
-        if (!empty($_SERVER['HTTP_AUTHORIZATION'])) {
+        if (array_key_exists('HTTP_AUTHORIZATION', $_SERVER) && !empty($_SERVER['HTTP_AUTHORIZATION'])) {
             Logger::debug('Negotiate - authenticate(): Authentication header found');
 
             Assert::true(is_string($this->spn) || (is_int($this->spn) && ($this->spn === 0)) || is_null($this->spn));

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function authenticate(array &$state): void`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`Logger::debug('Negotiate - authenticate(): looking for authentication header');`
`142`		`- if (!empty($_SERVER['HTTP_AUTHORIZATION'])) {`
	`142`	`+ if (array_key_exists('HTTP_AUTHORIZATION', $_SERVER) && !empty($_SERVER['HTTP_AUTHORIZATION'])) {`
`143`	`143`	`Logger::debug('Negotiate - authenticate(): Authentication header found');`
`144`	`144`
`145`	`145`	`Assert::true(is_string($this->spn) \|\| (is_int($this->spn) && ($this->spn === 0)) \|\| is_null($this->spn));`