WIP sig algs

Author: cicnavi

src/Services/OpMetadataService.php

@@ -39,13 +39,16 @@ public function __construct(
      */
     private function initMetadata(): void
     {
+        // Signature algorithms that this OP can use to sign JWS artifacts.
         $protocolSignatureAlgorithmNames = array_values(
             array_map(
                 fn(SignatureKeyPair $signatureKeyPair): string => $signatureKeyPair->getSignatureAlgorithm()->value,
                 $this->moduleConfig->getProtocolSignatureKeyPairBag()->getAll(),
             ),
         );
 
+        // Signature algorithms that this OP can use to validate signature on
+        // signed JWS artifacts.
         $supportedSignatureAlgorithmNames = array_values(
             array_map(
                 fn(SignatureAlgorithmEnum $signatureAlgorithm): string => $signatureAlgorithm->value,

tests/unit/src/Services/OpMetadataServiceTest.php

@@ -11,7 +11,12 @@
 use SimpleSAML\Module\oidc\ModuleConfig;
 use SimpleSAML\Module\oidc\Services\OpMetadataService;
 use SimpleSAML\Module\oidc\Utils\ClaimTranslatorExtractor;
+use SimpleSAML\OpenID\Algorithms\SignatureAlgorithmBag;
+use SimpleSAML\OpenID\Algorithms\SignatureAlgorithmEnum;
 use SimpleSAML\OpenID\Codebooks\ClaimsEnum;
+use SimpleSAML\OpenID\SupportedAlgorithms;
+use SimpleSAML\OpenID\ValueAbstracts\SignatureKeyPair;
+use SimpleSAML\OpenID\ValueAbstracts\SignatureKeyPairBag;
 
 /**
  * @covers \SimpleSAML\Module\oidc\Services\OpMetadataService
@@ -20,6 +25,10 @@ class OpMetadataServiceTest extends TestCase
 {
     protected MockObject $moduleConfigMock;
     protected MockObject $claimTranslatorExtractorMock;
+    protected MockObject $signatureAlgorithmBag;
+    protected MockObject $supportedAlgorithmsMock;
+    protected MockObject $signatureKeyPairBagMock;
+    protected MockObject $signatureKeyPairMock;
 
     /**
      * @throws \Exception
@@ -51,6 +60,28 @@ public function setUp(): void
         $this->moduleConfigMock->method('getProtocolSigner')->willReturn($signer);
 
         $this->claimTranslatorExtractorMock = $this->createMock(ClaimTranslatorExtractor::class);
+
+        $this->signatureAlgorithmBag = $this->createMock(SignatureAlgorithmBag::class);
+        $this->signatureAlgorithmBag->method('getAll')
+            ->willReturn([SignatureAlgorithmEnum::RS256]);
+
+        $this->supportedAlgorithmsMock = $this->createMock(SupportedAlgorithms::class);
+        $this->supportedAlgorithmsMock->method('getSignatureAlgorithmBag')
+            ->willReturn($this->signatureAlgorithmBag);
+
+        $this->moduleConfigMock->method('getSupportedAlgorithms')
+            ->willReturn($this->supportedAlgorithmsMock);
+
+        $this->signatureKeyPairMock = $this->createMock(SignatureKeyPair::class);
+        $this->signatureKeyPairMock->method('getSignatureAlgorithm')
+            ->willReturn(SignatureAlgorithmEnum::RS256);
+
+        $this->signatureKeyPairBagMock = $this->createMock(SignatureKeyPairBag::class);
+        $this->signatureKeyPairBagMock->method('getAll')
+            ->willReturn([$this->signatureKeyPairMock]);
+
+        $this->moduleConfigMock->method('getProtocolSignatureKeyPairBag')
+            ->willReturn($this->signatureKeyPairBagMock);
     }
 
     /**