Add missed tests from edit and new client controller

Author: sgomez

spec/Controller/ClientCreateControllerSpec.php

@@ -24,6 +24,7 @@
 use SimpleSAML\Modules\OpenIDConnect\Factories\TemplateFactory;
 use SimpleSAML\Modules\OpenIDConnect\Form\ClientForm;
 use SimpleSAML\Modules\OpenIDConnect\Repositories\ClientRepository;
+use SimpleSAML\Modules\OpenIDConnect\Services\ConfigurationService;
 use SimpleSAML\Modules\OpenIDConnect\Services\SessionMessagesService;
 use SimpleSAML\XHTML\Template;
 use Laminas\Diactoros\Response\RedirectResponse;
@@ -37,6 +38,7 @@ class ClientCreateControllerSpec extends ObjectBehavior
      * @return void
      */
     public function let(
+        ConfigurationService $configurationService,
         ClientRepository $clientRepository,
         TemplateFactory $templateFactory,
         FormFactory $formFactory,
@@ -47,10 +49,12 @@ public function let(
         $_SERVER['REQUEST_URI'] = '/';
         Configuration::loadFromArray([], '', 'simplesaml');
 
+        $configurationService->getOpenIdConnectModuleURL(Argument::any())->willReturn("url");
+
         $request->getUri()->willReturn($uri);
         $uri->getPath()->willReturn('/');
 
-        $this->beConstructedWith($clientRepository, $templateFactory, $formFactory, $sessionMessagesService);
+        $this->beConstructedWith($configurationService, $clientRepository, $templateFactory, $formFactory, $sessionMessagesService);
     }
 
     /**

spec/Controller/ClientEditControllerSpec.php

@@ -28,6 +28,7 @@
 use SimpleSAML\Modules\OpenIDConnect\Factories\TemplateFactory;
 use SimpleSAML\Modules\OpenIDConnect\Form\ClientForm;
 use SimpleSAML\Modules\OpenIDConnect\Repositories\ClientRepository;
+use SimpleSAML\Modules\OpenIDConnect\Services\ConfigurationService;
 use SimpleSAML\Modules\OpenIDConnect\Services\SessionMessagesService;
 use SimpleSAML\XHTML\Template;
 
@@ -37,6 +38,7 @@ class ClientEditControllerSpec extends ObjectBehavior
      * @return void
      */
     public function let(
+        ConfigurationService $configurationService,
         ClientRepository $clientRepository,
         TemplateFactory $templateFactory,
         FormFactory $formFactory,
@@ -47,10 +49,12 @@ public function let(
         $_SERVER['REQUEST_URI'] = '/';
         Configuration::loadFromArray([], '', 'simplesaml');
 
+        $configurationService->getOpenIdConnectModuleURL()->willReturn("url");
+
         $request->getUri()->willReturn($uri);
         $uri->getPath()->willReturn('/');
 
-        $this->beConstructedWith($clientRepository, $templateFactory, $formFactory, $sessionMessagesService);
+        $this->beConstructedWith($configurationService, $clientRepository, $templateFactory, $formFactory, $sessionMessagesService);
     }
 
     /**
@@ -83,6 +87,7 @@ public function it_shows_edit_client_form(
             'scopes' => ['openid'],
             'is_enabled' => true,
         ];
+        $clientEntity->getIdentifier()->shouldBeCalled()->willReturn('clientid');
 
         $request->getQueryParams()->shouldBeCalled()->willReturn(['client_id' => 'clientid']);
         $clientRepository->findById('clientid')->shouldBeCalled()->willReturn($clientEntity);