Fix phpstan-issues and baseline

Author: tvdijen

phpstan-baseline-dev.neon

@@ -0,0 +1,21 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Parameter \\#1 \\$array of function asort expects array, mixed given\\.$#"
+			count: 4
+			path: tests/src/Auth/Source/PasswordVerifyTest.php
+
+		-
+			message: "#^Property SimpleSAML\\\\Test\\\\Module\\\\sqlauth\\\\Auth\\\\Source\\\\PasswordVerifyTest\\:\\:\\$config \\(array\\<string, string\\|null\\>\\) does not accept array\\<string, array\\<int, string\\>\\|string\\|null\\>\\.$#"
+			count: 4
+			path: tests/src/Auth/Source/PasswordVerifyTest.php
+
+		-
+			message: "#^Parameter \\#1 \\$array of function asort expects array, mixed given\\.$#"
+			count: 4
+			path: tests/src/Auth/Source/SQLTest.php
+
+		-
+			message: "#^Property SimpleSAML\\\\Test\\\\Module\\\\sqlauth\\\\Auth\\\\Source\\\\SQLTest\\:\\:\\$config \\(array\\<string, string\\|null\\>\\) does not accept array\\<string, array\\<int, string\\>\\|string\\|null\\>\\.$#"
+			count: 4
+			path: tests/src/Auth/Source/SQLTest.php

phpstan-dev.neon

@@ -2,3 +2,5 @@ parameters:
   level: 9
   paths:
     - tests
+includes:
+  - phpstan-baseline-dev.neon

tests/src/Auth/Source/PasswordVerifyTest.php

@@ -14,8 +14,10 @@
  */
 class PasswordVerifyTest extends TestCase
 {
+    /** @var array<string, string> */
     private array $info = ['AuthId' => 'testAuthId'];
 
+    /** @var array<string, string|null> */
     private array $config = [
         "dsn" => 'sqlite:file::memory:?cache=shared',
         "username" => "notused",

tests/src/Auth/Source/PasswordVerifyWrapper.php

@@ -15,11 +15,19 @@
 
 class PasswordVerifyWrapper extends PasswordVerify
 {
+    /**
+     * @param array<mixed> $info
+     * @param array<mixed> $config
+     */
     public function __construct(array $info, array $config)
     {
         parent::__construct($info, $config);
     }
 
+
+    /**
+     * @return array<mixed>
+     */
     public function callLogin(string $username, string $password): array
     {
         return $this->login($username, $password);

tests/src/Auth/Source/SQLTest.php

@@ -15,7 +15,10 @@
  */
 class SQLTest extends TestCase
 {
+    /** @var array<string, string> */
     private array $info = ['AuthId' => 'testAuthId'];
+
+    /** @var array<string, string|null> */
     private array $config = [
         "dsn" => 'sqlite:file::memory:?cache=shared',
         "username" => "notused",
@@ -123,7 +126,7 @@ public function testBasicSingleUsernameRegexFailedLoginNonExistingUser(): void
         $this->assertCount(0, $ret);
     }
 
-    public function testBasicSingleFailedLogin()
+    public function testBasicSingleFailedLogin(): void
     {
         $this->expectException(\SimpleSAML\Error\Error::class);
         // Wrong username/password
@@ -150,7 +153,7 @@ public function testJoinSingleSuccess(): void
         ]);
     }
 
-    public function testJoinSingleFailedLogin()
+    public function testJoinSingleFailedLogin(): void
     {
         $this->expectException(\SimpleSAML\Error\Error::class);
         // Wrong username/password
@@ -180,7 +183,7 @@ public function testMultiQuerySuccess(): void
         ]);
     }
 
-    public function testMultiQueryFailedLogin()
+    public function testMultiQueryFailedLogin(): void
     {
         $this->expectException(\SimpleSAML\Error\Error::class);
         // Wrong username/password

tests/src/Auth/Source/SQLWrapper.php

@@ -15,11 +15,19 @@
 
 class SQLWrapper extends SQL
 {
+    /**
+     * @param array<mixed> $info
+     * @param array<mixed> $config
+     */
     public function __construct(array $info, array $config)
     {
         parent::__construct($info, $config);
     }
 
+
+    /**
+     * @return array<mixed>
+     */
     public function callLogin(string $username, string $password): array
     {
         return $this->login($username, $password);