Create assertion and type-class for xs:negativeInteger

Author: tvdijen

src/Assert/Assert.php

@@ -30,6 +30,7 @@
  * @method static void validNCName(mixed $value, string $message = '', string $exception = '')
  * @method static void validNMToken(mixed $value, string $message = '', string $exception = '')
  * @method static void validNMTokens(mixed $value, string $message = '', string $exception = '')
+ * @method static void validNegativeInteger(mixed $value, string $message = '', string $exception = '')
  * @method static void validNonPositiveInteger(mixed $value, string $message = '', string $exception = '')
  * @method static void validNormalizedString(mixed $value, string $message = '', string $exception = '')
  * @method static void validQName(mixed $value, string $message = '', string $exception = '')
@@ -58,6 +59,7 @@
  * @method static void nullOrValidNCName(mixed $value, string $message = '', string $exception = '')
  * @method static void nullOrValidNMToken(mixed $value, string $message = '', string $exception = '')
  * @method static void nullOrValidNMTokens(mixed $value, string $message = '', string $exception = '')
+ * @method static void nullOrValidNegativeInteger(mixed $value, string $message = '', string $exception = '')
  * @method static void nullOrValidNonPositiveInteger(mixed $value, string $message = '', string $exception = '')
  * @method static void nullOrValidNormalizedString(mixed $value, string $message = '', string $exception = '')
  * @method static void nullOrValidQName(mixed $value, string $message = '', string $exception = '')
@@ -86,6 +88,7 @@
  * @method static void allValidNCName(mixed $value, string $message = '', string $exception = '')
  * @method static void allValidNMToken(mixed $value, string $message = '', string $exception = '')
  * @method static void allValidNMTokens(mixed $value, string $message = '', string $exception = '')
+ * @method static void allValidNegativeInteger(mixed $value, string $message = '', string $exception = '')
  * @method static void allValidNonPositiveInteger(mixed $value, string $message = '', string $exception = '')
  * @method static void allValidNormalizedString(mixed $value, string $message = '', string $exception = '')
  * @method static void allValidQName(mixed $value, string $message = '', string $exception = '')
@@ -117,6 +120,7 @@ class Assert extends BaseAssert
     use NCNameTrait;
     use NMTokenTrait;
     use NMTokensTrait;
+    use NegativeIntegerTrait;
     use NonPositiveIntegerTrait;
     use NormalizedStringTrait;
     use QNameTrait;

src/Assert/NegativeIntegerTrait.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SimpleSAML\XML\Assert;
+
+use InvalidArgumentException;
+
+/**
+ * @package simplesamlphp/xml-common
+ */
+trait NegativeIntegerTrait
+{
+    /** @var string */
+    private static string $negativeInteger_regex = '/^(-\d+)$/D';
+
+
+    /**
+     * @param string $value
+     * @param string $message
+     */
+    protected static function validNegativeInteger(string $value, string $message = ''): void
+    {
+        parent::regex(
+            $value,
+            self::$negativeInteger_regex,
+            $message ?: '%s is not a valid xs:negativeInteger',
+            InvalidArgumentException::class,
+        );
+    }
+}

src/Type/NegativeIntegerValue.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SimpleSAML\XML\Type;
+
+use SimpleSAML\XML\Assert\Assert;
+use SimpleSAML\XML\Exception\SchemaViolationException;
+
+/**
+ * @package simplesaml/xml-common
+ */
+class NegativeIntegerValue extends IntegerValue
+{
+    /**
+     * Validate the value.
+     *
+     * @param string $value
+     * @throws \SimpleSAML\XML\Exception\SchemaViolationException on failure
+     * @return void
+     */
+    protected function validateValue(string $value): void
+    {
+        Assert::validNegativeInteger($this->sanitizeValue($value), SchemaViolationException::class);
+    }
+}

tests/Assert/NegativeIntegerTest.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SimpleSAML\Test\XML\Assert;
+
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+use SimpleSAML\Assert\AssertionFailedException;
+use SimpleSAML\XML\Assert\Assert;
+
+/**
+ * Class \SimpleSAML\Test\XML\Assert\NegativeIntegerTest
+ *
+ * @package simplesamlphp/xml-common
+ */
+#[CoversClass(Assert::class)]
+final class NegativeIntegerTest extends TestCase
+{
+    /**
+     * @param boolean $shouldPass
+     * @param string $negativeInteger
+     */
+    #[DataProvider('provideNegativeInteger')]
+    public function testValidNegativeInteger(bool $shouldPass, string $negativeInteger): void
+    {
+        try {
+            Assert::validNegativeInteger($negativeInteger);
+            $this->assertTrue($shouldPass);
+        } catch (AssertionFailedException $e) {
+            $this->assertFalse($shouldPass);
+        }
+    }
+
+
+    /**
+     * @return array<string, array{0: bool, 1: string}>
+     */
+    public static function provideNegativeInteger(): array
+    {
+        return [
+            'empty' => [false, ''],
+            'valid non-positive integer' => [true, '-123456'],
+            'invalid zero' => [false, '0'],
+            'valid negative leading zeros' => [true, '-0000000000000000000005'],
+            'invalid with fractional' => [false, '-1.'],
+            'invalid positive' => [false, '1234'],
+            'invalid with thousands-delimiter' => [false, '-1,234'],
+        ];
+    }
+}

tests/Type/NegativeIntegerValueTest.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SimpleSAML\Test\XML\Type;
+
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+use SimpleSAML\XML\Exception\SchemaViolationException;
+use SimpleSAML\XML\Type\NegativeIntegerValue;
+
+/**
+ * Class \SimpleSAML\Test\Type\NegativeIntegerValueTest
+ *
+ * @package simplesamlphp/xml-common
+ */
+#[CoversClass(NegativeIntegerValue::class)]
+final class NegativeIntegerValueTest extends TestCase
+{
+    /**
+     * @param boolean $shouldPass
+     * @param string $negativeInteger
+     */
+    #[DataProvider('provideNegativeInteger')]
+    public function testNegativeInteger(bool $shouldPass, string $negativeInteger): void
+    {
+        try {
+            NegativeIntegerValue::fromString($negativeInteger);
+            $this->assertTrue($shouldPass);
+        } catch (SchemaViolationException $e) {
+            $this->assertFalse($shouldPass);
+        }
+    }
+
+
+    /**
+     * @return array<string, array{0: bool, 1: string}>
+     */
+    public static function provideNegativeInteger(): array
+    {
+        return [
+            'empty' => [false, ''],
+            'valid non-positive integer' => [true, '-123456'],
+            'invalid zero' => [false, '0'],
+            'valid negative leading zeros' => [true, '-0000000000000000000005'],
+            'valid with whitespace collapse' => [true, " -1 234 \n"],
+            'invalid with fractional' => [false, '-1.'],
+            'invalid positive' => [false, '1234'],
+            'invalid with thousands-delimiter' => [false, '-1,234'],
+        ];
+    }
+}