No longer format documents by default and remove NS_CLEAN option: both mess up the position of xmlns-attributes

tvdijen · tvdijen · commit a6aa08a950b4 · 2025-01-25T00:53:27.000+01:00
diff --git a/src/DOMDocumentFactory.php b/src/DOMDocumentFactory.php
@@ -24,7 +24,7 @@ final class DOMDocumentFactory
      * @var non-negative-int
      * TODO: Add LIBXML_NO_XXE to the defaults when PHP 8.4.0 + libxml 2.13.0 become generally available
      */
-    public const DEFAULT_OPTIONS = LIBXML_COMPACT | LIBXML_NONET | LIBXML_NSCLEAN;
+    public const DEFAULT_OPTIONS = LIBXML_COMPACT | LIBXML_NONET;
 
 
     /**
diff --git a/src/SerializableElementTrait.php b/src/SerializableElementTrait.php
@@ -20,11 +20,11 @@ trait SerializableElementTrait
     /**
      * Whether to format the string output of this element or not.
      *
-     * Defaults to true. Override to disable output formatting.
+     * Defaults to false. Override to disable output formatting.
      *
      * @var bool
      */
-    protected bool $formatOutput = true;
+    protected bool $formatOutput = false;
 
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -20,11 +20,11 @@ trait SerializableElementTrait`
`20`	`20`	`/**`
`21`	`21`	`* Whether to format the string output of this element or not.`
`22`	`22`	`*`
`23`		`- * Defaults to true. Override to disable output formatting.`
	`23`	`+ * Defaults to false. Override to disable output formatting.`
`24`	`24`	`*`
`25`	`25`	`* @var bool`
`26`	`26`	`*/`
`27`		`- protected bool $formatOutput = true;`
	`27`	`+ protected bool $formatOutput = false;`
`28`	`28`
`29`	`29`
`30`	`30`	`/**`