Fix attribute-arrayization

Author: tvdijen

src/Attribute.php

@@ -137,7 +137,7 @@ public static function fromArray(array $data): static
             $data['namespaceURI'],
             $data['namespacePrefix'],
             $data['attrName'],
-            $data['attrValue'],
+            StringValue::fromString($data['attrValue']),
         );
     }
 
@@ -166,7 +166,7 @@ private static function processArrayContents(array $data): array
         Assert::nullOrValidAnyURI($data['namespaceuri']);
         Assert::nullOrValidNCName($data['namespaceprefix']);
         Assert::nullOrValidNCName($data['attrname']);
-        Assert::isAOf($data['attrvalue'], ValueTypeInterface::class);
+//        Assert::isAOf($data['attrvalue'], ValueTypeInterface::class);
 
         return [
             'namespaceURI' => $data['namespaceuri'],
@@ -193,7 +193,7 @@ public function toArray(): array
             'namespaceURI' => $this->getNamespaceURI(),
             'namespacePrefix' => $this->getNamespacePrefix(),
             'attrName' => $this->getAttrName(),
-            'attrValue' => $this->getAttrValue(),
+            'attrValue' => $this->getAttrValue()->getValue(),
         ];
     }
 }

tests/XML/AttributeTest.php

@@ -43,7 +43,7 @@ public static function setUpBeforeClass(): void
             'namespaceURI' => 'urn:x-simplesamlphp:phpunit',
             'namespacePrefix' => 'ssp',
             'attrName' => 'test1',
-            'attrValue' => StringValue::fromString('testvalue1'),
+            'attrValue' => 'testvalue1',
         ];
     }
 
@@ -68,7 +68,7 @@ public function testMarshallingArray(): void
 
     /**
      */
-    public function testUnmarshalling(): void
+    public function testUnmarshallingArray(): void
     {
         /**
          * @var array{
@@ -89,7 +89,7 @@ public function testUnmarshalling(): void
 
     /**
      */
-    public function testMarshallingXML(): void
+    public function testMarshalling(): void
     {
         $extendableAttribute = new Attribute(
             'urn:x-simplesamlphp:phpunit',