typed constants

Author: tvdijen

composer.json

@@ -32,7 +32,7 @@
         }
     },
     "require": {
-        "php": "^8.2",
+        "php": "^8.3",
 
         "ext-bcmath": "*",
         "ext-date": "*",

src/XML/AbstractElement.php

@@ -25,7 +25,9 @@
  *
  * @package simplesamlphp/xml-common
  */
-abstract class AbstractElement implements SerializableElementInterface
+abstract class AbstractElement implements
+    SerializableElementInterface,
+    ElementInterface
 {
     use SerializableElementTrait;
 
@@ -34,7 +36,6 @@ abstract class AbstractElement implements SerializableElementInterface
      * Create a document structure for this element
      *
      * @param \DOMElement|null $parent The element we should append to.
-     * @return \DOMElement
      */
     public function instantiateParentElement(?DOMElement $parent = null): DOMElement
     {
@@ -117,7 +118,6 @@ public static function getOptionalAttribute(
      * Static method that processes a fully namespaced class name and returns the name of the class from it.
      *
      * @param string $class
-     * @return string
      */
     public static function getClassName(string $class): string
     {
@@ -129,8 +129,6 @@ public static function getClassName(string $class): string
 
     /**
      * Get the XML qualified name (prefix:name) of the element represented by this class.
-     *
-     * @return string
      */
     public function getQualifiedName(): string
     {
@@ -166,8 +164,6 @@ public static function getChildrenOfClass(DOMElement $parent): array
 
     /**
      * Get the namespace for the element.
-     *
-     * @return string|null
      */
     public static function getNamespaceURI(): ?string
     {
@@ -187,8 +183,6 @@ public static function getNamespaceURI(): ?string
 
     /**
      * Get the namespace-prefix for the element.
-     *
-     * @return string
      */
     public static function getNamespacePrefix(): string
     {
@@ -206,8 +200,6 @@ public static function getNamespacePrefix(): string
 
     /**
      * Get the local name for the element.
-     *
-     * @return string
      */
     public static function getLocalName(): string
     {
@@ -224,8 +216,6 @@ public static function getLocalName(): string
 
     /**
      * Whether the element may be normalized.
-     *
-     * @return bool
      */
     public static function getNormalization(): bool
     {
@@ -244,7 +234,6 @@ public static function getNormalization(): bool
      * Test if an object, at the state it's in, would produce an empty XML-element
      *
      * @codeCoverageIgnore
-     * @return bool
      */
     public function isEmptyElement(): bool
     {

src/XML/ArrayizableElementInterface.php

@@ -15,7 +15,6 @@ interface ArrayizableElementInterface
      * Create a class from an array
      *
      * @param array<string, mixed> $data
-     * @return static
      */
     public static function fromArray(array $data): static;
 

src/XML/Assert/ByteTrait.php

@@ -11,7 +11,6 @@
  */
 trait ByteTrait
 {
-    /** @var string */
     private static string $byte_regex = '/^
         (
             (

src/XML/Assert/DateTimeTrait.php

@@ -30,8 +30,6 @@ trait DateTimeTrait
      * * ss is a two-integer-digit numeral that represents the whole seconds;
      * * '.' s+ (if present) represents the fractional seconds;
      * * zzzzzz (if present) represents the timezone (as described below).
-     *
-     * @var string
      */
     private static string $datetime_regex = '/^
         -?

src/XML/Assert/DateTrait.php

@@ -21,8 +21,6 @@ trait DateTrait
      *
      * and the least upper bound of the interval is the timeline point represented (noncanonically) by:
      * '-' yyyy '-' mm '-' dd 'T24:00:00' zzzzzz?.
-     *
-     * @var string
      */
     private static string $date_regex  = '/^
         -?

src/XML/Assert/DayTrait.php

@@ -13,8 +13,6 @@ trait DayTrait
 {
     /**
      * Format: ---DD with optional timezone representation
-     *
-     * @var string
      */
     private static string $day_regex  = '/^
         ---

src/XML/Assert/DecimalTrait.php

@@ -11,7 +11,6 @@
  */
 trait DecimalTrait
 {
-    /** @var string */
     private static string $decimal_regex = '/^[+-]?((\d+(\.\d*)?)|(\.\d+))$/D';
 
 

src/XML/Assert/DoubleTrait.php

@@ -11,7 +11,6 @@
  */
 trait DoubleTrait
 {
-    /** @var string */
     private static string $double_regex = '/^
         (
             ([+-]?([0-9]+[.][0-9]*|[.][0-9]+)([e][+-]?[0-9]+)?)

src/XML/Assert/DurationTrait.php

@@ -11,7 +11,6 @@
  */
 trait DurationTrait
 {
-    /** @var string */
     private static string $duration_regex = '/^
         ([-+]?)
         P