Prevent ending up with an invalid QName starting with a colon

tvdijen · tvdijen · commit f72cfbcbc8b7 · 2025-06-27T16:31:56.000+02:00
diff --git a/src/Type/QNameValue.php b/src/Type/QNameValue.php
@@ -174,6 +174,6 @@ public static function fromDocument(
         // Will return the default namespace (if any) when prefix is NULL
         $namespaceURI = $element->lookupNamespaceUri($namespacePrefix);
 
-        return new static('{' . $namespaceURI . '}' . $namespacePrefix . ':' . $localName);
+        return new static('{' . $namespaceURI . '}' . ($namespacePrefix ? $namespacePrefix . ':' : '') . $localName);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,6 @@ public static function fromDocument(`
`174`	`174`	`// Will return the default namespace (if any) when prefix is NULL`
`175`	`175`	`$namespaceURI = $element->lookupNamespaceUri($namespacePrefix);`
`176`	`176`
`177`		`- return new static('{' . $namespaceURI . '}' . $namespacePrefix . ':' . $localName);`
	`177`	`+ return new static('{' . $namespaceURI . '}' . ($namespacePrefix ? $namespacePrefix . ':' : '') . $localName);`
`178`	`178`	`}`
`179`	`179`	`}`