Fix nullptr dereferencing in the verbose path

arrowd · TheAssassin · commit 6bb2ba371cea · 2025-04-21T22:47:32.000+02:00
diff --git a/src/appimagetool_fetch_runtime.cpp b/src/appimagetool_fetch_runtime.cpp
@@ -156,7 +156,7 @@ class GetRequest {
                 foundFile = true;
             } else {
                 if (verbose) {
-                    std::cerr << "libcurl's default CA certificate bundle file " << caInfo << " was not found on this system, nulling" << std::endl;
+                    std::cerr << "libcurl's default CA certificate bundle file " << (caInfo ? caInfo : "") << " was not found on this system, nulling" << std::endl;
                 }
                 setOption(CURLOPT_CAINFO, "");
             }
@@ -172,7 +172,7 @@ class GetRequest {
                 foundDir = true;
             } else {
                 if (verbose) {
-                    std::cerr << "libcurl's default CA certificate bundle directory " << caPath << " was not found on this system, nulling" << std::endl;
+                    std::cerr << "libcurl's default CA certificate bundle directory " << (caPath ? caPath : "") << " was not found on this system, nulling" << std::endl;
                 }
                 setOption(CURLOPT_CAPATH, "");
             }

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ class GetRequest {`
`156`	`156`	`foundFile = true;`
`157`	`157`	`} else {`
`158`	`158`	`if (verbose) {`
`159`		`- std::cerr << "libcurl's default CA certificate bundle file " << caInfo << " was not found on this system, nulling" << std::endl;`
	`159`	`+ std::cerr << "libcurl's default CA certificate bundle file " << (caInfo ? caInfo : "") << " was not found on this system, nulling" << std::endl;`
`160`	`160`	`}`
`161`	`161`	`setOption(CURLOPT_CAINFO, "");`
`162`	`162`	`}`
`@@ -172,7 +172,7 @@ class GetRequest {`
`172`	`172`	`foundDir = true;`
`173`	`173`	`} else {`
`174`	`174`	`if (verbose) {`
`175`		`- std::cerr << "libcurl's default CA certificate bundle directory " << caPath << " was not found on this system, nulling" << std::endl;`
	`175`	`+ std::cerr << "libcurl's default CA certificate bundle directory " << (caPath ? caPath : "") << " was not found on this system, nulling" << std::endl;`
`176`	`176`	`}`
`177`	`177`	`setOption(CURLOPT_CAPATH, "");`
`178`	`178`	`}`