Fix zsync parameter order

Author: TheAssassin

ci/install-static-zsyncmake.sh

@@ -35,21 +35,55 @@ wget \
     https://sources.debian.org/data/main/z/zsync/0.6.2-6/debian/patches/manpages.diff \
     https://sources.debian.org/data/main/z/zsync/0.6.2-6/debian/patches/clienthttp.diff \
     https://sources.debian.org/data/main/z/zsync/0.6.2-6/debian/patches/fix-build-with-gcc-14.patch
+
 sha256sum -c <<\EOF
 f14a7ffcb3bdadba252c9afbe5e8da358fc77f20072ae5b21475bdfc44b50975  buildsystem.diff
 085e9b5856bb8ac0d8567e977a9d5fafc6c19df02b7cfb8e011fedaf2862eaad  clienthttp.diff
 f04bba2866c47b8597723d49eec3f1fd50e40a08171e261bf0fc262852ba17e5  manpages.diff
 35cbce69194743df1f3f4b9bc9ad36a4c440b117c6a17c268023c642c0d50650  fix-build-with-gcc-14.patch
 EOF
 
+# custom patch to at least ignore flags passed after the first parameter
+# see https://github.com/AppImage/appimagetool/pull/93 for more information
+cat > argparser.patch <<\EOF
+diff --git a/make.c b/make.c
+index 191b527..d86f130 100644
+--- a/make.c
++++ b/make.c
+@@ -564,6 +564,14 @@ off_t get_len(FILE * f) {
+  * Main program
+  */
+ int main(int argc, char **argv) {
++    if (getenv("VERBOSE") != 0) {
++        fprintf(stderr, "Parameters:");
++        for (int i = 0; i < argc; ++i) {
++            fprintf(stderr, " %s", argv[i]);
++        }
++        fprintf(stderr, "\n\n");
++    }
++
+     FILE *instream;
+     char *fname = NULL, *zfname = NULL;
+     char **url = NULL;
+@@ -641,7 +649,7 @@ int main(int argc, char **argv) {
+         }
+ 
+         /* Open data to create .zsync for - either it's a supplied filename, or stdin */
+-        if (optind == argc - 1) {
++        if (optind <= argc - 1) {
+             infname = strdup(argv[optind]);
+             instream = fopen(infname, "rb");
+             if (!instream) {
+EOF
+
 for i in *.diff *.patch; do
     echo "Applying patch $i..."
     patch -p1 < "$i"
 done
 
 find . -type f -exec sed -i -e 's|off_t|size_t|g' {} \;
 
-./configure CFLAGS=-no-pie LDFLAGS=-static --prefix=/usr --build=$(arch)-unknown-linux-gnu
+./configure LDFLAGS=-static --prefix=/usr --build=$(arch)-unknown-linux-gnu
 
 if [[ "${GITHUB_ACTIONS:-}" != "" ]]; then
     jobs="$(nproc)"

src/appimagetool.c

@@ -1129,7 +1129,8 @@ main (int argc, char *argv[])
                 fprintf(stderr, "zsyncmake is available and updateinformation is provided, "
                                 "hence generating zsync file\n");
 
-                const gchar* const zsyncmake_command[] = {zsyncmake_path, destination, "-u", basename(destination), NULL};
+                // notice for Alpine builds: Alpine's getopt does not parse flags passed after the first parameter, order matters here
+                const gchar* const zsyncmake_command[] = {zsyncmake_path, "-u", basename(destination), destination, NULL};
 
                 if (verbose) {
                     fprintf(stderr, "Running zsyncmake process: ");