stared impl on decode for ubyte

Author: simplist-coder

amqp-type/src/fixed_width/boolean.rs

@@ -45,10 +45,6 @@ impl Decode for bool {
                 "bool".to_string(),
                 format!("bool cannot be constructed from value {:#04x}", c),
             )),
-            (Some(c), None) => Err(AppError::DeserializationError(
-                "bool".to_string(),
-                "Iterator was empty".to_string(),
-            )),
             (None, _) => Err(AppError::DeserializationError(
                 "bool".to_string(),
                 "Iterator was empty".to_string(),

amqp-type/src/fixed_width/ubyte.rs

@@ -1,19 +1,58 @@
 use crate::serde::encode::{Encode, Encoded};
+use crate::serde::decode::Decode;
+
 
 impl Encode for u8 {
     fn encode(&self) -> Encoded {
         Encoded::new_fixed(0x50, self.to_be_bytes().to_vec())
     }
 }
 
+impl Decode for u8 {
+    fn can_decode(data: impl Iterator<Item = u8>) -> bool {
+        let mut iter = data.into_iter().peekable();
+        match iter.peek() {
+            Some(0x50) => true,
+            _ => false
+        }
+    }
+
+    fn try_decode(data: impl Iterator<Item = u8>) -> Result<Self, crate::error::AppError>
+        where
+            Self: Sized {
+        todo!()
+    }
+    
+}
+
 #[cfg(test)]
 mod test {
 
+
     use super::*;
 
     #[test]
     fn construct_ubyte() {
         let val: u8 = 8;
         assert_eq!(val.encode().constructor(), 0x50);
     }
+
+    #[test]
+    fn can_deocde_returns_true_if_constructor_is_valid() {
+        let val = vec![0x50, 0x41];
+        assert_eq!(u8::can_decode(val.into_iter()), true);
+    }
+
+    #[test]
+    fn can_decode_return_false_if_constructor_is_invalid() {
+        let val = vec![0x51];
+        assert_eq!(u8::can_decode(val.into_iter()), false);
+    }
+
+    #[test]
+    fn try_decode_returns_correct_value() {
+        let val = vec![0x50, 0x10];
+        assert_eq!(u8::try_decode(val.into_iter()).unwrap(), 16)
+    }
+
 }

amqp-type/src/serde/decode.rs

@@ -1,16 +1,14 @@
-use crate::{
-    error::AppError,
-    serde::encode::{Encode, Encoded},
-};
+use crate::error::AppError;
+
 
 #[derive(Hash, Eq, PartialEq)]
 pub struct Constructor(u8);
 
 pub trait Decode {
+    fn can_decode(data: impl Iterator<Item = u8>) -> bool;
     fn try_decode(data: impl Iterator<Item = u8>) -> Result<Self, AppError>
     where
         Self: Sized;
-    fn can_decode(data: impl Iterator<Item = u8>) -> bool;
 }
 
 impl From<u8> for Constructor {