fix(redis): cleanup access pattern across callsites (#2289)

* fix(redis): cleanup access pattern across callsites

* swap redis command to be non blocking

Author: icecrasher321

apps/sim/app/api/chat/[identifier]/otp/route.ts

@@ -16,15 +16,17 @@ export async function GET(request: NextRequest) {
   const requestId = nanoid()
   logger.info(`Inactivity alert polling triggered (${requestId})`)
 
+  let lockAcquired = false
+
   try {
     const authError = verifyCronAuth(request, 'Inactivity alert polling')
     if (authError) {
       return authError
     }
 
-    const locked = await acquireLock(LOCK_KEY, requestId, LOCK_TTL_SECONDS)
+    lockAcquired = await acquireLock(LOCK_KEY, requestId, LOCK_TTL_SECONDS)
 
-    if (!locked) {
+    if (!lockAcquired) {
       return NextResponse.json(
         {
           success: true,
@@ -57,6 +59,8 @@ export async function GET(request: NextRequest) {
       { status: 500 }
     )
   } finally {
-    await releaseLock(LOCK_KEY).catch(() => {})
+    if (lockAcquired) {
+      await releaseLock(LOCK_KEY, requestId).catch(() => {})
+    }
   }
 }

apps/sim/app/api/notifications/poll/route.ts

@@ -61,6 +61,8 @@ export async function GET(request: NextRequest) {
       { status: 500 }
     )
   } finally {
-    await releaseLock(LOCK_KEY).catch(() => {})
+    if (lockValue) {
+      await releaseLock(LOCK_KEY, lockValue).catch(() => {})
+    }
   }
 }

apps/sim/app/api/webhooks/poll/gmail/route.ts

@@ -61,6 +61,8 @@ export async function GET(request: NextRequest) {
       { status: 500 }
     )
   } finally {
-    await releaseLock(LOCK_KEY).catch(() => {})
+    if (lockValue) {
+      await releaseLock(LOCK_KEY, lockValue).catch(() => {})
+    }
   }
 }

apps/sim/app/api/webhooks/poll/outlook/route.ts

@@ -61,6 +61,8 @@ export async function GET(request: NextRequest) {
       { status: 500 }
     )
   } finally {
-    await releaseLock(LOCK_KEY).catch(() => {})
+    if (lockValue) {
+      await releaseLock(LOCK_KEY, lockValue).catch(() => {})
+    }
   }
 }