fix memory

Author: icecrasher321

apps/docs/content/docs/en/tools/memory.mdx

@@ -1,6 +1,6 @@
 ---
 title: Memory
-description: Add memory store
+description: Store and retrieve conversation history
 ---
 
 import { BlockInfoCard } from "@/components/ui/block-info-card"
@@ -10,100 +10,94 @@ import { BlockInfoCard } from "@/components/ui/block-info-card"
   color="#F64F9E"
 />
 
-## Usage Instructions
-
-Integrate Memory into the workflow. Can add, get a memory, get all memories, and delete memories.
+## Overview
 
+The Memory block stores conversation history for agents. Each memory is identified by a `conversationId` that you provide. Multiple agents can share the same memory by using the same `conversationId`.
 
+Memory stores only user and assistant messages. System messages are not stored—they are configured in the Agent block and prefixed at runtime.
 
 ## Tools
 
 ### `memory_add`
 
-Add a new memory to the database or append to existing memory with the same ID.
+Add a message to memory. Creates a new memory if the `conversationId` doesn't exist, or appends to existing memory.
 
 #### Input
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
-| `conversationId` | string | No | Conversation identifier \(e.g., user-123, session-abc\). If a memory with this conversationId already exists for this block, the new message will be appended to it. |
-| `id` | string | No | Legacy parameter for conversation identifier. Use conversationId instead. Provided for backwards compatibility. |
-| `role` | string | Yes | Role for agent memory \(user, assistant, or system\) |
-| `content` | string | Yes | Content for agent memory |
-| `blockId` | string | No | Optional block ID. If not provided, uses the current block ID from execution context, or defaults to "default". |
+| `conversationId` | string | Yes | Unique identifier for the conversation (e.g., `user-123`, `session-abc`) |
+| `role` | string | Yes | Message role: `user` or `assistant` |
+| `content` | string | Yes | Message content |
 
 #### Output
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `success` | boolean | Whether the memory was added successfully |
-| `memories` | array | Array of memory objects including the new or updated memory |
-| `error` | string | Error message if operation failed |
+| `success` | boolean | Whether the operation succeeded |
+| `memories` | array | Updated memory array |
+| `error` | string | Error message if failed |
 
 ### `memory_get`
 
-Retrieve memory by conversationId, blockId, blockName, or a combination. Returns all matching memories.
+Retrieve memory by conversation ID.
 
 #### Input
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
-| `conversationId` | string | No | Conversation identifier \(e.g., user-123, session-abc\). If provided alone, returns all memories for this conversation across all blocks. |
-| `id` | string | No | Legacy parameter for conversation identifier. Use conversationId instead. Provided for backwards compatibility. |
-| `blockId` | string | No | Block identifier. If provided alone, returns all memories for this block across all conversations. If provided with conversationId, returns memories for that specific conversation in this block. |
-| `blockName` | string | No | Block name. Alternative to blockId. If provided alone, returns all memories for blocks with this name. If provided with conversationId, returns memories for that conversation in blocks with this name. |
+| `conversationId` | string | Yes | Conversation identifier |
 
 #### Output
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `success` | boolean | Whether the memory was retrieved successfully |
-| `memories` | array | Array of memory objects with conversationId, blockId, blockName, and data fields |
-| `message` | string | Success or error message |
-| `error` | string | Error message if operation failed |
+| `success` | boolean | Whether the operation succeeded |
+| `memories` | array | Array of messages with `role` and `content` |
+| `error` | string | Error message if failed |
 
 ### `memory_get_all`
 
-Retrieve all memories from the database
-
-#### Input
-
-| Parameter | Type | Required | Description |
-| --------- | ---- | -------- | ----------- |
+Retrieve all memories for the current workflow.
 
 #### Output
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `success` | boolean | Whether all memories were retrieved successfully |
-| `memories` | array | Array of all memory objects with key, conversationId, blockId, blockName, and data fields |
-| `message` | string | Success or error message |
-| `error` | string | Error message if operation failed |
+| `success` | boolean | Whether the operation succeeded |
+| `memories` | array | All memory objects with `conversationId` and `data` fields |
+| `error` | string | Error message if failed |
 
 ### `memory_delete`
 
-Delete memories by conversationId, blockId, blockName, or a combination. Supports bulk deletion.
+Delete memory by conversation ID.
 
 #### Input
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
-| `conversationId` | string | No | Conversation identifier \(e.g., user-123, session-abc\). If provided alone, deletes all memories for this conversation across all blocks. |
-| `id` | string | No | Legacy parameter for conversation identifier. Use conversationId instead. Provided for backwards compatibility. |
-| `blockId` | string | No | Block identifier. If provided alone, deletes all memories for this block across all conversations. If provided with conversationId, deletes memories for that specific conversation in this block. |
-| `blockName` | string | No | Block name. Alternative to blockId. If provided alone, deletes all memories for blocks with this name. If provided with conversationId, deletes memories for that conversation in blocks with this name. |
+| `conversationId` | string | Yes | Conversation identifier to delete |
 
 #### Output
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `success` | boolean | Whether the memory was deleted successfully |
-| `message` | string | Success or error message |
-| `error` | string | Error message if operation failed |
+| `success` | boolean | Whether the operation succeeded |
+| `message` | string | Confirmation message |
+| `error` | string | Error message if failed |
+
+## Agent Memory Types
 
+When using memory with an Agent block, you can configure how conversation history is managed:
 
+| Type | Description |
+| ---- | ----------- |
+| **Full Conversation** | Stores all messages, limited by model's context window (uses 90% to leave room for response) |
+| **Sliding Window (Messages)** | Keeps the last N messages (default: 10) |
+| **Sliding Window (Tokens)** | Keeps messages that fit within a token limit (default: 4000) |
 
 ## Notes
 
-- Category: `blocks`
-- Type: `memory`
+- Memory is scoped per workflow—different workflows have separate memory stores
+- The `conversationId` is your responsibility to manage (e.g., use session IDs, user IDs, or UUIDs)
+- System messages belong in the Agent block configuration, not in memory

apps/sim/app/api/workflows/[id]/execute/route.ts

@@ -743,14 +743,17 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
 
           const onStream = async (streamingExec: StreamingExecution) => {
             const blockId = (streamingExec.execution as any).blockId
+
             const reader = streamingExec.stream.getReader()
             const decoder = new TextDecoder()
+            let chunkCount = 0
 
             try {
               while (true) {
                 const { done, value } = await reader.read()
                 if (done) break
 
+                chunkCount++
                 const chunk = decoder.decode(value, { stream: true })
                 sendEvent({
                   type: 'stream:chunk',

apps/sim/app/chat/hooks/use-chat-streaming.ts

@@ -320,8 +320,8 @@ export function useChatStreaming() {
                     const trimmedOutput = output.trim()
                     if (!trimmedOutput) return false
 
-                    // Skip outputs that exactly match the streamed content to avoid duplication
-                    if (trimmedStreamingContent && trimmedOutput === trimmedStreamingContent) {
+                    // Skip outputs that are already in the streamed content to avoid duplication
+                    if (trimmedStreamingContent?.includes(trimmedOutput)) {
                       return false
                     }
 

apps/sim/executor/constants.ts

@@ -158,11 +158,19 @@ export const HTTP = {
 
 export const AGENT = {
   DEFAULT_MODEL: 'claude-sonnet-4-5',
-  DEFAULT_FUNCTION_TIMEOUT: 600000, // 10 minutes for custom tool code execution
-  REQUEST_TIMEOUT: 600000, // 10 minutes for LLM API requests
+  DEFAULT_FUNCTION_TIMEOUT: 600000,
+  REQUEST_TIMEOUT: 600000,
   CUSTOM_TOOL_PREFIX: 'custom_',
 } as const
 
+export const MEMORY = {
+  DEFAULT_SLIDING_WINDOW_SIZE: 10,
+  DEFAULT_SLIDING_WINDOW_TOKENS: 4000,
+  CONTEXT_WINDOW_UTILIZATION: 0.9,
+  MAX_CONVERSATION_ID_LENGTH: 255,
+  MAX_MESSAGE_CONTENT_BYTES: 100 * 1024,
+} as const
+
 export const ROUTER = {
   DEFAULT_MODEL: 'gpt-4o',
   DEFAULT_TEMPERATURE: 0,

apps/sim/executor/handlers/agent/agent-handler.test.ts

@@ -1140,7 +1140,7 @@ describe('AgentBlockHandler', () => {
       expect(systemMessages[0].content).toBe('You are a helpful assistant.')
     })
 
-    it('should prioritize messages array system message over system messages in memories', async () => {
+    it('should prefix agent system message before legacy memories', async () => {
       const inputs = {
         model: 'gpt-4o',
         messages: [
@@ -1163,25 +1163,26 @@ describe('AgentBlockHandler', () => {
       const requestBody = JSON.parse(fetchCall[1].body)
 
       // Verify messages were built correctly
+      // Agent system (1) + legacy memories (3) + user from messages (1) = 5
       expect(requestBody.messages).toBeDefined()
-      expect(requestBody.messages.length).toBe(5) // memory system + 2 non-system memories + 2 from messages array
+      expect(requestBody.messages.length).toBe(5)
 
-      // All messages should be present (memories first, then messages array)
-      // Memory messages come first
+      // Agent's system message is prefixed first
       expect(requestBody.messages[0].role).toBe('system')
-      expect(requestBody.messages[0].content).toBe('Old system message from memories.')
-      expect(requestBody.messages[1].role).toBe('user')
-      expect(requestBody.messages[1].content).toBe('Hello!')
-      expect(requestBody.messages[2].role).toBe('assistant')
-      expect(requestBody.messages[2].content).toBe('Hi there!')
-      // Then messages array
-      expect(requestBody.messages[3].role).toBe('system')
-      expect(requestBody.messages[3].content).toBe('You are a helpful assistant.')
+      expect(requestBody.messages[0].content).toBe('You are a helpful assistant.')
+      // Then legacy memories (with their system message preserved)
+      expect(requestBody.messages[1].role).toBe('system')
+      expect(requestBody.messages[1].content).toBe('Old system message from memories.')
+      expect(requestBody.messages[2].role).toBe('user')
+      expect(requestBody.messages[2].content).toBe('Hello!')
+      expect(requestBody.messages[3].role).toBe('assistant')
+      expect(requestBody.messages[3].content).toBe('Hi there!')
+      // Then user message from messages array
       expect(requestBody.messages[4].role).toBe('user')
       expect(requestBody.messages[4].content).toBe('What should I do?')
     })
 
-    it('should handle multiple system messages in memories with messages array', async () => {
+    it('should prefix agent system message and preserve legacy memory system messages', async () => {
       const inputs = {
         model: 'gpt-4o',
         messages: [
@@ -1207,21 +1208,23 @@ describe('AgentBlockHandler', () => {
 
       // Verify messages were built correctly
       expect(requestBody.messages).toBeDefined()
-      expect(requestBody.messages.length).toBe(7) // 5 memory messages (3 system + 2 conversation) + 2 from messages array
+      expect(requestBody.messages.length).toBe(7)
 
-      // All messages should be present in order
+      // Agent's system message prefixed first
       expect(requestBody.messages[0].role).toBe('system')
-      expect(requestBody.messages[0].content).toBe('First system message.')
-      expect(requestBody.messages[1].role).toBe('user')
-      expect(requestBody.messages[1].content).toBe('Hello!')
-      expect(requestBody.messages[2].role).toBe('system')
-      expect(requestBody.messages[2].content).toBe('Second system message.')
-      expect(requestBody.messages[3].role).toBe('assistant')
-      expect(requestBody.messages[3].content).toBe('Hi there!')
-      expect(requestBody.messages[4].role).toBe('system')
-      expect(requestBody.messages[4].content).toBe('Third system message.')
+      expect(requestBody.messages[0].content).toBe('You are a helpful assistant.')
+      // Then legacy memories with their system messages preserved in order
+      expect(requestBody.messages[1].role).toBe('system')
+      expect(requestBody.messages[1].content).toBe('First system message.')
+      expect(requestBody.messages[2].role).toBe('user')
+      expect(requestBody.messages[2].content).toBe('Hello!')
+      expect(requestBody.messages[3].role).toBe('system')
+      expect(requestBody.messages[3].content).toBe('Second system message.')
+      expect(requestBody.messages[4].role).toBe('assistant')
+      expect(requestBody.messages[4].content).toBe('Hi there!')
       expect(requestBody.messages[5].role).toBe('system')
-      expect(requestBody.messages[5].content).toBe('You are a helpful assistant.')
+      expect(requestBody.messages[5].content).toBe('Third system message.')
+      // Then user message from messages array
       expect(requestBody.messages[6].role).toBe('user')
       expect(requestBody.messages[6].content).toBe('Continue our conversation.')
     })