fix discovery calls

Author: icecrasher321

apps/sim/app/api/mcp/servers/[id]/refresh/route.ts

@@ -12,20 +12,12 @@ const logger = createLogger('McpServerRefreshAPI')
 
 export const dynamic = 'force-dynamic'
 
-/**
- * POST - Refresh an MCP server connection (requires any workspace permission)
- */
 export const POST = withMcpAuth<{ id: string }>('read')(
   async (request: NextRequest, { userId, workspaceId, requestId }, { params }) => {
     const { id: serverId } = await params
 
     try {
-      logger.info(
-        `[${requestId}] Refreshing MCP server: ${serverId} in workspace: ${workspaceId}`,
-        {
-          userId,
-        }
-      )
+      logger.info(`[${requestId}] Refreshing MCP server: ${serverId}`)
 
       const [server] = await db
         .select()
@@ -61,9 +53,7 @@ export const POST = withMcpAuth<{ id: string }>('read')(
         const tools = await mcpService.discoverServerTools(userId, serverId, workspaceId)
         connectionStatus = 'connected'
         toolCount = tools.length
-        logger.info(
-          `[${requestId}] Successfully connected to server ${serverId}, discovered ${toolCount} tools`
-        )
+        logger.info(`[${requestId}] Discovered ${toolCount} tools from server ${serverId}`)
       } catch (error) {
         connectionStatus = 'error'
         lastError = error instanceof Error ? error.message : 'Connection test failed'
@@ -94,14 +84,7 @@ export const POST = withMcpAuth<{ id: string }>('read')(
         .returning()
 
       if (connectionStatus === 'connected') {
-        logger.info(
-          `[${requestId}] Successfully refreshed MCP server: ${serverId} (${toolCount} tools)`
-        )
         await mcpService.clearCache(workspaceId)
-      } else {
-        logger.warn(
-          `[${requestId}] Refresh completed for MCP server ${serverId} but connection failed: ${lastError}`
-        )
       }
 
       return createMcpSuccessResponse({

apps/sim/app/api/mcp/tools/discover/route.ts

@@ -9,28 +9,18 @@ const logger = createLogger('McpToolDiscoveryAPI')
 
 export const dynamic = 'force-dynamic'
 
-/**
- * GET - Discover all tools from user's MCP servers
- */
 export const GET = withMcpAuth('read')(
   async (request: NextRequest, { userId, workspaceId, requestId }) => {
     try {
       const { searchParams } = new URL(request.url)
       const serverId = searchParams.get('serverId')
       const forceRefresh = searchParams.get('refresh') === 'true'
 
-      logger.info(`[${requestId}] Discovering MCP tools for user ${userId}`, {
-        serverId,
-        workspaceId,
-        forceRefresh,
-      })
+      logger.info(`[${requestId}] Discovering MCP tools`, { serverId, workspaceId, forceRefresh })
 
-      let tools
-      if (serverId) {
-        tools = await mcpService.discoverServerTools(userId, serverId, workspaceId)
-      } else {
-        tools = await mcpService.discoverTools(userId, workspaceId, forceRefresh)
-      }
+      const tools = serverId
+        ? await mcpService.discoverServerTools(userId, serverId, workspaceId)
+        : await mcpService.discoverTools(userId, workspaceId, forceRefresh)
 
       const byServer: Record<string, number> = {}
       for (const tool of tools) {
@@ -55,9 +45,6 @@ export const GET = withMcpAuth('read')(
   }
 )
 
-/**
- * POST - Refresh tool discovery for specific servers
- */
 export const POST = withMcpAuth('read')(
   async (request: NextRequest, { userId, workspaceId, requestId }) => {
     try {
@@ -72,10 +59,7 @@ export const POST = withMcpAuth('read')(
         )
       }
 
-      logger.info(
-        `[${requestId}] Refreshing tool discovery for user ${userId}, servers:`,
-        serverIds
-      )
+      logger.info(`[${requestId}] Refreshing tools for ${serverIds.length} servers`)
 
       const results = await Promise.allSettled(
         serverIds.map(async (serverId: string) => {
@@ -99,20 +83,16 @@ export const POST = withMcpAuth('read')(
         }
       })
 
-      const responseData = {
+      logger.info(`[${requestId}] Refresh completed: ${successes.length}/${serverIds.length}`)
+      return createMcpSuccessResponse({
         refreshed: successes,
         failed: failures,
         summary: {
           total: serverIds.length,
           successful: successes.length,
           failed: failures.length,
         },
-      }
-
-      logger.info(
-        `[${requestId}] Tool discovery refresh completed: ${successes.length}/${serverIds.length} successful`
-      )
-      return createMcpSuccessResponse(responseData)
+      })
     } catch (error) {
       logger.error(`[${requestId}] Error refreshing tool discovery:`, error)
       const { message, status } = categorizeError(error)

apps/sim/app/api/mcp/tools/stored/route.ts

@@ -19,24 +19,13 @@ interface StoredMcpTool {
   schema?: Record<string, unknown>
 }
 
-/**
- * GET - Get all stored MCP tools from workflows in the workspace
- *
- * Scans all workflows in the workspace and extracts MCP tools that have been
- * added to agent blocks. Returns the stored state of each tool for comparison
- * against current server state.
- */
 export const GET = withMcpAuth('read')(
   async (request: NextRequest, { userId, workspaceId, requestId }) => {
     try {
       logger.info(`[${requestId}] Fetching stored MCP tools for workspace ${workspaceId}`)
 
-      // Get all workflows in workspace
       const workflows = await db
-        .select({
-          id: workflow.id,
-          name: workflow.name,
-        })
+        .select({ id: workflow.id, name: workflow.name })
         .from(workflow)
         .where(eq(workflow.workspaceId, workspaceId))
 
@@ -47,12 +36,8 @@ export const GET = withMcpAuth('read')(
         return createMcpSuccessResponse({ tools: [] })
       }
 
-      // Get all agent blocks from these workflows
       const agentBlocks = await db
-        .select({
-          workflowId: workflowBlocks.workflowId,
-          subBlocks: workflowBlocks.subBlocks,
-        })
+        .select({ workflowId: workflowBlocks.workflowId, subBlocks: workflowBlocks.subBlocks })
         .from(workflowBlocks)
         .where(eq(workflowBlocks.type, 'agent'))