fix(workflow-block): improvements to pulsing effect, active execution state, and running workflow blocks in parallel (#927)

* fix: same child workflow executing in parallel with workflow block

* fixed run button prematurely showing completion before child workflows completed

* prevent child worklfows from touching the activeBlocks & layer logic in the parent executor

* surface child workflow errors to main workfow

* ack PR comments

Author: waleedlatif1

apps/sim/executor/handlers/workflow/workflow-handler.test.ts

@@ -107,15 +107,13 @@ describe('WorkflowBlockHandler', () => {
 
       // Simulate a cycle by adding the execution to the stack
 
-      ;(WorkflowBlockHandler as any).executionStack.add('parent-workflow-id_sub_child-workflow-id')
-
-      const result = await handler.execute(mockBlock, inputs, mockContext)
+      ;(WorkflowBlockHandler as any).executionStack.add(
+        'parent-workflow-id_sub_child-workflow-id_workflow-block-1'
+      )
 
-      expect(result).toEqual({
-        success: false,
-        error: 'Cyclic workflow dependency detected: parent-workflow-id_sub_child-workflow-id',
-        childWorkflowName: 'child-workflow-id',
-      })
+      await expect(handler.execute(mockBlock, inputs, mockContext)).rejects.toThrow(
+        'Error in child workflow "child-workflow-id": Cyclic workflow dependency detected: parent-workflow-id_sub_child-workflow-id_workflow-block-1'
+      )
     })
 
     it('should enforce maximum depth limit', async () => {
@@ -128,13 +126,9 @@ describe('WorkflowBlockHandler', () => {
           'level1_sub_level2_sub_level3_sub_level4_sub_level5_sub_level6_sub_level7_sub_level8_sub_level9_sub_level10_sub_level11',
       }
 
-      const result = await handler.execute(mockBlock, inputs, deepContext)
-
-      expect(result).toEqual({
-        success: false,
-        error: 'Maximum workflow nesting depth of 10 exceeded',
-        childWorkflowName: 'child-workflow-id',
-      })
+      await expect(handler.execute(mockBlock, inputs, deepContext)).rejects.toThrow(
+        'Error in child workflow "child-workflow-id": Maximum workflow nesting depth of 10 exceeded'
+      )
     })
 
     it('should handle child workflow not found', async () => {
@@ -146,27 +140,19 @@ describe('WorkflowBlockHandler', () => {
         statusText: 'Not Found',
       })
 
-      const result = await handler.execute(mockBlock, inputs, mockContext)
-
-      expect(result).toEqual({
-        success: false,
-        error: 'Child workflow non-existent-workflow not found',
-        childWorkflowName: 'non-existent-workflow',
-      })
+      await expect(handler.execute(mockBlock, inputs, mockContext)).rejects.toThrow(
+        'Error in child workflow "non-existent-workflow": Child workflow non-existent-workflow not found'
+      )
     })
 
     it('should handle fetch errors gracefully', async () => {
       const inputs = { workflowId: 'child-workflow-id' }
 
       mockFetch.mockRejectedValueOnce(new Error('Network error'))
 
-      const result = await handler.execute(mockBlock, inputs, mockContext)
-
-      expect(result).toEqual({
-        success: false,
-        error: 'Child workflow child-workflow-id not found',
-        childWorkflowName: 'child-workflow-id',
-      })
+      await expect(handler.execute(mockBlock, inputs, mockContext)).rejects.toThrow(
+        'Error in child workflow "child-workflow-id": Child workflow child-workflow-id not found'
+      )
     })
   })
 

apps/sim/executor/handlers/workflow/workflow-handler.ts

@@ -46,8 +46,8 @@ export class WorkflowBlockHandler implements BlockHandler {
         throw new Error(`Maximum workflow nesting depth of ${MAX_WORKFLOW_DEPTH} exceeded`)
       }
 
-      // Check for cycles
-      const executionId = `${context.workflowId}_sub_${workflowId}`
+      // Check for cycles - include block ID to differentiate parallel executions
+      const executionId = `${context.workflowId}_sub_${workflowId}_${block.id}`
       if (WorkflowBlockHandler.executionStack.has(executionId)) {
         throw new Error(`Cyclic workflow dependency detected: ${executionId}`)
       }
@@ -90,6 +90,9 @@ export class WorkflowBlockHandler implements BlockHandler {
         workflowInput: childWorkflowInput,
         envVarValues: context.environmentVariables,
         workflowVariables: childWorkflow.variables || {},
+        contextExtensions: {
+          isChildExecution: true, // Prevent child executor from managing global state
+        },
       })
 
       const startTime = performance.now()
@@ -105,24 +108,41 @@ export class WorkflowBlockHandler implements BlockHandler {
       logger.info(`Child workflow ${childWorkflowName} completed in ${Math.round(duration)}ms`)
 
       // Map child workflow output to parent block output
-      return this.mapChildOutputToParent(result, workflowId, childWorkflowName, duration)
+      const mappedResult = this.mapChildOutputToParent(
+        result,
+        workflowId,
+        childWorkflowName,
+        duration
+      )
+
+      // If the child workflow failed, throw an error to trigger proper error handling in the parent
+      if ((mappedResult as any).success === false) {
+        const childError = (mappedResult as any).error || 'Unknown error'
+        throw new Error(`Error in child workflow "${childWorkflowName}": ${childError}`)
+      }
+
+      return mappedResult
     } catch (error: any) {
       logger.error(`Error executing child workflow ${workflowId}:`, error)
 
       // Clean up execution stack in case of error
-      const executionId = `${context.workflowId}_sub_${workflowId}`
+      const executionId = `${context.workflowId}_sub_${workflowId}_${block.id}`
       WorkflowBlockHandler.executionStack.delete(executionId)
 
       // Get workflow name for error reporting
       const { workflows } = useWorkflowRegistry.getState()
       const workflowMetadata = workflows[workflowId]
       const childWorkflowName = workflowMetadata?.name || workflowId
 
-      return {
-        success: false,
-        error: error.message || 'Child workflow execution failed',
-        childWorkflowName: childWorkflowName,
-      } as Record<string, any>
+      // Enhance error message with child workflow context
+      const originalError = error.message || 'Unknown error'
+
+      // Check if error message already has child workflow context to avoid duplication
+      if (originalError.startsWith('Error in child workflow')) {
+        throw error // Re-throw as-is to avoid duplication
+      }
+
+      throw new Error(`Error in child workflow "${childWorkflowName}": ${originalError}`)
     }
   }