Skip to content

Commit e1c486b

Browse files
Lint
1 parent 3521c4f commit e1c486b

File tree

2 files changed

+38
-16
lines changed

2 files changed

+38
-16
lines changed

test/split_test.py

Lines changed: 32 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,9 @@ def test_new_end_nodes():
526526
topology.add_nodes([node_1, node_2, node_3, node_4, node_5, node_6])
527527
topology.add_edges([edge_1, edge_2, edge_3, edge_4, edge_5])
528528

529-
topology_a, topology_b, new_end_nodes_matching = Split.split(topology, split_edges={edge_3: 5.0})
529+
topology_a, topology_b, new_end_nodes_matching = Split.split(
530+
topology, split_edges={edge_3: 5.0}
531+
)
530532
for split_edge, new_end_nodes in new_end_nodes_matching.items():
531533
assert split_edge not in topology_a.edges.values()
532534
assert split_edge not in topology_b.edges.values()
@@ -554,8 +556,9 @@ def test_assign_nodes_to_labels():
554556
topology.add_nodes([node_1, node_2, node_3, node_4, node_5, node_6])
555557
topology.add_edges([edge_1, edge_2, edge_3, edge_4, edge_5])
556558

557-
topology_a, topology_b, _ = Split.split(topology, split_edges={edge_3: 5.0},
558-
node_label_assignments={node_1: label_of_node_1})
559+
topology_a, topology_b, _ = Split.split(
560+
topology, split_edges={edge_3: 5.0}, node_label_assignments={node_1: label_of_node_1}
561+
)
559562
if label_of_node_1 == Label.A_Topology:
560563
assert node_1 in topology_a.nodes.values()
561564
else:
@@ -579,8 +582,11 @@ def test_assign_nodes_to_labels_conflicting_label():
579582
topology.add_edges([edge_1, edge_2, edge_3, edge_4, edge_5])
580583

581584
with pytest.raises(ValueError):
582-
topology_a, topology_b, _ = Split.split(topology, split_edges={edge_3: 5.0},
583-
node_label_assignments={node_1: Label.A_Topology, node_2: Label.B_Topology})
585+
topology_a, topology_b, _ = Split.split(
586+
topology,
587+
split_edges={edge_3: 5.0},
588+
node_label_assignments={node_1: Label.A_Topology, node_2: Label.B_Topology},
589+
)
584590

585591

586592
def test_five_parts_after_split():
@@ -603,18 +609,31 @@ def test_five_parts_after_split():
603609
edge_4 = Edge(node_4, node_5)
604610
edge_5 = Edge(node_4, node_6)
605611
edge_6 = Edge(node_7, node_6)
606-
edge_7 = Edge(node_6, node_7, intermediate_geo_nodes=[Wgs84GeoNode(33,5),Wgs84GeoNode(37,5)])
612+
edge_7 = Edge(
613+
node_6, node_7, intermediate_geo_nodes=[Wgs84GeoNode(33, 5), Wgs84GeoNode(37, 5)]
614+
)
607615
edge_8 = Edge(node_8, node_7)
608616
edge_9 = Edge(node_8, node_9)
609617
edge_10 = Edge(node_8, node_10)
610-
topology.add_nodes([node_1, node_2, node_3, node_4, node_5, node_6, node_7, node_8, node_9, node_10])
611-
topology.add_edges([edge_1, edge_2, edge_3, edge_4, edge_5, edge_6, edge_7, edge_8, edge_9, edge_10])
612-
613-
topology_a, topology_b, _ = Split.split(topology, split_edges={edge_3: 5.0, edge_5: 5.0, edge_6: 5.0, edge_7: 5.0, edge_8: 5.0},
614-
node_label_assignments={node_1: losn, node_6: losn, node_10: losn})
618+
topology.add_nodes(
619+
[node_1, node_2, node_3, node_4, node_5, node_6, node_7, node_8, node_9, node_10]
620+
)
621+
topology.add_edges(
622+
[edge_1, edge_2, edge_3, edge_4, edge_5, edge_6, edge_7, edge_8, edge_9, edge_10]
623+
)
624+
625+
topology_a, topology_b, _ = Split.split(
626+
topology,
627+
split_edges={edge_3: 5.0, edge_5: 5.0, edge_6: 5.0, edge_7: 5.0, edge_8: 5.0},
628+
node_label_assignments={node_1: losn, node_6: losn, node_10: losn},
629+
)
615630
if losn == Label.A_Topology:
616-
assert set([node_1, node_2, node_3, node_6, node_8, node_9, node_10]).issubset(topology_a.nodes.values())
631+
assert set([node_1, node_2, node_3, node_6, node_8, node_9, node_10]).issubset(
632+
topology_a.nodes.values()
633+
)
617634
assert set([node_4, node_5, node_7]).issubset(topology_b.nodes.values())
618635
else:
619-
assert set([node_1, node_2, node_3, node_6, node_8, node_9, node_10]).issubset(topology_b.nodes.values())
636+
assert set([node_1, node_2, node_3, node_6, node_8, node_9, node_10]).issubset(
637+
topology_b.nodes.values()
638+
)
620639
assert set([node_4, node_5, node_7]).issubset(topology_a.nodes.values())

yaramo/operations/split.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ def split(
3636
if node_label_assignments is None:
3737
node_label_assignments = {}
3838

39-
node_labels, edge_labels, signal_labels = Split._label_elements(topology, new_end_nodes, node_label_assignments)
39+
node_labels, edge_labels, signal_labels = Split._label_elements(
40+
topology, new_end_nodes, node_label_assignments
41+
)
4042

4143
if add_missing_elements_to_topology is not None:
4244
Split._assign_missing_elements_to_label(
@@ -80,7 +82,9 @@ def _validate_split_edges(split_edges: Dict[Edge, float]):
8082
if edge.length < distance_on_edge:
8183
raise ValueError(f"The edge {edge.name} is shorter than split distance.")
8284
if distance_on_edge <= 0:
83-
raise ValueError(f"The split distance of the edge {edge.name} has to be greater than 0.")
85+
raise ValueError(
86+
f"The split distance of the edge {edge.name} has to be greater than 0."
87+
)
8488
for signal in edge.signals:
8589
if signal.distance_edge == distance_on_edge:
8690
raise ValueError(
@@ -196,7 +200,6 @@ def _dfs(_start_node: Node, _label):
196200
for node, label in node_label_assignments.items():
197201
_dfs(node, label)
198202

199-
200203
for end_node_pair in new_end_nodes.values():
201204
node_a = end_node_pair[0]
202205
node_b = end_node_pair[1]

0 commit comments

Comments
 (0)