Misc cleanups

Author: sinai-dev

src/CSConsole/ScriptEvaluator.cs

@@ -16,7 +16,7 @@ public class ScriptEvaluator : Evaluator, IDisposable
             "mscorlib", "System.Core", "System", "System.Xml"
         };
 
-        internal static TextWriter _textWriter;
+        internal TextWriter _textWriter;
         internal static StreamReportPrinter _reportPrinter;
 
         public ScriptEvaluator(TextWriter tw) : base(BuildContext(tw))
@@ -51,8 +51,13 @@ private void Reference(Assembly asm)
             ReferenceAssembly(asm);
         }
 
+        private static CompilerContext context;
+
         private static CompilerContext BuildContext(TextWriter tw)
         {
+            if (context != null)
+                return context;
+
             _reportPrinter = new StreamReportPrinter(tw);
 
             var settings = new CompilerSettings
@@ -65,7 +70,7 @@ private static CompilerContext BuildContext(TextWriter tw)
                 EnhancedWarnings = false
             };
 
-            return new CompilerContext(settings, _reportPrinter);
+            return context = new CompilerContext(settings, _reportPrinter);
         }
 
         private static void ImportAppdomainAssemblies(Action<Assembly> import)

src/CacheObject/CacheMember.cs

@@ -14,9 +14,6 @@ namespace UnityExplorer.CacheObject
 {
     public abstract class CacheMember : CacheObjectBase
     {
-        //public ReflectionInspector ParentInspector { get; internal set; }
-        //public bool AutoUpdateWanted { get; internal set; }
-
         public abstract Type DeclaringType { get; }
         public string NameForFiltering { get; protected set; }
         public object DeclaringInstance => IsStatic ? null : (m_declaringInstance ?? (m_declaringInstance = Owner.Target.TryCast(DeclaringType)));
@@ -133,7 +130,6 @@ protected override bool SetCellEvaluateState(CacheObjectCell objectcell)
             return false;
         }
 
-
         public void OnEvaluateClicked()
         {
             if (!HasArguments)

src/Core/Reflection/Extensions.cs

@@ -31,9 +31,6 @@ public static T TryCast<T>(this object obj)
             }
         }
 
-        public static HashSet<Type> GetImplementationsOf(this Type baseType, bool allowAbstract, bool allowGeneric)
-             => ReflectionUtility.GetImplementationsOf(baseType, allowAbstract, allowGeneric);
-
         // ------- Misc extensions --------
 
         /// <summary>

src/Core/Reflection/ReflectionUtility.cs

@@ -251,27 +251,25 @@ public static string GetImplementationKey(Type type)
         /// </summary>
         /// <param name="baseType">The base type, which can optionally be abstract / interface.</param>
         /// <returns>All implementations of the type in the current AppDomain.</returns>
-        public static HashSet<Type> GetImplementationsOf(Type baseType, bool allowAbstract, bool allowGeneric, bool allowRecursive = true)
+        public static HashSet<Type> GetImplementationsOf(Type baseType, bool allowAbstract, bool allowGeneric, bool allowEnum, bool allowRecursive = true)
         {
             var key = GetImplementationKey(baseType);
 
             int count = AllTypes.Count;
             HashSet<Type> ret;
             if (!baseType.IsGenericParameter)
-                ret = GetImplementations(key, baseType, allowAbstract, allowGeneric);
+                ret = GetImplementations(key, baseType, allowAbstract, allowGeneric, allowEnum);
             else
                 ret = GetGenericParameterImplementations(key, baseType, allowAbstract, allowGeneric);
 
             // types were resolved during the parse, do it again if we're not already rebuilding.
             if (allowRecursive && AllTypes.Count != count)
-            {
                 ret = GetImplementationsOf(baseType, allowAbstract, allowGeneric, false);
-            }
 
             return ret;
         }
 
-        private static HashSet<Type> GetImplementations(string key, Type baseType, bool allowAbstract, bool allowGeneric)
+        private static HashSet<Type> GetImplementations(string key, Type baseType, bool allowAbstract, bool allowGeneric, bool allowEnum)
         {
             if (!typeInheritance.ContainsKey(key))
             {
@@ -287,7 +285,8 @@ private static HashSet<Type> GetImplementations(string key, Type baseType, bool
                         if (set.Contains(type)
                         || (type.IsAbstract && type.IsSealed) // ignore static classes
                         || (!allowAbstract && type.IsAbstract)
-                        || (!allowGeneric && (type.IsGenericType || type.IsGenericTypeDefinition)))
+                        || (!allowGeneric && (type.IsGenericType || type.IsGenericTypeDefinition))
+                        || (!allowEnum && type.IsEnum))
                             continue;
 
                         if (type.FullName.Contains("PrivateImplementationDetails")

src/Core/Runtime/RuntimeProvider.cs

@@ -56,6 +56,9 @@ public static void Init() =>
 
         public abstract int GetRootCount(Scene scene);
 
+        public void SetColorBlockAuto(Selectable selectable, Color baseColor) 
+            => SetColorBlock(selectable, baseColor, baseColor * 1.2f, baseColor * 0.8f);
+
         public abstract void SetColorBlock(Selectable selectable, ColorBlock colors);
 
         public abstract void SetColorBlock(Selectable selectable, Color? normal = null, Color? highlighted = null, Color? pressed = null,

src/UI/Panels/ObjectExplorerPanel.cs

@@ -102,7 +102,6 @@ protected internal override void DoSetDefaultPosAndAnchors()
             Rect.pivot = new Vector2(0f, 1f);
             Rect.anchorMin = new Vector2(0.125f, 0.175f);
             Rect.anchorMax = new Vector2(0.325f, 0.925f);
-            //mainPanelRect.SetSizeWithCurrentAnchors(RectTransform.Axis.Horizontal, 350);
         }
 
         public override void ConstructPanelContent()

src/UI/Widgets/AutoComplete/TypeCompleter.cs

@@ -20,6 +20,8 @@ public class TypeCompleter : ISuggestionProvider
 
         public Type BaseType { get; set; }
         public Type[] GenericConstraints { get; set; }
+        private bool allowAbstract;
+        private bool allowEnum;
 
         public InputFieldRef InputField { get; }
         public bool AnchorToCaretPosition => false;
@@ -33,11 +35,16 @@ public class TypeCompleter : ISuggestionProvider
 
         bool ISuggestionProvider.AllowNavigation => false;
 
-        public TypeCompleter(Type baseType, InputFieldRef inputField)
+        public TypeCompleter(Type baseType, InputFieldRef inputField) : this(baseType, inputField, true, true) { }
+
+        public TypeCompleter(Type baseType, InputFieldRef inputField, bool allowAbstract, bool allowEnum)
         {
             BaseType = baseType;
             InputField = inputField;
 
+            this.allowAbstract = allowAbstract;
+            this.allowEnum = allowEnum;
+
             inputField.OnValueChanged += OnInputFieldChanged;
 
             if (BaseType != null)
@@ -46,7 +53,7 @@ public TypeCompleter(Type baseType, InputFieldRef inputField)
 
         public void CacheTypes()
         {
-            allowedTypes = ReflectionUtility.GetImplementationsOf(BaseType, true, false);
+            allowedTypes = ReflectionUtility.GetImplementationsOf(BaseType, allowAbstract, allowEnum, false);
         }
 
         public void OnSuggestionClicked(Suggestion suggestion)