Remove patching in mod loader classes

Author: sinai-dev

src/Loader/BIE/ExplorerBepInPlugin.cs

@@ -51,8 +51,7 @@ public ManualLogSource LogSource
         public Action<object> OnLogWarning => LogSource.LogWarning;
         public Action<object> OnLogError => LogSource.LogError;
 
-        // Init common to Mono and Il2Cpp
-        internal void UniversalInit()
+        private void Init()
         {
             Instance = this;
             _configHandler = new BepInExConfigHandler();
@@ -62,57 +61,15 @@ internal void UniversalInit()
 #if MONO // Mono
         internal void Awake()
         {
-            UniversalInit();
+            Init();
         }
 
 #else   // Il2Cpp
         public override void Load()
         {
-            UniversalInit();
+            Init();
         }
 #endif
-
-        public void SetupCursorPatches()
-        {
-            try
-            {
-                this.HarmonyInstance.PatchAll();
-            }
-            catch (Exception ex)
-            {
-                ExplorerCore.Log($"Exception setting up Harmony patches:\r\n{ex.ReflectionExToString()}");
-            }
-        }
-
-        [HarmonyPatch(typeof(EventSystem), "current", MethodType.Setter)]
-        public class PATCH_EventSystem_current
-        {
-            [HarmonyPrefix]
-            public static void Prefix_EventSystem_set_current(ref EventSystem value)
-            {
-                CursorUnlocker.Prefix_EventSystem_set_current(ref value);
-            }
-        }
-
-        [HarmonyPatch(typeof(Cursor), "lockState", MethodType.Setter)]
-        public class PATCH_Cursor_lockState
-        {
-            [HarmonyPrefix]
-            public static void Prefix_set_lockState(ref CursorLockMode value)
-            {
-                CursorUnlocker.Prefix_set_lockState(ref value);
-            }
-        }
-
-        [HarmonyPatch(typeof(Cursor), "visible", MethodType.Setter)]
-        public class PATCH_Cursor_visible
-        {
-            [HarmonyPrefix]
-            public static void Prefix_set_visible(ref bool value)
-            {
-                CursorUnlocker.Prefix_set_visible(ref value);
-            }
-        }
     }
 }
 #endif

src/Loader/IExplorerLoader.cs

@@ -15,7 +15,5 @@ public interface IExplorerLoader
         Action<object> OnLogMessage { get; }
         Action<object> OnLogWarning { get; }
         Action<object> OnLogError { get; }
-
-        void SetupCursorPatches();
     }
 }

src/Loader/ML/ExplorerMelonMod.cs

@@ -9,12 +9,8 @@
 using UnityExplorer.Core.Config;
 using UnityExplorer.Core.Input;
 using UnityExplorer.Loader.ML;
-#if ML_LEGACY
-using Harmony;
-#else
 using HarmonyLib;
 [assembly: MelonPlatformDomain(MelonPlatformDomainAttribute.CompatibleDomains.UNIVERSAL)]
-#endif
 
 [assembly: MelonInfo(typeof(ExplorerMelonMod), ExplorerCore.NAME, ExplorerCore.VERSION, ExplorerCore.AUTHOR)]
 [assembly: MelonGame(null, null)]
@@ -42,45 +38,6 @@ public override void OnApplicationStart()
 
             ExplorerCore.Init(this);
         }
-
-        public void SetupCursorPatches()
-        {
-            try
-            {
-                PrefixProperty(typeof(Cursor),
-                "lockState",
-                new HarmonyMethod(typeof(CursorUnlocker).GetMethod(nameof(CursorUnlocker.Prefix_set_lockState))));
-
-                PrefixProperty(typeof(Cursor),
-                    "visible",
-                    new HarmonyMethod(typeof(CursorUnlocker).GetMethod(nameof(CursorUnlocker.Prefix_set_visible))));
-
-                PrefixProperty(typeof(EventSystem),
-                    "current",
-                    new HarmonyMethod(typeof(CursorUnlocker).GetMethod(nameof(CursorUnlocker.Prefix_EventSystem_set_current))));
-            }
-            catch (Exception ex)
-            {
-                ExplorerCore.Log($"Exception setting up Harmony patches:\r\n{ex.ReflectionExToString()}");
-            }
-        }
-
-        private void PrefixProperty(Type type, string property, HarmonyMethod prefix)
-        {
-            try
-            {
-                var prop = type.GetProperty(property);
-#if ML_LEGACY
-                this.Harmony.Patch(prop.GetSetMethod(), prefix: prefix);
-#else
-                HarmonyInstance.Patch(prop.GetSetMethod(), prefix: prefix);
-#endif
-            }
-            catch (Exception e)
-            {
-                ExplorerCore.Log($"Unable to patch {type.Name}.set_{property}: {e.Message}");
-            }
-        }
     }
 }
 #endif

src/Loader/STANDALONE/ExplorerStandalone.cs

@@ -21,8 +21,7 @@ public class ExplorerStandalone : IExplorerLoader
         /// Call this to initialize UnityExplorer without adding a log listener.
         /// </summary>
         /// <returns>The new (or active, if one exists) instance of ExplorerStandalone.</returns>
-        public static ExplorerStandalone CreateInstance()
-            => CreateInstance(null);
+        public static ExplorerStandalone CreateInstance() => CreateInstance(null);
 
         /// <summary>
         /// Call this to initialize UnityExplorer and add a listener for UnityExplorer's log messages.
@@ -34,7 +33,8 @@ public static ExplorerStandalone CreateInstance(Action<string, LogType> logListe
             if (Instance != null)
                 return Instance;
 
-            OnLog += logListener;
+            if (logListener != null)
+                OnLog += logListener;
 
             var instance = new ExplorerStandalone();
             instance.Init();
@@ -58,19 +58,7 @@ public string ExplorerFolder
         {
             get
             {
-                if (s_explorerFolder == null)
-                {
-                    s_explorerFolder = 
-                        Path.Combine(
-                            Path.GetDirectoryName(
-                                Uri.UnescapeDataString(new Uri(Assembly.GetExecutingAssembly().CodeBase)
-                                .AbsolutePath)), 
-                        "UnityExplorer");
-
-                    if (!Directory.Exists(s_explorerFolder))
-                        Directory.CreateDirectory(s_explorerFolder);
-                }
-
+                CheckExplorerFolder();
                 return s_explorerFolder;
             }
         }
@@ -88,45 +76,18 @@ private void Init()
             ExplorerCore.Init(this);
         }
 
-        public void SetupCursorPatches()
-        {
-            try
-            {
-                this.HarmonyInstance.PatchAll();
-            }
-            catch (Exception ex)
-            {
-                ExplorerCore.Log($"Exception setting up Harmony patches:\r\n{ex.ReflectionExToString()}");
-            }
-        }
-
-        [HarmonyPatch(typeof(EventSystem), "current", MethodType.Setter)]
-        public class PATCH_EventSystem_current
+        private void CheckExplorerFolder()
         {
-            [HarmonyPrefix]
-            public static void Prefix_EventSystem_set_current(ref EventSystem value)
+            if (s_explorerFolder == null)
             {
-                CursorUnlocker.Prefix_EventSystem_set_current(ref value);
-            }
-        }
-
-        [HarmonyPatch(typeof(Cursor), "lockState", MethodType.Setter)]
-        public class PATCH_Cursor_lockState
-        {
-            [HarmonyPrefix]
-            public static void Prefix_set_lockState(ref CursorLockMode value)
-            {
-                CursorUnlocker.Prefix_set_lockState(ref value);
-            }
-        }
+                s_explorerFolder =
+                    Path.Combine(
+                        Path.GetDirectoryName(
+                            Uri.UnescapeDataString(new Uri(Assembly.GetExecutingAssembly().CodeBase).AbsolutePath)),
+                        "UnityExplorer");
 
-        [HarmonyPatch(typeof(Cursor), "visible", MethodType.Setter)]
-        public class PATCH_Cursor_visible
-        {
-            [HarmonyPrefix]
-            public static void Prefix_set_visible(ref bool value)
-            {
-                CursorUnlocker.Prefix_set_visible(ref value);
+                if (!Directory.Exists(s_explorerFolder))
+                    Directory.CreateDirectory(s_explorerFolder);
             }
         }
     }