Use whitespace as delimiter in completion composition, handle string/comment state with Lexer

Author: sinai-dev

src/UI/CSConsole/CSAutoCompleter.cs

@@ -59,11 +59,9 @@ public void CheckAutocompletes()
             {
                 startIdx--;
                 char c = InputField.Text[startIdx];
-                if (delimiters.Contains(c))
+                if (delimiters.Contains(c) || char.IsWhiteSpace(c))
                 {
                     startIdx++;
-                    while (char.IsWhiteSpace(InputField.Text[startIdx]))
-                        startIdx++;
                     break;
                 }
             }

src/UI/CSConsole/ConsoleController.cs

@@ -231,20 +231,24 @@ private static void OnInputChanged(string value)
             previousInput = value;
 
             if (EnableSuggestions && AutoCompleteModal.CheckEnter(Completer))
-            {
                 OnAutocompleteEnter();
-            }
-            else if (!settingCaretCoroutine)
+
+            var inStringOrComment = HighlightVisibleInput();
+            
+            if (!settingCaretCoroutine)
             {
                 if (EnableSuggestions)
-                    Completer.CheckAutocompletes();
+                {
+                    if (inStringOrComment)
+                        AutoCompleteModal.Instance.ReleaseOwnership(Completer);
+                    else
+                        Completer.CheckAutocompletes();
+                }
 
                 if (EnableAutoIndent)
                     DoAutoIndent();
             }
 
-            HighlightVisibleInput();
-
             UpdateCaret(out _);
         }
 
@@ -372,7 +376,10 @@ private static IEnumerator SetAutocompleteCaretCoro(int caretPosition)
 
         #region Lexer Highlighting
 
-        private static void HighlightVisibleInput()
+        /// <summary>
+        /// Returns true if caret is inside string or comment, false otherwise
+        /// </summary>
+        private static bool HighlightVisibleInput()
         {
             int startIdx = 0;
             int endIdx = Input.Text.Length - 1;
@@ -410,7 +417,8 @@ private static void HighlightVisibleInput()
             }
 
             // Highlight the visible text with the LexerBuilder
-            Panel.HighlightText.text = Lexer.BuildHighlightedString(Input.Text, startIdx, endIdx, topLine);
+            Panel.HighlightText.text = Lexer.BuildHighlightedString(Input.Text, startIdx, endIdx, topLine, LastCaretPosition, out bool ret);
+            return ret;
         }
 
         #endregion

src/UI/CSConsole/LexerBuilder.cs

@@ -14,6 +14,7 @@ public struct MatchInfo
         public int startIndex;
         public int endIndex;
         public string htmlColorTag;
+        public bool isStringOrComment;
     }
 
     public class LexerBuilder
@@ -82,8 +83,10 @@ public LexerBuilder()
         /// <param name="endIdx">The last character you want to highlight</param>
         /// <param name="leadingLines">The amount of leading empty lines you want before the first character in the return string.</param>
         /// <returns>A string which contains the amount of leading lines specified, as well as the rich-text highlighted section.</returns>
-        public string BuildHighlightedString(string input, int startIdx, int endIdx, int leadingLines)
+        public string BuildHighlightedString(string input, int startIdx, int endIdx, int leadingLines, int caretIdx, out bool caretInStringOrComment)
         {
+            caretInStringOrComment = false;
+
             if (string.IsNullOrEmpty(input) || endIdx <= startIdx)
                 return input;
 
@@ -105,12 +108,14 @@ public string BuildHighlightedString(string input, int startIdx, int endIdx, int
 
                 // append the highlighted match
                 sb.Append(match.htmlColorTag);
-
                 for (int i = match.startIndex; i <= match.endIndex && i <= currentEndIdx; i++)
                     sb.Append(input[i]);
-
                 sb.Append(SignatureHighlighter.CLOSE_COLOR);
 
+                // check caretIdx to determine inStringOrComment state
+                if (caretIdx >= match.startIndex && caretIdx <= match.endIndex)
+                    caretInStringOrComment = match.isStringOrComment;
+
                 // update the last unhighlighted start index
                 lastUnhighlighted = match.endIndex + 1;
             }
@@ -150,6 +155,7 @@ public IEnumerable<MatchInfo> GetMatches()
                             startIndex = startIndex,
                             endIndex = CommittedIndex,
                             htmlColorTag = lexer.ColorTag,
+                            isStringOrComment = lexer is StringLexer || lexer is CommentLexer,
                         };
                         break;
                     }