Skip to content
This repository was archived by the owner on May 9, 2023. It is now read-only.

Commit c79223f

Browse files
committed
Move MouseInspector dropdown to Inspector panel
1 parent aae248b commit c79223f

File tree

3 files changed

+19
-14
lines changed

3 files changed

+19
-14
lines changed

src/Inspectors/InspectUnderMouse.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public static void OnDropdownSelect(int index)
7777
case 1: Instance.StartInspect(MouseInspectMode.World); break;
7878
case 2: Instance.StartInspect(MouseInspectMode.UI); break;
7979
}
80-
UIManager.MouseInspectDropdown.value = 0;
80+
InspectorPanel.Instance.MouseInspectDropdown.value = 0;
8181
}
8282

8383
public void StartInspect(MouseInspectMode mode)
@@ -111,7 +111,7 @@ public void StopInspect()
111111
UIManager.NavBarRect.gameObject.SetActive(true);
112112
UIManager.PanelHolder.SetActive(true);
113113

114-
var drop = UIManager.MouseInspectDropdown;
114+
var drop = InspectorPanel.Instance.MouseInspectDropdown;
115115
if (drop.transform.Find("Dropdown List") is Transform list)
116116
drop.DestroyDropdownList(list.gameObject);
117117

src/UI/Panels/InspectorPanel.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public class InspectorPanel : UIPanel
2424
public override int MinHeight => 350;
2525

2626
public GameObject NavbarHolder;
27+
public Dropdown MouseInspectDropdown;
2728
public GameObject ContentHolder;
2829
public RectTransform ContentRect;
2930

@@ -60,9 +61,21 @@ protected internal override void DoSetDefaultPosAndAnchors()
6061

6162
public override void ConstructPanelContent()
6263
{
64+
var closeHolder = this.titleBar.transform.Find("CloseHolder").gameObject;
65+
66+
// Inspect under mouse dropdown on title bar
67+
68+
var mouseDropdown = UIFactory.CreateDropdown(closeHolder, out MouseInspectDropdown, "Mouse Inspect", 14,
69+
InspectUnderMouse.OnDropdownSelect);
70+
UIFactory.SetLayoutElement(mouseDropdown, minHeight: 25, minWidth: 140);
71+
MouseInspectDropdown.options.Add(new Dropdown.OptionData("Mouse Inspect"));
72+
MouseInspectDropdown.options.Add(new Dropdown.OptionData("World"));
73+
MouseInspectDropdown.options.Add(new Dropdown.OptionData("UI"));
74+
mouseDropdown.transform.SetSiblingIndex(0);
75+
6376
// add close all button to titlebar
6477

65-
var closeAllBtn = UIFactory.CreateButton(this.titleBar.transform.Find("CloseHolder").gameObject, "CloseAllBtn", "Close All",
78+
var closeAllBtn = UIFactory.CreateButton(closeHolder.gameObject, "CloseAllBtn", "Close All",
6679
new Color(0.3f, 0.2f, 0.2f));
6780
UIFactory.SetLayoutElement(closeAllBtn.Component.gameObject, minHeight: 25, minWidth: 80);
6881
closeAllBtn.Component.transform.SetSiblingIndex(closeAllBtn.Component.transform.GetSiblingIndex() - 1);

src/UI/UIManager.cs

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ public enum VerticalAnchor
5555

5656
public static RectTransform NavBarRect;
5757
public static GameObject NavbarTabButtonHolder;
58-
public static Dropdown MouseInspectDropdown;
5958

6059
private static ButtonRef closeBtn;
6160
private static ButtonRef pauseBtn;
@@ -84,9 +83,11 @@ internal static void InitUI()
8483
lastScreenWidth = Screen.width;
8584
lastScreenHeight = Screen.height;
8685

87-
// Create UI
86+
// Create UI.
8887
CreatePanelHolder();
8988
CreateTopNavBar();
89+
// This could be automated with Assembly.GetTypes(),
90+
// but the order is important and I'd have to write something to handle the order.
9091
UIPanels.Add(Panels.AutoCompleter, new AutoCompleteModal());
9192
UIPanels.Add(Panels.ObjectExplorer, new ObjectExplorerPanel());
9293
UIPanels.Add(Panels.Inspector, new InspectorPanel());
@@ -338,15 +339,6 @@ private static void CreateTopNavBar()
338339
UIFactory.SetLayoutElement(pauseBtn.Component.gameObject, minHeight: 25, minWidth: 25);
339340
pauseBtn.OnClick += OnPauseButtonClicked;
340341

341-
// Inspect under mouse dropdown
342-
343-
var mouseDropdown = UIFactory.CreateDropdown(navbarPanel, out MouseInspectDropdown, "Mouse Inspect", 14,
344-
InspectUnderMouse.OnDropdownSelect);
345-
UIFactory.SetLayoutElement(mouseDropdown, minHeight: 25, minWidth: 140);
346-
MouseInspectDropdown.options.Add(new Dropdown.OptionData("Mouse Inspect"));
347-
MouseInspectDropdown.options.Add(new Dropdown.OptionData("World"));
348-
MouseInspectDropdown.options.Add(new Dropdown.OptionData("UI"));
349-
350342
// Hide menu button
351343

352344
closeBtn = UIFactory.CreateButton(navbarPanel, "CloseButton", ConfigManager.Master_Toggle.Value.ToString());

0 commit comments

Comments
 (0)