Skip to content

Unhandled rejections for default actions using electron-dl #195

@achou11

Description

@achou11

Not the end of the world but does add unnecessary noise for those who may have error reporting integrations set up (such as Sentry).

Initial thought is that there should be catches for these calls that just no-op depending on the error (e.g. CancelError), since there's no way to hook into the error-handling when using the default actions.

The relevant actions:

saveImage:

download(win, properties.srcURL);

saveImageAs:

download(win, properties.srcURL, {saveAs: true});

saveVideo:

download(win, properties.srcURL);

saveVideoAs:

download(win, properties.srcURL, {saveAs: true});

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions