Refactor prefer-replace-all with stricter selector (#516)

Author: fisker

rules/prefer-replace-all.js

@@ -1,6 +1,14 @@
 'use strict';
 const getDocumentationUrl = require('./utils/get-documentation-url');
 const quoteString = require('./utils/quote-string');
+const methodSelector = require('./utils/method-selector');
+
+const selector = methodSelector({
+	name: 'replace',
+	length: 2
+});
+
+const message = 'Prefer `String#replaceAll()` over `String#replace()`.';
 
 function isRegexWithGlobalFlag(node) {
 	const {type, regex} = node;
@@ -29,13 +37,8 @@ function removeEscapeCharacters(regexString) {
 
 const create = context => {
 	return {
-		'CallExpression[callee.property.name="replace"]': node => {
+		[selector]: node => {
 			const {arguments: arguments_} = node;
-
-			if (arguments_.length !== 2) {
-				return;
-			}
-
 			const [search] = arguments_;
 
 			if (!isRegexWithGlobalFlag(search) || !isLiteralCharactersOnly(search)) {
@@ -44,7 +47,7 @@ const create = context => {
 
 			context.report({
 				node,
-				message: 'Prefer `String#replaceAll()` over `String#replace()`.',
+				message,
 				fix: fixer =>
 					[
 						fixer.insertTextAfter(node.callee, 'All'),

test/prefer-replace-all.js

@@ -29,16 +29,20 @@ ruleTester.run('prefer-replace-all', rule, {
 		// Not 2 arguments
 		'foo.replace(/a/g)',
 		'foo.replace(/\\\\./g)',
-		// New
+		// Not `CallExpression`
 		'new foo.replace(/a/g, bar)',
-		// Function call
+		// Not `MemberExpression`
 		'replace(/a/g, bar)',
-		// Not call
-		'foo.replace',
+		// Computed
+		'foo[replace](/a/g, bar);',
 		// Not replace
 		'foo.methodNotReplace(/a/g, bar);',
-		// `replace` is not Identifier
-		'foo[\'replace\'](/a/g, bar)'
+		// `callee.property` is not a `Identifier`
+		'foo[\'replace\'](/a/g, bar)',
+		// More or less argument(s)
+		'foo.replace(/a/g, bar, extra);',
+		'foo.replace();',
+		'foo.replace(...argumentsArray, ...argumentsArray2)'
 	],
 	invalid: [
 		{