Ensure all the rules are compatible with TypeScript-ESLint (#519)

Author: JounQin

rules/escape-case.js

@@ -52,6 +52,8 @@ Record escaped node position in regexpp ASTNode. Returns undefined if not found.
 			const matches = node.raw.match(escapePatternWithLowercase);
 
 			if (matches && matches.groups.data.slice(1).match(hasLowercaseCharacter)) {
+				// There is no `range` property in AST from `regexpp`
+				// reference: https://github.com/mysticatea/regexpp/blob/master/src/ast.ts#L60-L71
 				escapeNodePosition = [node.start, node.end];
 			}
 		}

rules/no-hex-escape.js

@@ -10,7 +10,16 @@ function checkEscape(context, node, value) {
 		context.report({
 			node,
 			message: 'Use Unicode escapes instead of hexadecimal escapes.',
-			fix: fixer => fixer.replaceTextRange([node.start, node.end], fixedValue)
+			fix: fixer => {
+				let {range: [start, end], type, tail} = node;
+
+				if (type === 'TemplateElement') {
+					start += 1;
+					end -= tail ? 1 : 2;
+				}
+
+				return fixer.replaceTextRange([start, end], fixedValue);
+			}
 		});
 	}
 }

rules/no-nested-ternary.js

@@ -8,9 +8,9 @@ const isParethesized = (sourceCode, node) => {
 	return (
 		Boolean(previousToken && nextToken) &&
 		previousToken.value === '(' &&
-		previousToken.end <= node.start &&
+		previousToken.end <= node.range[0] &&
 		nextToken.value === ')' &&
-		nextToken.start >= node.end
+		nextToken.start >= node.range[1]
 	);
 };
 

rules/no-new-buffer.js

@@ -8,7 +8,7 @@ const create = context => {
 		'NewExpression[callee.name="Buffer"]': node => {
 			const method = inferMethod(node.arguments);
 			const range = [
-				node.start,
+				node.range[0],
 				node.callee.end
 			];
 

test/no-hex-escape.js

@@ -8,12 +8,19 @@ const ruleTester = avaRuleTester(test, {
 	}
 });
 
+const babelRuleTester = avaRuleTester(test, {
+	parser: require.resolve('babel-eslint')
+});
+const typescriptRuleTester = avaRuleTester(test, {
+	parser: require.resolve('@typescript-eslint/parser')
+});
+
 const error = {
 	ruleId: 'no-hex-escape',
 	message: 'Use Unicode escapes instead of hexadecimal escapes.'
 };
 
-ruleTester.run('no-hex-escape', rule, {
+const tests = {
 	valid: [
 		'const foo = \'foo\'',
 		'const foo = \'\\u00b1\'',
@@ -117,6 +124,11 @@ ruleTester.run('no-hex-escape', rule, {
 			errors: [error],
 			output: 'const foo = \'42\\\\\\u001242\\\\\\u0034\''
 		},
+		{
+			code: 'const foo = /^[\\x20-\\x7E]*$/',
+			errors: [error],
+			output: 'const foo = /^[\\u0020-\\u007E]*$/'
+		},
 		// Test template literals
 		{
 			code: 'const foo = `\\xb1`',
@@ -187,6 +199,17 @@ ruleTester.run('no-hex-escape', rule, {
 			code: 'const foo = `42\\\\\\x1242\\\\\\x34`',
 			errors: [error],
 			output: 'const foo = `42\\\\\\u001242\\\\\\u0034`'
+		},
+		{
+			// eslint-disable-next-line no-template-curly-in-string
+			code: 'const foo = `\\xb1${foo}\\xb1${foo}`',
+			errors: [error, error],
+			// eslint-disable-next-line no-template-curly-in-string
+			output: 'const foo = `\\u00b1${foo}\\u00b1${foo}`'
 		}
 	]
-});
+};
+
+ruleTester.run('no-hex-escape', rule, tests);
+babelRuleTester.run('no-hex-escape', rule, tests);
+typescriptRuleTester.run('no-hex-escape', rule, tests);