exts

Author: mmkal

docs/rules/isolated-functions.md

@@ -8,6 +8,7 @@
 Some functions need to be isolated from their surrounding scope due to execution context constraints. For example, functions passed to `makeSynchronous()` are executed in a subprocess and cannot access variables from outside their scope. This rule helps identify when functions are using external variables that may cause runtime errors.
 
 Common scenarios where functions must be isolated:
+
 - Functions passed to `makeSynchronous()` (executed in subprocess)
 - Functions that will be serialized via `Function.prototype.toString()`
 - Server actions or other remote execution contexts
@@ -213,4 +214,4 @@ makeSynchronous(async () => {
 	const url = new URL(response.url); // ✅ Allowed global
 	return response.text();
 });
-``` 
+```

rules/isolated-functions.js

@@ -16,21 +16,17 @@ const parseEsquerySelector = selector => {
 	return parsedEsquerySelectors.get(selector);
 };
 
-/** @type {{functions: string[], selectors: string[], comments: string[], globals: boolean | string[]}} */
-const defaultOptions = {
-	functions: ['makeSynchronous'],
-	selectors: [],
-	comments: ['@isolated'],
-	globals: false,
-};
-
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	const {sourceCode} = context;
-	/** @type {typeof defaultOptions} */
+	/** @type {{functions: string[], selectors: string[], comments: string[], globals: boolean | string[]}} */
 	const userOptions = context.options[0];
+	/** @type {typeof userOptions} */
 	const options = {
-		...defaultOptions,
+		functions: ['makeSynchronous'],
+		selectors: [],
+		comments: ['@isolated'],
+		globals: false,
 		...userOptions,
 	};
 
@@ -43,7 +39,7 @@ const create = context => {
 
 	/** @param {import('estree').Node} node */
 	const checkForExternallyScopedVariables = node => {
-		const reason = reasaonForBeingIsolatedFunction(node);
+		const reason = reasonForBeingIsolatedFunction(node);
 		if (!reason) {
 			return;
 		}
@@ -68,17 +64,20 @@ const create = context => {
 	};
 
 	/** @param {import('estree').Node & {parent?: import('estree').Node}} node */
-	const reasaonForBeingIsolatedFunction = node => {
+	const reasonForBeingIsolatedFunction = node => {
 		if (options.comments.length > 0) {
 			let previousToken = sourceCode.getTokenBefore(node, {includeComments: true});
 			let commentableNode = node;
-			while (previousToken?.type !== 'Block' && (commentableNode.parent.type === 'VariableDeclarator' || commentableNode.parent.type === 'VariableDeclaration')) {
+			while (
+				(previousToken?.type !== 'Block' && previousToken?.type !== 'Line')
+				&& (commentableNode.parent.type === 'VariableDeclarator' || commentableNode.parent.type === 'VariableDeclaration')
+			) {
 				// Search up to find jsdoc comments on the parent declaration `/** @isolated */ const foo = () => abc`
 				commentableNode = commentableNode.parent;
 				previousToken = sourceCode.getTokenBefore(commentableNode, {includeComments: true});
 			}
 
-			if (previousToken?.type === 'Block') {
+			if (previousToken?.type === 'Block' || previousToken?.type === 'Line') {
 				const previousComment = previousToken.value.trim().toLowerCase();
 				const match = options.comments.find(comment => previousComment.includes(comment));
 				if (match) {
@@ -104,8 +103,6 @@ const create = context => {
 				return `matches selector ${JSON.stringify(matchedSelector)}`;
 			}
 		}
-
-		
 	};
 
 	return Object.fromEntries(functionTypes.map(type => [

test/isolated-functions.mjs renamed to test/isolated-functions.js

@@ -1,5 +1,5 @@
 import stripIndent from 'strip-indent';
-import {getTester} from './utils/test.mjs';
+import {getTester} from './utils/test.js';
 
 const {test} = getTester(import.meta);
 
@@ -85,9 +85,18 @@ test({
 			`),
 			errors: [error({name: 'foo', reason: 'follows comment containing "@isolated"'})],
 		},
+		{
+			name: '@isolated inline comment',
+			code: stripIndent(`
+				const foo = 'hi';
+				// @isolated
+				const abc = () => foo.slice();
+			`),
+			errors: [error({name: 'foo', reason: 'follows comment containing "@isolated"'})],
+		},
 		{
 			name: 'global variables not allowed by default',
-			globals: {foo: true},
+			languageOptions: {globals: {foo: true}},
 			code: stripIndent(`
 				makeSynchronous(function () {
 					return foo.slice();
@@ -97,7 +106,7 @@ test({
 		},
 		{
 			name: 'global variables can be explicitly disallowed',
-			globals: {foo: true},
+			languageOptions: {globals: {foo: true}},
 			options: [{globals: false}],
 			code: stripIndent(`
 				makeSynchronous(function () {
@@ -171,7 +180,7 @@ test({
 		},
 		{
 			name: 'can allow global variables from language options',
-			globals: {foo: true},
+			languageOptions: {globals: {foo: true}},
 			options: [{globals: true}],
 			code: stripIndent(`
 				makeSynchronous(function () {
@@ -181,7 +190,7 @@ test({
 		},
 		{
 			name: 'allow global variables separate from language options',
-			globals: {abc: true},
+			languageOptions: {globals: {abc: true}},
 			options: [{globals: ['foo']}],
 			code: stripIndent(`
 				makeSynchronous(function () {