Fix mistake in the new-for-builtins rule

`Symbol` should *not* be used with `new`.

Author: sindresorhus

docs/rules/new-for-builtins.md

@@ -22,7 +22,6 @@ Enforces the use of `new` for following builtins.
 - `WeakSet`
 - `Promise`
 - `RegExp`
-- `Symbol`
 - `Uint8Array`
 - `Uint16Array`
 - `Uint32Array`
@@ -33,6 +32,7 @@ Disallows the use of `new` for following builtins.
 - `String`
 - `Number`
 - `Boolean`
+- `Symbol`
 
 > These should not use `new` as that would create object wrappers for the primitive values, which is not what you want. However, without `new` they can be useful for coercing a value to that type.
 

rules/new-for-builtins.js

@@ -18,7 +18,6 @@ const enforceNew = new Set([
 	'WeakSet',
 	'Promise',
 	'RegExp',
-	'Symbol',
 	'Uint8Array',
 	'Uint16Array',
 	'Uint32Array',
@@ -28,7 +27,8 @@ const enforceNew = new Set([
 const disallowNew = new Set([
 	'Boolean',
 	'Number',
-	'String'
+	'String',
+	'Symbol'
 ]);
 
 const create = context => {

test/new-for-builtins.js

@@ -39,14 +39,14 @@ ruleTester.run('new-for-builtins', rule, {
 		`const foo = new WeakSet()`,
 		`const foo = new Promise()`,
 		`const foo = new RegExp()`,
-		`const foo = new Symbol()`,
 		`const foo = new UInt8Array()`,
 		`const foo = new UInt16Array()`,
 		`const foo = new UInt32Array()`,
 		`const foo = new Uint8ClampedArray()`,
 		`const foo = Boolean()`,
 		`const foo = Number()`,
-		`const foo = String()`
+		`const foo = String()`,
+		`const foo = Symbol()`
 	],
 	invalid: [
 		{
@@ -149,11 +149,6 @@ ruleTester.run('new-for-builtins', rule, {
 			errors: [enforceNewError('RegExp')],
 			output: `const foo = new RegExp()`
 		},
-		{
-			code: `const foo = Symbol()`,
-			errors: [enforceNewError('Symbol')],
-			output: `const foo = new Symbol()`
-		},
 		{
 			code: `const foo = Uint8Array()`,
 			errors: [enforceNewError('Uint8Array')],
@@ -193,6 +188,11 @@ ruleTester.run('new-for-builtins', rule, {
 			code: `const foo = new String()`,
 			errors: [disallowNewError('String')],
 			output: `const foo = String()`
+		},
+		{
+			code: `const foo = new Symbol()`,
+			errors: [disallowNewError('Symbol')],
+			output: `const foo = Symbol()`
 		}
 	]
 });