Tweaks (#1033)

fisker · web-flow · commit 700f8bfd6e84 · 2021-01-19T12:04:56.000+07:00
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -30,15 +30,15 @@ jobs:
         if: matrix.os == 'ubuntu-latest' && matrix.node-version == 14
         with:
           fail_ci_if_error: true
-  lint:
+  run-rules-on-codebase:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
           node-version: 14
       - run: npm install
-      - run: npm run lint
+      - run: npm run run-rules-on-codebase
   integration:
     runs-on: ubuntu-latest
     steps:
diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
 	"scripts": {
 		"test": "xo && nyc ava",
 		"create-rule": "node ./scripts/create-rule.js",
-		"lint": "node ./test/lint/lint.js",
+		"run-rules-on-codebase": "node ./test/run-rules-on-codebase/lint.js",
 		"integration": "node ./test/integration/test.js",
 		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.js"
 	},
@@ -98,7 +98,7 @@
 			"plugin:eslint-plugin/all"
 		],
 		"ignores": [
-			"test/integration/{fixtures,unicorn}/**",
+			"test/integration/{fixtures,fixtures-local}/**",
 			".cache-eslint-remote-tester",
 			"eslint-remote-tester-results"
 		],
diff --git a/scripts/template/test.js.jst b/scripts/template/test.js.jst
@@ -25,6 +25,6 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const foo = \'unicorn\';'
 ]);
diff --git a/test/consistent-function-scoping.js b/test/consistent-function-scoping.js
@@ -803,7 +803,7 @@ test.typescript({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		function foo() {
 			function bar() {}
diff --git a/test/empty-brace-spaces.js b/test/empty-brace-spaces.js
@@ -78,7 +78,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		try {
 			foo();
diff --git a/test/error-message.js b/test/error-message.js
@@ -31,7 +31,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'throw new Error()',
 	'throw Error()',
 	'throw new Error(\'\')',
diff --git a/test/explicit-length-check.js b/test/explicit-length-check.js
@@ -129,7 +129,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		if (
 			!!!(
diff --git a/test/import-style.js b/test/import-style.js
@@ -618,7 +618,7 @@ test.babel({
 	].map(test => addDefaultOptions(test))
 });
 
-test.visualize([
+test.snapshot([
 	'import util from \'util\'',
 	'import * as util from \'util\'',
 	'const util = require(\'util\')',
diff --git a/test/integration/fixtures-local/error-name-conflicts.js b/test/integration/fixtures-local/error-name-conflicts.js
diff --git a/test/integration/projects.js b/test/integration/projects.js
@@ -3,8 +3,8 @@ const path = require('path');
 
 module.exports = [
 	{
-		name: 'unicorn',
-		location: path.join(__dirname, 'unicorn')
+		name: 'fixtures-local',
+		location: path.join(__dirname, 'fixtures-local')
 	},
 	{
 		repository: 'https://github.com/avajs/ava',
diff --git a/test/new-for-builtins.js b/test/new-for-builtins.js
@@ -322,7 +322,7 @@ test({
 	]
 });
 
-test.visualize({
+test.snapshot({
 	valid: [],
 	invalid: [
 		'const object = (Object)();',
diff --git a/test/no-abusive-eslint-disable.js b/test/no-abusive-eslint-disable.js
@@ -67,7 +67,7 @@ ruleTester.run('no-abusive-eslint-disable', rule, {
 	]
 });
 
-runTest.visualize([
+runTest.snapshot([
 	'eval(); // eslint-disable-line',
 	outdent`
 		foo();
diff --git a/test/no-array-push-push.js b/test/no-array-push-push.js
@@ -1,7 +1,7 @@
 import {outdent} from 'outdent';
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		outdent`
 			foo.forEach(fn);
diff --git a/test/no-console-spaces.js b/test/no-console-spaces.js
@@ -194,7 +194,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'console.log("abc", " def ", "ghi");',
 	outdent`
 		console.error(
diff --git a/test/no-for-loop.js b/test/no-for-loop.js
@@ -781,7 +781,7 @@ runTest.typescript({
 	]
 });
 
-runTest.visualize([
+runTest.snapshot([
 	outdent`
 		for (let i = 0; i < arr.length; i += 1) {
 			console.log(arr[i])
diff --git a/test/no-hex-escape.js b/test/no-hex-escape.js
@@ -213,6 +213,6 @@ ruleTester.run('no-hex-escape', rule, tests);
 babelRuleTester.run('no-hex-escape', rule, tests);
 typescriptRuleTester.run('no-hex-escape', rule, tests);
 
-runTest.visualize([
+runTest.snapshot([
 	'const foo = "\\xb1"'
 ]);
diff --git a/test/no-instanceof-array.js b/test/no-instanceof-array.js
@@ -1,7 +1,7 @@
 import {outdent} from 'outdent';
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		'Array.isArray(arr)',
 		'arr instanceof Object',
diff --git a/test/no-lonely-if.js b/test/no-lonely-if.js
@@ -31,7 +31,7 @@ test({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		if (a) {
 			if (b) {
diff --git a/test/no-nested-ternary.js b/test/no-nested-ternary.js
@@ -64,7 +64,7 @@ test.typescript({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	'const foo = i > 5 ? i < 100 ? true : false : i < 100 ? true : false;',
 	'const foo = i > 5 ? true : (i < 100 ? true : (i < 1000 ? true : false));',
 	outdent`
diff --git a/test/no-new-array.js b/test/no-new-array.js
@@ -123,7 +123,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const array = new Array(1)',
 	// This is actually `[]`, but we fix to `Array.from({length: zero})`
 	outdent`
diff --git a/test/no-new-buffer.js b/test/no-new-buffer.js
@@ -80,7 +80,7 @@ test.typescript({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const buf = new Buffer()',
 	'const buf = new Buffer([0x62, 0x75, 0x66, 0x66, 0x65, 0x72])'
 ]);
diff --git a/test/no-object-as-default-parameter.js b/test/no-object-as-default-parameter.js
@@ -161,7 +161,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'function abc(foo = {a: 123}) {}',
 	'const abc = (foo = {a: false}) => {};'
 ]);
diff --git a/test/no-process-exit.js b/test/no-process-exit.js
@@ -97,6 +97,6 @@ test({
 	].map(code => ({code, errors}))
 });
 
-test.visualize([
+test.snapshot([
 	'process.exit(1);'
 ]);
diff --git a/test/no-this-assignment.js b/test/no-this-assignment.js
@@ -1,7 +1,7 @@
 import {outdent} from 'outdent';
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		'const {property} = this;',
 		'const property = this.property;',
diff --git a/test/no-unreadable-array-destructuring.js b/test/no-unreadable-array-destructuring.js
@@ -1,6 +1,6 @@
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		'const [, foo] = parts;',
 		'const [foo] = parts;',
diff --git a/test/no-unsafe-regex.js b/test/no-unsafe-regex.js
@@ -42,6 +42,6 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const foo = /(x+x+)+y/g'
 ]);
diff --git a/test/no-unused-properties.js b/test/no-unused-properties.js
@@ -420,7 +420,7 @@ test.babel({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		function foo() {
 			const bar = {
diff --git a/test/no-useless-undefined.js b/test/no-useless-undefined.js
@@ -235,7 +235,7 @@ test.typescript({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		foo(
 			undefined,
diff --git a/test/no-zero-fractions.js b/test/no-zero-fractions.js
@@ -96,7 +96,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const foo = 1.0',
 	'const foo = (1.).toString()'
 ]);
diff --git a/test/number-literal-case.js b/test/number-literal-case.js
@@ -169,6 +169,6 @@ ruleTester.run('number-literal-case', rule, tests);
 babelRuleTester.run('number-literal-case', rule, tests);
 typescriptRuleTester.run('number-literal-case', rule, tests);
 
-runTest.visualize([
+runTest.snapshot([
 	'console.log(BigInt(0B10 + 1.2E+3) + 0XdeEd_Beefn)'
 ]);
diff --git a/test/numeric-separators-style.js b/test/numeric-separators-style.js
@@ -331,7 +331,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'console.log(0XdeEdBeeFn)',
 	'const foo = 12345678..toString()'
 ]);
diff --git a/test/prefer-add-event-listener.js b/test/prefer-add-event-listener.js
@@ -65,7 +65,7 @@ test({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	'foo.onclick = () => {}',
 	'foo.onclick = 1',
 	'foo.bar.onclick = onClick',
diff --git a/test/prefer-array-flat-map.js b/test/prefer-array-flat-map.js
@@ -225,7 +225,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const bar = [[1],[2],[3]].map(i => [i]).flat()',
 	'const bar = [[1],[2],[3]].map(i => [i]).flat(1.00)',
 	'const bar = [[1],[2],[3]].map(i => [i]).flat(1,)',
diff --git a/test/prefer-array-index-of.js b/test/prefer-array-index-of.js
@@ -142,7 +142,7 @@ test.typescript({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'values.findIndex(x => x === "foo")',
 	'values.findIndex(x => "foo" === x)',
 	'values.findIndex(x => {return x === "foo";})',
diff --git a/test/prefer-array-some.js b/test/prefer-array-some.js
@@ -90,7 +90,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'if (array.find(element => element === "🦄")) {}',
 	'const foo = array.find(element => element === "🦄") ? bar : baz;',
 	outdent`
diff --git a/test/prefer-date-now.js b/test/prefer-date-now.js
@@ -1,6 +1,6 @@
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		'const ts = Date.now()',
 
diff --git a/test/prefer-dom-node-dataset.js b/test/prefer-dom-node-dataset.js
@@ -88,7 +88,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		element.setAttribute(
 			\'data-foo\', // comment
diff --git a/test/prefer-keyboard-event-key.js b/test/prefer-keyboard-event-key.js
@@ -797,7 +797,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	outdent`
 		window.addEventListener('click', ({which, another}) => {
 			if (which === 23) {
diff --git a/test/prefer-math-trunc.js b/test/prefer-math-trunc.js
@@ -1,7 +1,7 @@
 import {outdent} from 'outdent';
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		'const foo = 1 | 1;',
 		'const foo = 0 | 1;',
diff --git a/test/prefer-negative-index.js b/test/prefer-negative-index.js
@@ -359,7 +359,7 @@ test({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'foo.slice(foo.length - 2, foo.length - 1)',
 	'foo.splice(foo.length - 1, 1)'
 ]);
diff --git a/test/prefer-number-properties.js b/test/prefer-number-properties.js
@@ -307,7 +307,7 @@ test.typescript({
 	]
 });
 
-test.visualize([
+test.snapshot([
 	'const foo = {[NaN]: 1}',
 	'const foo = {[NaN]() {}}',
 	'foo[NaN] = 1;',
diff --git a/test/prefer-query-selector.js b/test/prefer-query-selector.js
@@ -32,7 +32,7 @@ test({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	'document.getElementById("foo");',
 	'document.getElementsByClassName("foo");',
 	'document.getElementsByClassName("foo bar");',
diff --git a/test/prefer-regexp-test.js b/test/prefer-regexp-test.js
@@ -42,7 +42,7 @@ test({
 	invalid: []
 });
 
-test.visualize([
+test.snapshot([
 	// `String#match()`
 	'const bar = !foo.match(re)',
 	'const bar = Boolean(foo.match(re))',
diff --git a/test/prefer-spread.js b/test/prefer-spread.js
@@ -1,7 +1,7 @@
 import {outdent} from 'outdent';
 import {test} from './utils/test.js';
 
-test.visualize({
+test.snapshot({
 	valid: [
 		'[...set].map(() => {});',
 		// TypedArray.from
diff --git a/test/prefer-string-replace-all.js b/test/prefer-string-replace-all.js
diff --git a/test/prefer-string-starts-ends-with.js b/test/prefer-string-starts-ends-with.js
diff --git a/test/prefer-string-trim-start-end.js b/test/prefer-string-trim-start-end.js
diff --git a/test/run-rules-on-codebase/lint.js b/test/run-rules-on-codebase/lint.js
diff --git a/test/utils/snapshot-rule-tester.js b/test/utils/snapshot-rule-tester.js
diff --git a/test/utils/test.js b/test/utils/test.js

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,6 @@ test({`
`25`	`25`	`]`
`26`	`26`	`});`
`27`	`27`
`28`		`-test.visualize([`
	`28`	`+test.snapshot([`
`29`	`29`	`'const foo = \'unicorn\';'`
`30`	`30`	`]);`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ test({`
`78`	`78`	`]`
`79`	`79`	`});`
`80`	`80`
`81`		`-test.visualize([`
	`81`	`+test.snapshot([`
`82`	`82`	outdent`
`83`	`83`	`try {`
`84`	`84`	`foo();`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ test({`
`31`	`31`	`]`
`32`	`32`	`});`
`33`	`33`
`34`		`-test.visualize([`
	`34`	`+test.snapshot([`
`35`	`35`	`'throw new Error()',`
`36`	`36`	`'throw Error()',`
`37`	`37`	`'throw new Error(\'\')',`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ test({`
`129`	`129`	`]`
`130`	`130`	`});`
`131`	`131`
`132`		`-test.visualize([`
	`132`	`+test.snapshot([`
`133`	`133`	outdent`
`134`	`134`	`if (`
`135`	`135`	`!!!(`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@ const path = require('path');`
`3`	`3`
`4`	`4`	`module.exports = [`
`5`	`5`	`{`
`6`		`- name: 'unicorn',`
`7`		`- location: path.join(__dirname, 'unicorn')`
	`6`	`+ name: 'fixtures-local',`
	`7`	`+ location: path.join(__dirname, 'fixtures-local')`
`8`	`8`	`},`
`9`	`9`	`{`
`10`	`10`	`repository: 'https://github.com/avajs/ava',`