Replace case change functions with change-case (#2648)

Author: fisker

eslint.config.js

@@ -21,7 +21,6 @@ const config = [
 			'coverage',
 			'.cache-eslint-remote-tester',
 			'eslint-remote-tester-results',
-			'rules/utils/lodash.js',
 			'test/integration/{fixtures,fixtures-local}/**',
 			'workaround-for-eslint-doc-generator',
 			'**/*.ts',

eslint.dogfooding.config.js

@@ -22,7 +22,6 @@ const config = [
 			'coverage',
 			'test/integration/fixtures',
 			'test/integration/fixtures-local',
-			'rules/utils/lodash.js',
 		],
 	},
 	{

package.json

@@ -20,7 +20,6 @@
 		"node": "^18.20.0 || ^20.10.0 || >=21.0.0"
 	},
 	"scripts": {
-		"bundle-lodash": "echo export {camelCase, kebabCase, snakeCase, upperFirst, lowerFirst} from 'lodash-es'; | npx esbuild --bundle --outfile=rules/utils/lodash.js --format=esm",
 		"create-rule": "node ./scripts/create-rule.js && npm run create-rules-index-file && npm run fix:eslint-docs",
 		"create-rules-index-file": "node ./scripts/create-rules-index-file.js",
 		"fix": "run-p --continue-on-error fix:*",
@@ -60,6 +59,7 @@
 		"@babel/helper-validator-identifier": "^7.27.1",
 		"@eslint-community/eslint-utils": "^4.7.0",
 		"@eslint/plugin-kit": "^0.3.1",
+		"change-case": "^5.4.4",
 		"ci-info": "^4.2.0",
 		"clean-regexp": "^1.0.0",
 		"core-js-compat": "^3.42.0",
@@ -95,7 +95,6 @@
 		"eslint-remote-tester-repositories": "^2.0.1",
 		"espree": "^10.3.0",
 		"listr2": "^8.3.3",
-		"lodash-es": "^4.17.21",
 		"markdownlint-cli": "^0.44.0",
 		"memoize": "^10.1.0",
 		"nano-spawn": "^0.2.0",

rules/catch-error-name.js

@@ -1,6 +1,6 @@
 import {isRegExp} from 'node:util/types';
 import {findVariable} from '@eslint-community/eslint-utils';
-import {getAvailableVariableName} from './utils/index.js';
+import {getAvailableVariableName, upperFirst} from './utils/index.js';
 import {renameVariable} from './fix/index.js';
 import {isMethodCall} from './ast/index.js';
 
@@ -47,7 +47,7 @@ const create = context => {
 		name === expectedName
 		|| ignore.some(regexp => regexp.test(name))
 		|| name.endsWith(expectedName)
-		|| name.endsWith(expectedName.charAt(0).toUpperCase() + expectedName.slice(1));
+		|| name.endsWith(upperFirst(expectedName));
 
 	return {
 		Identifier(node) {

rules/custom-error-definition.js

@@ -1,4 +1,4 @@
-import {upperFirst} from './utils/lodash.js';
+import {upperFirst} from './utils/index.js';
 
 const MESSAGE_ID_INVALID_EXPORT = 'invalidExport';
 const messages = {

rules/filename-case.js

@@ -4,8 +4,8 @@ import {
 	camelCase,
 	kebabCase,
 	snakeCase,
-	upperFirst,
-} from './utils/lodash.js';
+	pascalCase,
+} from 'change-case';
 import cartesianProductSamples from './utils/cartesian-product-samples.js';
 
 const MESSAGE_ID = 'filename-case';
@@ -15,35 +15,10 @@ const messages = {
 	[MESSAGE_ID_EXTENSION]: 'File extension `{{extension}}` is not in lowercase. Rename it to `{{filename}}`.',
 };
 
-const pascalCase = string => upperFirst(camelCase(string));
-const numberRegex = /\d+/;
-const PLACEHOLDER = '\uFFFF\uFFFF\uFFFF';
-const PLACEHOLDER_REGEX = new RegExp(PLACEHOLDER, 'i');
 const isIgnoredChar = char => !/^[a-z\d-_]$/i.test(char);
 const ignoredByDefault = new Set(['index.js', 'index.mjs', 'index.cjs', 'index.ts', 'index.tsx', 'index.vue']);
 const isLowerCase = string => string === string.toLowerCase();
 
-function ignoreNumbers(caseFunction) {
-	return string => {
-		const stack = [];
-		let execResult = numberRegex.exec(string);
-
-		while (execResult) {
-			stack.push(execResult[0]);
-			string = string.replace(execResult[0], PLACEHOLDER);
-			execResult = numberRegex.exec(string);
-		}
-
-		let withCase = caseFunction(string);
-
-		while (stack.length > 0) {
-			withCase = withCase.replace(PLACEHOLDER_REGEX, stack.shift());
-		}
-
-		return withCase;
-	};
-}
-
 const cases = {
 	camelCase: {
 		fn: camelCase,
@@ -172,7 +147,7 @@ const create = context => {
 		return new RegExp(item, 'u');
 	});
 	const multipleFileExtensions = options.multipleFileExtensions !== false;
-	const chosenCasesFunctions = chosenCases.map(case_ => ignoreNumbers(cases[case_].fn));
+	const chosenCasesFunctions = chosenCases.map(case_ => cases[case_].fn);
 	const filenameWithExtension = context.physicalFilename;
 
 	if (filenameWithExtension === '<input>' || filenameWithExtension === '<text>') {

rules/no-anonymous-default-export.js

@@ -1,10 +1,10 @@
 import path from 'node:path';
 import {getFunctionHeadLocation, getFunctionNameWithKind, isOpeningParenToken} from '@eslint-community/eslint-utils';
 import helperValidatorIdentifier from '@babel/helper-validator-identifier';
+import {camelCase} from 'change-case';
 import getClassHeadLocation from './utils/get-class-head-location.js';
-import {upperFirst, camelCase} from './utils/lodash.js';
 import {getParenthesizedRange} from './utils/parentheses.js';
-import {getScopes, getAvailableVariableName} from './utils/index.js';
+import {getScopes, getAvailableVariableName, upperFirst} from './utils/index.js';
 import {isMemberExpression} from './ast/index.js';
 
 const {isIdentifierName} = helperValidatorIdentifier;

rules/no-unnecessary-polyfills.js

@@ -1,6 +1,6 @@
 import path from 'node:path';
 import coreJsCompat from 'core-js-compat';
-import {camelCase} from './utils/lodash.js';
+import {camelCase} from 'change-case';
 import isStaticRequire from './ast/is-static-require.js';
 import {readPackageJson} from './shared/package-json.js';
 

rules/prevent-abbreviations.js

@@ -1,13 +1,14 @@
 import path from 'node:path';
 import {isRegExp} from 'node:util/types';
-import {upperFirst, lowerFirst} from './utils/lodash.js';
 import {
 	getAvailableVariableName,
 	cartesianProductSamples,
 	isShorthandPropertyValue,
 	isShorthandImportLocal,
 	getVariableIdentifiers,
 	getScopes,
+	upperFirst,
+	lowerFirst,
 } from './utils/index.js';
 import {defaultReplacements, defaultAllowList, defaultIgnore} from './shared/abbreviations.js';
 import {renameVariable} from './fix/index.js';

rules/utils/index.js

@@ -52,3 +52,4 @@ export {default as shouldAddParenthesesToMemberExpressionObject} from './should-
 export {default as singular} from './singular.js';
 export {default as toLocation} from './to-location.js';
 export {default as getAncestor} from './get-ancestor.js';
+export * from './string-cases.js';