Refactor prefer-node-remove with selector (#517)

Author: fisker

rules/prefer-node-remove.js

@@ -1,16 +1,12 @@
 'use strict';
 const getDocumentationUrl = require('./utils/get-documentation-url');
 const isValueNotUsable = require('./utils/is-value-not-usable');
+const methodSelector = require('./utils/method-selector');
 
-const getMethodName = callee => {
-	const {property} = callee;
-
-	if (property.type === 'Identifier') {
-		return property.name;
-	}
-
-	return null;
-};
+const selector = methodSelector({
+	name: 'removeChild',
+	length: 1
+});
 
 const getCallerName = callee => {
 	const {object} = callee;
@@ -46,22 +42,12 @@ const getArgumentName = arguments_ => {
 
 const create = context => {
 	return {
-		CallExpression(node) {
+		[selector](node) {
 			const {callee} = node;
 
-			if (
-				node.arguments.length === 0 ||
-				callee.type !== 'MemberExpression' ||
-				callee.computed
-			) {
-				return;
-			}
-
-			const methodName = getMethodName(callee);
 			const callerName = getCallerName(callee);
 
 			if (
-				methodName === 'removeChild' &&
 				(callerName === 'parentNode' || callerName === 'parentElement')
 			) {
 				const argumentName = getArgumentName(node.arguments);

test/prefer-node-remove.js

@@ -26,9 +26,20 @@ ruleTester.run('prefer-node-remove', rule, {
 		'this.remove()',
 		'remove()',
 		'foo.parentNode.removeChild(\'bar\')',
-		'foo.parentNode[\'bar\'](foo)',
-		'foo.parentNode[removeChild](foo)',
-		'foo.parentNode.removeChild()'
+		// Not `CallExpression`
+		'new foo.parentNode.removeChild(foo);',
+		// Not `MemberExpression`
+		'removeChild(foo);',
+		// `callee.property` is not a `Identifier`
+		'foo.parentNode[\'removeChild\'](foo);',
+		// Computed
+		'foo.parentNode[removeChild](foo);',
+		// Not `removeChild`
+		'foo.parentNode.foo(foo);',
+		// More or less argument(s)
+		'foo.parentNode.removeChild(foo, two);',
+		'foo.parentNode.removeChild();',
+		'foo.parentNode.removeChild(...argumentsArray)'
 	],
 	invalid: [
 		invalidTestCase(