minor consistency tweaks and dependency bumps

Author: sindresorhus

package.json

@@ -58,8 +58,8 @@
     "ava": "*",
     "coveralls": "^2.11.9",
     "eslint": "^3.5.0",
-    "eslint-ava-rule-tester": "^0.1.1",
-    "nyc": "^6.4.0",
+    "eslint-ava-rule-tester": "^2.0.0",
+    "nyc": "^8.3.2",
     "pify": "^2.3.0",
     "xo": "*"
   },

rules/explicit-length-check.js

@@ -18,7 +18,7 @@ function checkExpression(context, node) {
 	) {
 		context.report({
 			node,
-			message: '`length` property should be compared to a value'
+			message: '`length` property should be compared to a value.'
 		});
 	}
 }

rules/number-literal-case.js

@@ -19,7 +19,7 @@ const create = context => {
 			if (value !== fixedValue) {
 				context.report({
 					node,
-					message: 'Invalid number literal casing',
+					message: 'Invalid number literal casing.',
 					fix: fixer => fixer.replaceText(node, fixedValue)
 				});
 			}
@@ -28,8 +28,8 @@ const create = context => {
 };
 
 module.exports = {
+	create,
 	meta: {
 		fixable: 'code'
-	},
-	create
+	}
 };

test/explicit-length-check.js

@@ -10,7 +10,7 @@ const ruleTester = avaRuleTester(test, {
 
 const errors = [{
 	ruleId: 'explicit-length-check',
-	message: '`length` property should be compared to a value'
+	message: '`length` property should be compared to a value.'
 }];
 
 ruleTester.run('explicit-length-check', rule, {

test/number-literal-case.js

@@ -13,7 +13,7 @@ const ruleTester = avaRuleTester(test, {
 
 const error = {
 	ruleId: 'number-literal-case',
-	message: 'Invalid number literal casing'
+	message: 'Invalid number literal casing.'
 };
 
 ruleTester.run('number-literal-case', rule, {

test/package.js

@@ -1,20 +1,21 @@
 import fs from 'fs';
+import path from 'path';
 import test from 'ava';
 import pify from 'pify';
 import index from '../';
 
 test('Every rule is defined in index file', async t => {
-	const files = await pify(fs.readdir, Promise)('../rules/');
-	const rules = files.filter(file => file.indexOf('.js') === file.length - 3);
+	const files = await pify(fs.readdir)('../rules');
+	const ruleFiles = files.filter(file => path.extname(file) === '.js');
 
-	rules.forEach(file => {
-		const name = file.slice(0, -3);
+	for (const file of ruleFiles) {
+		const name = path.basename(file, '.js');
 		t.truthy(index.rules[name], `'${name}' is not exported in 'index.js'`);
 		t.truthy(index.configs.recommended.rules[`unicorn/${name}`], `'${name}' is not set in the recommended config`);
-	});
+	}
 
-	t.is(Object.keys(index.rules).length, rules.length,
+	t.is(Object.keys(index.rules).length, ruleFiles.length,
 		'There are more exported rules than rule files.');
-	t.is(Object.keys(index.configs.recommended.rules).length, rules.length,
+	t.is(Object.keys(index.configs.recommended.rules).length, ruleFiles.length,
 		'There are more exported rules in the recommended config than rule files.');
 });