Use @babel/eslint-parser in tests (#961)

Author: fisker

package.json

@@ -52,6 +52,8 @@
 	"devDependencies": {
 		"@ava/babel": "^1.0.1",
 		"@babel/code-frame": "7.12.11",
+		"@babel/core": "7.12.10",
+		"@babel/eslint-parser": "7.12.1",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
 		"@typescript-eslint/parser": "^4.12.0",
 		"ava": "^3.15.0",

test/custom-error-definition.js

@@ -500,17 +500,6 @@ runTest.babel({
 				}
 			`,
 			errors: [invalidNameError('ValidationError')]
-		},
-		{
-			code: outdent`
-				export class ValidationError extends Error {
-					'name': SomeType;
-					constructor(message) {
-						super(message);
-					}
-				}
-			`,
-			errors: [invalidNameError('ValidationError')]
 		}
 	]
 });
@@ -523,5 +512,17 @@ runTest.typescript({
 			}
 		`
 	],
-	invalid: []
+	invalid: [
+		{
+			code: outdent`
+				export class ValidationError extends Error {
+					'name': SomeType;
+					constructor(message) {
+						super(message);
+					}
+				}
+			`,
+			errors: [invalidNameError('ValidationError')]
+		}
+	]
 });

test/integration/projects.js

@@ -8,8 +8,7 @@ module.exports = [
 	},
 	{
 		repository: 'https://github.com/avajs/ava',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'test/node_modules'
 		]
 	},
@@ -48,53 +47,41 @@ module.exports = [
 	'https://github.com/sindresorhus/pageres',
 	{
 		repository: 'https://github.com/sindresorhus/got',
-		extraArguments: [
-			'--ignore-pattern',
-			'documentation/examples/gh-got.js' // This file use `package` keyword as variable
+		ignore: [
+			// This file use `package` keyword as variable
+			'documentation/examples/gh-got.js'
 		]
 	},
 	'https://github.com/eslint/eslint',
 	{
 		repository: 'https://github.com/prettier/prettier',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'tests/**'
 		]
 	},
 	'https://github.com/facebook/react',
 	{
 		repository: 'https://github.com/angular/angular',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'aio/content/examples/animations/src/app/open-close.component.3.ts',
-			'--ignore-pattern',
 			'aio/content/examples/router/src/app/app-routing.module.9.ts',
-
-			'--ignore-pattern',
 			'aio/tools/transforms/templates/data-module.template.js',
-			'--ignore-pattern',
 			'aio/tools/transforms/authors-package/index.js', // This file use `package` keyword as variable
-
-			'--ignore-pattern',
 			'packages/compiler-cli/test/**',
-
-			'--ignore-pattern',
 			'tools/**'
 		]
 	},
 	{
 		repository: 'https://github.com/microsoft/typescript',
-		extraArguments: [
+		ignore: [
 			// These file use `'\033'`
-			'--ignore-pattern',
 			'build/**'
 		]
 	},
 	{
 		repository: 'https://github.com/microsoft/vscode',
-		extraArguments: [
+		ignore: [
 			// This file use `'\033'`
-			'--ignore-pattern',
 			'build/**'
 		]
 	},
@@ -108,33 +95,28 @@ module.exports = [
 	'https://github.com/gatsbyjs/gatsby',
 	{
 		repository: 'https://github.com/puppeteer/puppeteer',
-		extraArguments: [
+		ignore: [
 			// Parser error on `await page.evaluate(() => delete Node);`
 			// https://github.com/puppeteer/puppeteer/blob/0b1a9ceee2f05f534f0d50079ece172d627a93c7/test/jshandle.spec.js#L151
-			'--ignore-pattern',
 			'test/jshandle.spec.js',
 
 			// `package` keyword
 			// https://github.com/puppeteer/puppeteer/blob/0b1a9ceee2f05f534f0d50079ece172d627a93c7/utils/apply_next_version.js#L17
-			'--ignore-pattern',
 			'utils/apply_next_version.js'
 		]
 	},
 	{
 		repository: 'https://github.com/vercel/next.js',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'examples/**',
 
 			// These files use `>` in jsx
-			'--ignore-pattern',
 			'test/integration/**'
 		]
 	},
 	{
 		repository: 'https://github.com/chakra-ui/chakra-ui',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'scripts/create-package.js' // This file use `package` keyword as variable
 		]
 	},
@@ -144,16 +126,14 @@ module.exports = [
 	// #912
 	{
 		repository: 'https://github.com/microsoft/fluentui',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'scripts/publish-beta.js' // This file use `package` keyword as variable
 		]
 	},
 	// #902
 	{
 		repository: 'https://github.com/reakit/reakit',
-		extraArguments: [
-			'--ignore-pattern',
+		ignore: [
 			'packages/reakit/jest.config.js' // This file use `package` keyword as variable
 		]
 	},
@@ -169,15 +149,13 @@ module.exports = [
 	const {
 		repository,
 		name = repository.split('/').pop(),
-		path = '',
-		extraArguments = []
+		ignore = []
 	} = project;
 
 	return {
 		...project,
 		name,
 		repository,
-		path,
-		extraArguments
+		ignore
 	};
 });

test/integration/test.js

@@ -27,18 +27,21 @@ const enrichErrors = (packageName, cliArguments, f) => async (...arguments_) =>
 const makeEslintTask = (project, destination) => {
 	const arguments_ = [
 		'eslint',
+		project.path || '.',
 		'--fix-dry-run',
 		'--no-eslintrc',
 		'--ext',
 		'.js,.ts,.vue',
 		'--format',
 		'json',
 		'--config',
-		path.join(__dirname, 'config.js'),
-		project.path || '.',
-		...project.extraArguments
+		path.join(__dirname, 'config.js')
 	];
 
+	for (const pattern of project.ignore) {
+		arguments_.push('--ignore-pattern', pattern);
+	}
+
 	return enrichErrors(project.name, arguments_, async () => {
 		let stdout;
 		let processError;

test/prefer-ternary.js

@@ -1279,7 +1279,7 @@ test({
 	]
 });
 
-test.babel({
+test.babelLegacy({
 	valid: [],
 	invalid: [
 		// https://github.com/facebook/react/blob/7a1691cdff209249b49a4472ba87b542980a5f71/packages/react-dom/src/client/DOMPropertyOperations.js#L183

test/prevent-abbreviations.js

@@ -1753,42 +1753,6 @@ runTest.babel({
 			errors: createErrors()
 		},
 
-		// #347
-		{
-			code: outdent`
-				function onKeyDown(e: KeyboardEvent) {
-					if (e.keyCode) {}
-				}
-			`,
-			output: outdent`
-				function onKeyDown(event: KeyboardEvent) {
-					if (event.keyCode) {}
-				}
-			`,
-			options: [
-				{
-					extendDefaultReplacements: false,
-					replacements: {
-						e: {
-							event: true
-						}
-					}
-				}
-			],
-			errors: createErrors()
-		},
-
-		// https://github.com/facebook/relay/blob/597d2a17aa29d401830407b6814a5f8d148f632d/packages/relay-experimental/EntryPointTypes.flow.js#L138
-		{
-			code: outdent`
-				export type PreloadProps<TExtraProps = null> = {}
-			`,
-			output: outdent`
-				export type PreloadProperties<TExtraProperties = null> = {}
-			`,
-			errors: [...createErrors(), ...createErrors()]
-		},
-
 		noFixingTestCase({
 			code: '(class {e = 1})',
 			options: checkPropertiesOptions,
@@ -1861,6 +1825,58 @@ runTest.typescript({
 				export default Property;
 			`,
 			errors: 1
+		},
+
+		// #347
+		{
+			code: outdent`
+				function onKeyDown(e: KeyboardEvent) {
+					if (e.keyCode) {}
+				}
+			`,
+			output: outdent`
+				function onKeyDown(event: KeyboardEvent) {
+					if (event.keyCode) {}
+				}
+			`,
+			options: [
+				{
+					extendDefaultReplacements: false,
+					replacements: {
+						e: {
+							event: true
+						}
+					}
+				}
+			],
+			errors: createErrors()
+		},
+
+		// https://github.com/facebook/relay/blob/597d2a17aa29d401830407b6814a5f8d148f632d/packages/relay-experimental/EntryPointTypes.flow.js#L138
+		{
+			code: outdent`
+				export type PreloadProps<TExtraProps = null> = {}
+			`,
+			output: outdent`
+				export type PreloadProperties<TExtraProperties = null> = {}
+			`,
+			errors: [...createErrors(), ...createErrors()]
+		}
+	]
+});
+
+runTest.babelLegacy({
+	valid: [],
+	invalid: [
+		// https://github.com/facebook/relay/blob/597d2a17aa29d401830407b6814a5f8d148f632d/packages/relay-experimental/EntryPointTypes.flow.js#L138
+		{
+			code: outdent`
+				export type PreloadProps<TExtraProps = null> = {};
+			`,
+			output: outdent`
+				export type PreloadProperties<TExtraProperties = null> = {};
+			`,
+			errors: [...createErrors(), ...createErrors()]
 		}
 	]
 });

test/utils/test.js

@@ -31,6 +31,28 @@ runTest.typescript = tests => runTest({
 });
 
 runTest.babel = tests => runTest({
+	...tests,
+	testerOptions: {
+		parser: require.resolve('@babel/eslint-parser'),
+		parserOptions: {
+			...defaultParserOptions,
+
+			requireConfigFile: false,
+			sourceType: 'module',
+			allowImportExportEverywhere: true,
+			babelOptions: {
+				parserOpts: {
+					plugins: [
+						'jsx',
+						'classProperties'
+					]
+				}
+			}
+		}
+	}
+});
+
+runTest.babelLegacy = tests => runTest({
 	...tests,
 	testerOptions: {parser: require.resolve('babel-eslint')}
 });