Allow isNodeMatchesNameOrPath to match super and MetaProperty (#2762)

Author: fisker

rules/utils/is-node-matches.js

@@ -17,20 +17,32 @@ export function isNodeMatchesNameOrPath(node, nameOrPath) {
 			return (
 				(node.type === 'Identifier' && node.name === name)
 				|| (name === 'this' && node.type === 'ThisExpression')
+				|| (name === 'super' && node.type === 'Super')
 			);
 		}
 
 		if (
-			node.type !== 'MemberExpression'
-			|| node.optional
-			|| node.computed
-			|| node.property.type !== 'Identifier'
-			|| node.property.name !== name
+			index === 1
+			&& node.type === 'MetaProperty'
+			&& node.property.type === 'Identifier'
+			&& node.property.name === name
 		) {
-			return false;
+			node = node.meta;
+			continue;
+		}
+
+		if (
+			node.type === 'MemberExpression'
+			&& !node.optional
+			&& !node.computed
+			&& node.property.type === 'Identifier'
+			&& node.property.name === name
+		) {
+			node = node.object;
+			continue;
 		}
 
-		node = node.object;
+		return false;
 	}
 }
 

test/prefer-structured-clone.js

@@ -71,5 +71,27 @@ test.snapshot({
 			code: 'my.cloneDeep(foo,)',
 			options: [{functions: ['my.cloneDeep']}],
 		},
+		// Coverage for `isNodeMatchesNameOrPath`
+		{
+			code: outdent`
+				class A {
+					constructor() {
+						this.a = new.target.cloneDeep(foo);
+						this.b = import.meta.cloneDeep(foo);
+					}
+				}
+			`,
+			options: [{functions: ['new.target.cloneDeep']}],
+		},
+		{
+			code: outdent`
+				class A {
+					constructor() {
+						this.a = super.cloneDeep(foo);
+					}
+				}
+			`,
+			options: [{functions: ['super.cloneDeep']}],
+		},
 	],
 });

test/snapshots/prefer-structured-clone.js.md

@@ -299,3 +299,92 @@ Generated by [AVA](https://avajs.dev).
     Suggestion 1/1: Switch to \`structuredClone(…)\`.␊
       1 | structuredClone(foo,)␊
     `
+
+## invalid(6): class A { constructor() { this.a = new.target.cloneDeep(foo); this.b = import.meta.cloneDeep(foo); } }
+
+> Input
+
+    `␊
+      1 | class A {␊
+      2 | 	constructor() {␊
+      3 | 		this.a = new.target.cloneDeep(foo);␊
+      4 | 		this.b = import.meta.cloneDeep(foo);␊
+      5 | 	}␊
+      6 | }␊
+    `
+
+> Options
+
+    `␊
+    [␊
+      {␊
+        "functions": [␊
+          "new.target.cloneDeep"␊
+        ]␊
+      }␊
+    ]␊
+    `
+
+> Error 1/1
+
+    `␊
+      1 | class A {␊
+      2 | 	constructor() {␊
+    > 3 | 		this.a = new.target.cloneDeep(foo);␊
+        | 		         ^^^^^^^^^^^^^^^^^^^^ Prefer \`structuredClone(…)\` over \`new.target.cloneDeep(…)\` to create a deep clone.␊
+      4 | 		this.b = import.meta.cloneDeep(foo);␊
+      5 | 	}␊
+      6 | }␊
+    ␊
+    --------------------------------------------------------------------------------␊
+    Suggestion 1/1: Switch to \`structuredClone(…)\`.␊
+      1 | class A {␊
+      2 | 	constructor() {␊
+      3 | 		this.a = structuredClone(foo);␊
+      4 | 		this.b = import.meta.cloneDeep(foo);␊
+      5 | 	}␊
+      6 | }␊
+    `
+
+## invalid(7): class A { constructor() { this.a = super.cloneDeep(foo); } }
+
+> Input
+
+    `␊
+      1 | class A {␊
+      2 | 	constructor() {␊
+      3 | 		this.a = super.cloneDeep(foo);␊
+      4 | 	}␊
+      5 | }␊
+    `
+
+> Options
+
+    `␊
+    [␊
+      {␊
+        "functions": [␊
+          "super.cloneDeep"␊
+        ]␊
+      }␊
+    ]␊
+    `
+
+> Error 1/1
+
+    `␊
+      1 | class A {␊
+      2 | 	constructor() {␊
+    > 3 | 		this.a = super.cloneDeep(foo);␊
+        | 		         ^^^^^^^^^^^^^^^ Prefer \`structuredClone(…)\` over \`super.cloneDeep(…)\` to create a deep clone.␊
+      4 | 	}␊
+      5 | }␊
+    ␊
+    --------------------------------------------------------------------------------␊
+    Suggestion 1/1: Switch to \`structuredClone(…)\`.␊
+      1 | class A {␊
+      2 | 	constructor() {␊
+      3 | 		this.a = structuredClone(foo);␊
+      4 | 	}␊
+      5 | }␊
+    `